mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-04 20:46:11 +02:00
Code Issues Projects Releases Wiki Activity

CLEANUP: stick-tables: Don't needlessly compute shard number in stksess_free()

Browse Source 
Since commit 0bda33a3e ("MINOR: stick-tables: remove the uneeded read lock
in stksess_free()"), the lock on the shard is no longer acquired. So it is
useless to still compture the shard number. The result is never used and can
be safely removed.
This commit is contained in:
Christopher Faulet 2025-11-12 17:59:24 +01:00
parent 346d6c3ac7
commit 14a333c4f4
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/stick_table.c
View File

@ -101,8 +101,6 @@ void __stksess_free(struct stktable *t, struct stksess *ts)
*/
void stksess_free(struct stktable *t, struct stksess *ts)
{
uint shard;
size_t len;
void *data;
data = stktable_data_ptr(t, ts, STKTABLE_DT_SERVER_KEY);
@ -111,16 +109,6 @@ void stksess_free(struct stktable *t, struct stksess *ts)
stktable_data_cast(data, std_t_dict) = NULL;
}
if (t->type == SMP_T_STR)
len = strlen((const char *)ts->key.key);
else
len = t->key_size;
shard = stktable_calc_shard_num(t, ts->key.key, len);
/* make the compiler happy when shard is not used without threads */
ALREADY_CHECKED(shard);
__stksess_free(t, ts);
}