mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 22:31:28 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: stats: fix source buffer size for http dump

Browse Source 
In ("BUG/MINOR: stats: use proper buffer size for http dump"),
we used trash.size as source buffer size before applying the htx
overhead computation.

It is safer to use res->buf.size instead since res_htx (which is <htx> argument
passed to stats_putchk() in http context) is made from res->buf:

in http_stats_io_handler:
    | res_htx = htx_from_buf(&res->buf);

This will prevent the hang bug from showing up again if res->buf.size were to be
less than trash.size (which is set according to tune.bufsize).

This should be backported with ("BUG/MINOR: stats: use proper buffer size for http dump")
This commit is contained in:
Aurelien DARRAGON 2023-02-03 08:31:42 +01:00 committed by Christopher Faulet
parent e74d77b301
commit 14656844cc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/stats.c
View File

@ -4458,7 +4458,7 @@ static void http_stats_io_handler(struct appctx *appctx)
} }
if (appctx->st0 == STAT_HTTP_DUMP) { if (appctx->st0 == STAT_HTTP_DUMP) {
trash_chunk = b_make(trash.area, trash.size, 0, 0); trash_chunk = b_make(trash.area, res->buf.size, 0, 0);
/* adjust buffer size to take htx overhead into account, /* adjust buffer size to take htx overhead into account,
* make sure to perform this call on an empty buffer * make sure to perform this call on an empty buffer
*/ */