mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 14:21:25 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: Unexpected connection closures upon idle timer task execution

Browse Source 
This bug arrived with this commit:

      MEDIUM: quic: Ack delay implementation

It is possible that the idle timer task was already in the run queue when its
->expire field was updated calling qc_idle_timer_do_rearm(). To prevent this
task from running in this condition, one must check its ->expire field value
with this condition to run the task if its timer has really expired:

	!tick_is_expired(t->expire, now_ms)

Furthermore, as this task may be directly woken up with a call to task_wakeup()
all, for instance by qc_kill_conn() to kill the connection, one must check this
task has really been woken up when it was in the wait queue and not by a direct
call to task_wakeup() thanks to this test:

	(state & TASK_WOKEN_ANY) == TASK_WOKEN_TIMER

Again, when this condition is not fulfilled, the task must be run.

Must be backported where the commit mentionned above was backported.
This commit is contained in:
Frédéric Lécaille 2023-04-04 10:46:54 +02:00 committed by Amaury Denoyelle
parent 495968ed51
commit 12eca3a727
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/quic_conn.c
View File

@ -5681,6 +5681,9 @@ struct task *qc_idle_timer_task(struct task *t, void *ctx, unsigned int state)
TRACE_ENTER(QUIC_EV_CONN_IDLE_TIMER, qc); TRACE_ENTER(QUIC_EV_CONN_IDLE_TIMER, qc);
if ((state & TASK_WOKEN_ANY) == TASK_WOKEN_TIMER && !tick_is_expired(t->expire, now_ms))
goto requeue;
if (tick_is_expired(qc->ack_expire, now_ms)) { if (tick_is_expired(qc->ack_expire, now_ms)) {
TRACE_PROTO("ack timer expired", QUIC_EV_CONN_SSLALERT, qc); TRACE_PROTO("ack timer expired", QUIC_EV_CONN_SSLALERT, qc);
qc->ack_expire = TICK_ETERNITY; qc->ack_expire = TICK_ETERNITY;