From 1212db417b198820ab14c754dc847a46a48698a0 Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Mon, 28 Oct 2019 14:26:56 +0100 Subject: [PATCH] BUG/MINOR: ssl/cli: cleanup on cli_parse_set_cert error Since commit 90b098c ("BUG/MINOR: cli: don't call the kw->io_release if kw->parse failed"), the io_release() callback is not called anymore when the parse() failed. Call it directly on the error path of the cli_parse_set_cert() function. --- src/ssl_sock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ssl_sock.c b/src/ssl_sock.c index 0ef30c771..c8bc5e24b 100644 --- a/src/ssl_sock.c +++ b/src/ssl_sock.c @@ -10291,6 +10291,7 @@ end: if (errcode & ERR_CODE) { /* we release the spinlock and free the unused structures in the release function */ + cli_release_set_cert(appctx); return cli_dynerr(appctx, memprintf(&err, "%sCan't update %s!\n", err ? err : "", args[3])); } else return 0;