mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 22:01:31 +02:00
Code Issues Projects Releases Wiki Activity

[MINOR] disable useless hint in wake_expired_tasks

Browse Source 
wake_expired_tasks() used a hint to avoid scanning the tree in most cases,
but it looks like the hint is more expensive than reaching the first node
in the tree. Disable it for now.
This commit is contained in:
Willy Tarreau 2007-05-14 02:11:39 +02:00
parent fbfc053e34
commit 1209033e46
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/task.c
View File

@ -88,9 +88,12 @@ void wake_expired_tasks(struct timeval *next)
struct task *task; struct task *task;
void *data; void *data;
#ifdef WAKE_HINT_CHECK_FIRST
/* /*
* Hint: tasks are *rarely* expired. So we can try to optimize * Hint: tasks are *rarely* expired. So we can try to optimize
* by not scanning the tree at all in most cases. * by not scanning the tree at all in most cases. However, this
* code costs 160 more bytes which do not look much useful because
* the performance win is not obvious.
*/ */
if (likely(timer_wq.data != NULL)) { if (likely(timer_wq.data != NULL)) {
@ -100,16 +103,15 @@ void wake_expired_tasks(struct timeval *next)
return; return;
} }
} }
/* OK we lose. Let's scan the tree then. */ /* OK we lose. Let's scan the tree then. */
tv_eternity(next); #endif
tree64_foreach(&timer_wq, data, stack, slen) { tree64_foreach(&timer_wq, data, stack, slen) {
task = LIST_ELEM(data, struct task *, qlist); task = LIST_ELEM(data, struct task *, qlist);
if (tv_isgt(&task->expire, &now)) { if (tv_isgt(&task->expire, &now)) {
*next = task->expire; *next = task->expire;
break; return;
} }
/* /*
@ -124,6 +126,7 @@ void wake_expired_tasks(struct timeval *next)
task->state = TASK_RUNNING; task->state = TASK_RUNNING;
} }
} }
tv_eternity(next);
return; return;
} }