mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 15:17:01 +02:00
Code Issues Projects Releases Wiki Activity

[OPTIM] do not re-check req buffer when only response has changed

Browse Source 
In process_session(), we used to re-run through all the evaluation
loop when only the response had changed. Now we carefully check in
this order :
  - changes to the stream interfaces (only SI_ST_DIS)
  - changes to the request buffer flags
  - changes to the response buffer flags

And we branch to the appropriate section. This saves significant
CPU cycles, which is important since process_session() is one of
the major CPU eaters.

The same changes have been applied to uxst_process_session().
This commit is contained in:
Willy Tarreau 2009-03-08 19:20:25 +01:00
parent 531cf0cf8d
commit 0be0ef9604
2 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/proto_uxst.c
View File

@ -770,6 +770,7 @@ struct task *uxst_process_session(struct task *t)
* at this point.
*/
resync_request:
/**** Process layer 7 below ****/
resync = 0;
@ -855,9 +856,14 @@ struct task *uxst_process_session(struct task *t)
s->req->flags &= BF_CLEAR_READ & BF_CLEAR_WRITE & BF_CLEAR_TIMEOUT;
/* according to benchmarks, it makes sense to resync now */
if (resync)
if (s->req->prod->state == SI_ST_DIS)
goto resync_stream_interface;
if (resync)
goto resync_request;
resync_response:
resync = 0;
/* Analyse response */
if (unlikely(s->rep->flags & BF_HIJACK)) {
@ -935,9 +941,15 @@ struct task *uxst_process_session(struct task *t)
s->rep->flags &= BF_CLEAR_READ & BF_CLEAR_WRITE & BF_CLEAR_TIMEOUT;
if (resync)
if (s->req->prod->state == SI_ST_DIS)
goto resync_stream_interface;
if (s->req->flags != rqf_last)
goto resync_request;
if (resync)
goto resync_response;
if (likely(s->rep->cons->state != SI_ST_CLO)) {
if (s->rep->cons->state == SI_ST_EST)
stream_sock_data_finish(s->rep->cons);

15
src/session.c
View File

@ -714,6 +714,7 @@ struct task *process_session(struct task *t)
* at this point.
*/
resync_request:
/**** Process layer 7 below ****/
resync = 0;
@ -855,9 +856,14 @@ struct task *process_session(struct task *t)
s->req->flags &= BF_CLEAR_READ & BF_CLEAR_WRITE & BF_CLEAR_TIMEOUT;
/* according to benchmarks, it makes sense to resync now */
if (resync)
if (s->req->prod->state == SI_ST_DIS || s->req->cons->state == SI_ST_DIS)
goto resync_stream_interface;
if (resync)
goto resync_request;
resync_response:
resync = 0;
/* Analyse response */
@ -948,9 +954,14 @@ struct task *process_session(struct task *t)
s->rep->flags &= BF_CLEAR_READ & BF_CLEAR_WRITE & BF_CLEAR_TIMEOUT;
if (resync)
if (s->req->prod->state == SI_ST_DIS || s->req->cons->state == SI_ST_DIS)
goto resync_stream_interface;
if (s->req->flags != rqf_last)
goto resync_request;
if (resync)
goto resync_response;
/* This is needed only when debugging is enabled, to indicate
* client-side or server-side close. Please note that in the unlikely