From 0b6e47354c45e76265a333f9256c21d363fff707 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 23 Apr 2026 11:24:22 +0200 Subject: [PATCH] BUG/MINOR: servers: fix last_sess date calculation In 3.4-dev8, commit e264523112 ("MINOR: servers: Don't update last_sess if it did not change") adjusted the last_sess date to avoid writing to the same cache line all the time, however a typo makes it pick the wrong second because it uses now_ms instead of now_ns (so the date would roughly change every 12 days). No backport needed. --- include/haproxy/server.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/haproxy/server.h b/include/haproxy/server.h index 6bdd823f2..5ffc06880 100644 --- a/include/haproxy/server.h +++ b/include/haproxy/server.h @@ -221,7 +221,7 @@ static inline void srv_inc_sess_ctr(struct server *s) static inline void srv_set_sess_last(struct server *s) { if (s->counters.shared.tg) { - uint now_sec = ns_to_sec(now_ms); + uint now_sec = ns_to_sec(now_ns); if (HA_ATOMIC_LOAD(&s->counters.shared.tg[tgid - 1]->last_sess) != now_sec) HA_ATOMIC_STORE(&s->counters.shared.tg[tgid - 1]->last_sess, now_sec);