From 0aeaa290daa492bf770a256ec7f5b9f367bc6378 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Thu, 4 Feb 2021 11:13:43 +0100 Subject: [PATCH] CLEANUP: muxes: Remove useless calls to b_realign_if_empty() In H1, H2 and FCGI muxes, b_realign_if_empty() is called to reset the head of an empty buffer before setting it a specific value to permit the zero-copy. Thus, we can remove call to b_realign_if_empty(). --- src/mux_fcgi.c | 1 - src/mux_h1.c | 1 - src/mux_h2.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mux_fcgi.c b/src/mux_fcgi.c index 3e1cff852..2cc517708 100644 --- a/src/mux_fcgi.c +++ b/src/mux_fcgi.c @@ -2788,7 +2788,6 @@ static int fcgi_recv(struct fcgi_conn *fconn) return 0; } - b_realign_if_empty(buf); if (!b_data(buf)) { /* try to pre-align the buffer like the * rxbufs will be to optimize memory copies. We'll make diff --git a/src/mux_h1.c b/src/mux_h1.c index 4262b541e..a3aa3889e 100644 --- a/src/mux_h1.c +++ b/src/mux_h1.c @@ -2547,7 +2547,6 @@ static int h1_recv(struct h1c *h1c) TRACE_STATE("h1c ibuf not full anymore", H1_EV_H1C_RECV|H1_EV_H1C_BLK); } - b_realign_if_empty(&h1c->ibuf); if (!b_data(&h1c->ibuf)) { /* try to pre-align the buffer like the rxbufs will be * to optimize memory copies. diff --git a/src/mux_h2.c b/src/mux_h2.c index 5f35d8928..4d7142247 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -3617,7 +3617,6 @@ static int h2_recv(struct h2c *h2c) return 0; } - b_realign_if_empty(buf); if (!b_data(buf)) { /* try to pre-align the buffer like the * rxbufs will be to optimize memory copies. We'll make