From 08cb945a9b67a8b45cf8d213496c5847957e2f2e Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Thu, 27 Jan 2022 15:33:40 +0100 Subject: [PATCH] CLEANUP: mworker: simplify mworker_free_child() Remove useless checks and simplify the function. --- src/mworker.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/src/mworker.c b/src/mworker.c index ac1177f4c..8b0b06ba0 100644 --- a/src/mworker.c +++ b/src/mworker.c @@ -603,26 +603,17 @@ out: void mworker_free_child(struct mworker_proc *child) { + int i; + if (child == NULL) return; - if (child->command) { - int i; + for (i = 0; child->command && child->command[i]; i++) + ha_free(&child->command[i]); - for (i = 0; child->command[i]; i++) { - if (child->command[i]) { - ha_free(&child->command[i]); - } - - } - ha_free(&child->command); - } - if (child->id) { - ha_free(&child->id); - } - if (child->version) { - ha_free(&child->version); - } + ha_free(&child->command); + ha_free(&child->id); + ha_free(&child->version); free(child); }