From 079f8087410bff34ebddeebc5c3a45185b8bca8e Mon Sep 17 00:00:00 2001 From: Kevin Zhu Date: Fri, 13 Mar 2020 10:39:51 +0800 Subject: [PATCH] BUG/MEDIUM: spoe: dup agent's engine_id string from trash.area The agent's engine_id forgot to dup from trash, all engine_ids point to the same address "&trash.area", the engine_id changed at run time and will double free when release agents and trash. This bug was introduced by the commit ee3bcddef ("MINOR: tools: add a generic function to generate UUIDs"). No backport is needed, this is 2.2-dev. --- src/flt_spoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flt_spoe.c b/src/flt_spoe.c index df080d816..57c224644 100644 --- a/src/flt_spoe.c +++ b/src/flt_spoe.c @@ -258,7 +258,7 @@ static char * generate_pseudo_uuid() { ha_generate_uuid(&trash); - return trash.area; + return my_strndup(trash.area, trash.data); }