mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-12-24 02:51:00 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: mux-h1: fix 414 / 431 status code reporting

Browse Source 
The more detailed status code reporting introduced with bc967758a2 is
checking against the error state to determine whether it is a too long
URL or too large headers. The check used always returns true which
results in a 414 as the error state is only set at a later point.

This commit adjusts the check to use the current state instead to return
the intended status code.

This patch must be backported as far as 3.1.
This commit is contained in:
Maximilian Moehl 2025-11-05 10:28:12 +01:00 committed by Christopher Faulet
parent 06821dc189
commit 0799fd1072
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/h1_htx.c
View File

@ -397,7 +397,7 @@ int h1_parse_msg_hdrs(struct h1m *h1m, union h1_sl *h1sl, struct htx *dsthtx,
goto error;
if (!ret && !ofs && !buf_room_for_htx_data(srcbuf)) {
if (!(h1m->flags & H1_MF_RESP))
h1m->err_code = (h1m->err_state < H1_MSG_HDR_FIRST) ? 414: 431;
h1m->err_code = (h1m->state < H1_MSG_HDR_FIRST) ? 414: 431;
goto error;
}
goto end;