From 07846cbda87f5f7c8e2324a333422fc9bbf048e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Mon, 13 Feb 2023 16:14:24 +0100 Subject: [PATCH] BUG/MINOR: quic: Wrong datagram dispatch because of qc_check_dcid() There was a parenthesis placed in the wrong place for a memcmp(). As a consequence, clients could not reuse a UDP address for a new connection. Must be backported to 2.7. --- src/quic_conn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/quic_conn.c b/src/quic_conn.c index bf0581cfc..a73f7c057 100644 --- a/src/quic_conn.c +++ b/src/quic_conn.c @@ -7542,7 +7542,7 @@ int qc_check_dcid(struct quic_conn *qc, unsigned char *dcid, size_t dcid_len) if ((qc->scid.len == dcid_len && memcmp(qc->scid.data, dcid, dcid_len) == 0) || (qc->odcid.len == dcid_len && - memcmp(qc->odcid.data, dcid, dcid_len)) == 0) { + memcmp(qc->odcid.data, dcid, dcid_len) == 0)) { return 1; }