mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 23:27:04 +02:00
Code Issues Projects Releases Wiki Activity

CLEANUP: acme: stored value is overwritten before it can be used

Browse Source 
>>>     CID 1609049:  Code maintainability issues  (UNUSED_VALUE)
   >>>     Assigning value "NULL" to "new_ckchs" here, but that stored value is overwritten before it can be used.
   592             struct ckch_store *old_ckchs, *new_ckchs = NULL;

Coverity reported an issue where a variable is initialized to NULL then
directry overwritten with another value. This doesn't arm but this patch
removes the useless initialization.

Must fix issue #2932.
This commit is contained in:
William Lallemand 2025-04-15 11:44:45 +02:00
parent 3866d3bd12
commit 05ebb448b5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/acme.c
View File

@ -591,7 +591,7 @@ int acme_jws_payload(struct buffer *req, struct ist nonce, struct ist url, EVP_P
int acme_update_certificate(struct task *task, struct acme_ctx *ctx, char **errmsg) int acme_update_certificate(struct task *task, struct acme_ctx *ctx, char **errmsg)
{ {
int ret = 1; int ret = 1;
struct ckch_store *old_ckchs, *new_ckchs = NULL; struct ckch_store *old_ckchs, *new_ckchs;
struct ckch_inst *ckchi; struct ckch_inst *ckchi;
new_ckchs = ctx->store; new_ckchs = ctx->store;