From 055ee6c14b18054a1a0b4823333bee1b3e6a9bab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Tue, 25 Jan 2022 21:21:56 +0100 Subject: [PATCH] MINOR: quic: Comment fix about the token found in Initial packets Mention that the token is sent only by servers in both server and listener packet parsers. Remove a "TO DO" section in listener packet parser because there is nothing more to do in this function about the token --- src/xprt_quic.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index d021f62d1..8a9b4f293 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -3942,7 +3942,8 @@ static ssize_t qc_srv_pkt_rcv(unsigned char **buf, const unsigned char *end, * So, a client which receives an Initial packet with a token * MUST discard the packet or generate a connection error with * PROTOCOL_VIOLATION as type. - * The token must be provided in a Retry packet or NEW_TOKEN frame. + * The token may be provided in a Retry packet or NEW_TOKEN frame + * only by the QUIC server. */ pkt->token_len = token_len; } @@ -4429,12 +4430,8 @@ static ssize_t qc_lstnr_pkt_rcv(unsigned char *buf, const unsigned char *end, goto err; } - /* XXX TO DO XXX 0 value means "the token is not present". - * A server which sends an Initial packet must not set the token. - * So, a client which receives an Initial packet with a token - * MUST discard the packet or generate a connection error with - * PROTOCOL_VIOLATION as type. - * The token must be provided in a Retry packet or NEW_TOKEN frame. + /* The token may be provided in a Retry packet or NEW_TOKEN frame + * only by the QUIC server. */ pkt->token_len = token_len;