From 0484f92656699c4baa32bddb66ede16d3007f876 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Tue, 15 Feb 2022 16:59:39 +0100 Subject: [PATCH] MINOR: h3: report frames bigger than rx buffer If a frame is bigger than the qcs buffer, it can not be parsed at the moment. Add a TODO comment to signal that a fix is required. --- src/h3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/h3.c b/src/h3.c index b6df43045..e3ee84694 100644 --- a/src/h3.c +++ b/src/h3.c @@ -126,9 +126,12 @@ static int h3_decode_qcs(struct qcs *qcs, int fin, void *ctx) h3_debug_printf(stderr, "%s: ftype: %llu, flen: %llu\n", __func__, (unsigned long long)ftype, (unsigned long long)flen); - if (flen > b_data(&b)) + if (flen > b_data(&b) && !b_full(rxbuf)) break; + /* TODO handle full rxbuf */ + BUG_ON(flen > b_size(rxbuf)); + b_del(rxbuf, hlen); last_stream_frame = (fin && flen == b_data(rxbuf));