mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-10 09:07:02 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: httpclient: Don't use co_set_data() to decrement output

Browse Source 
The use of co_set_data() should be strictly limited to setting the amount of
existing data to be transmitted. It ought not be used to decrement the
output after the data have left the buffer, because doing so involves
performing incorrect calculations using co_data() that still comprises data
that are not in the buffer anymore. Let's use c_rew() for this, which is
made exactly for this purpose, i.e. decrement c->output by as much as
requested.
This commit is contained in:
Christopher Faulet 2022-04-29 14:09:03 +02:00
parent 6b4f1f64a8
commit 0055d5693e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/http_client.c
View File

@ -765,7 +765,7 @@ static void httpclient_applet_io_handler(struct appctx *appctx)
hc->res.vsn = istdup(htx_sl_res_vsn(sl));
hc->res.reason = istdup(htx_sl_res_reason(sl));
sz = htx_get_blksz(blk);
co_set_data(res, co_data(res) - sz);
c_rew(res, sz);
htx_remove_blk(htx, blk);
/* caller callback */
if (hc->ops.res_stline)