From b2dbc0c524ff80b1911e8006c4bf6873ddcf3b6a Mon Sep 17 00:00:00 2001 From: Mike Danese Date: Wed, 1 Apr 2020 20:23:34 -0700 Subject: [PATCH] fix order-dependent test TestSdumpLargeDefinition is depnding on a global state change in TestSdumpReusedPointers. It can't pass if it runs in the wrong order. Fixes internal auto-filled bug. --- internal/dump/dump_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/dump/dump_test.go b/internal/dump/dump_test.go index 99b9881..7cd7785 100644 --- a/internal/dump/dump_test.go +++ b/internal/dump/dump_test.go @@ -447,8 +447,9 @@ var Obj = &struct { Foo *Zeo; Bar *Zeo }{ }, } for _, test := range testcases { - Config.StripPackageNames = true - output := Sdump(test.input()) + opts := Config + opts.StripPackageNames = true + output := opts.Sdump(test.input()) if test.expected != output { t.Errorf("test case %s failed, expected : \n%#v\n, got : \n%#v", test.name, test.expected, output) } @@ -465,7 +466,7 @@ func TestSdumpLargeDefinition(t *testing.T) { } got := Sdump(&largeStruct{1, 2, 3, 4, 5}) want := `var Obj = _Obj -var _Obj = &largeStruct{ +var _Obj = &dump.largeStruct{ ABCDEFGHIJKLMNOBQRSTUVWXYZ0: int(1), ABCDEFGHIJKLMNOBQRSTUVWXYZ1: int(2), ABCDEFGHIJKLMNOBQRSTUVWXYZ2: int(3),