mirrors/go-jsonnet
1
0
Fork 0
mirror of https://github.com/google/go-jsonnet.git synced 2025-08-07 14:57:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix an out-of-bounds array access when formatting some empty comment

Browse Source
This commit is contained in:
Mickael Carl 2025-03-06 23:31:09 +00:00
parent 5b5bcd566a
commit 6d83c91d49
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
formatter/testdata/empty_comment.fmt.golden vendored Normal file
View File

@ -0,0 +1,2 @@
//
{}

2
formatter/testdata/empty_comment.jsonnet vendored Normal file
View File

@ -0,0 +1,2 @@
#
{}

2
internal/formatter/enforce_comment_style.go
View File

@ -38,7 +38,7 @@ func (c *EnforceCommentStyle) FodderElement(p pass.ASTPass, element *ast.FodderE
*comment = "#" + (*comment)[2:] *comment = "#" + (*comment)[2:]
} }
if c.Options.CommentStyle == CommentStyleSlash && (*comment)[0] == '#' { if c.Options.CommentStyle == CommentStyleSlash && (*comment)[0] == '#' {
if !c.seenFirstFodder && (*comment)[1] == '!' { if !c.seenFirstFodder && len(*comment) > 1 && (*comment)[1] == '!' {
return return
} }
*comment = "//" + (*comment)[1:] *comment = "//" + (*comment)[1:]