mirrors/go-jsonnet
1
0
Fork 0
mirror of https://github.com/google/go-jsonnet.git synced 2025-09-30 09:51:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove a few stale TODOs

Browse Source
This commit is contained in:
Stanisław Barzowski 2017-09-29 12:06:26 -04:00 committed by Dave Cunningham
parent b1a9c0bd6d
commit 121a77c66f
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
desugarer.go
View File

@ -109,7 +109,6 @@ func desugarFields(location ast.LocationRange, fields *ast.ObjectFields, objLeve
} }
// Simplify asserts // Simplify asserts
// TODO(dcunnin): this
for i := range *fields { for i := range *fields {
field := &(*fields)[i] field := &(*fields)[i]
if field.Kind != ast.ObjectAssert { if field.Kind != ast.ObjectAssert {
@ -130,7 +129,6 @@ func desugarFields(location ast.LocationRange, fields *ast.ObjectFields, objLeve
} }
// Remove methods // Remove methods
// TODO(dcunnin): this
for i := range *fields { for i := range *fields {
field := &((*fields)[i]) field := &((*fields)[i])
if !field.MethodSugar { if !field.MethodSugar {
@ -403,7 +401,6 @@ func desugar(astPtr *ast.Node, objLevel int) (err error) {
if err != nil { if err != nil {
return return
} }
// TODO(dcunnin): Need to handle bopPercent, bopManifestUnequal, bopManifestEqual
case *ast.Conditional: case *ast.Conditional:
err = desugar(&node.Cond, objLevel) err = desugar(&node.Cond, objLevel)
@ -453,7 +450,7 @@ func desugar(astPtr *ast.Node, objLevel int) (err error) {
} }
if node.Id != nil { if node.Id != nil {
if node.Index != nil { if node.Index != nil {
panic("TODO") panic(fmt.Sprintf("Node with both Id and Index: %#+v", node))
} }
node.Index = makeStr(string(*node.Id)) node.Index = makeStr(string(*node.Id))
node.Id = nil node.Id = nil
@ -585,6 +582,5 @@ func desugarFile(ast *ast.Node) error {
if err != nil { if err != nil {
return err return err
} }
// TODO(dcunnin): wrap in std local
return nil return nil
} }

2
interpreter.go
View File

@ -243,8 +243,6 @@ func (i *interpreter) getCurrentEnv(ast ast.Node) environment {
} }
func (i *interpreter) evaluate(a ast.Node, context *TraceContext) (value, error) { func (i *interpreter) evaluate(a ast.Node, context *TraceContext) (value, error) {
// TODO(dcunnin): All the other cases...
e := &evaluator{ e := &evaluator{
trace: &TraceElement{ trace: &TraceElement{
loc: a.Loc(), loc: a.Loc(),