mirrors/go-delve_delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2026-05-10 14:46:18 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: replace Readdir(-1) with os.ReadDir (#3361)

Browse Source 
We can simplify the following code
	dir, err := os.Open(dirname)
	if err != nil {
		return err
	}
	defer dir.Close()

	dirs, err := dir.Readdir(-1)

with just `os.ReadDir(dirname)`.

Reference: https://pkg.go.dev/os#ReadDir

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun 2023-05-09 01:37:30 +08:00 committed by GitHub
parent 8c9ce617c9
commit 8711f6217d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/proc/core/core_test.go
View File

@ -504,12 +504,7 @@ func procdump(t *testing.T, exePath string) string {
t.Fatalf("possible error running procdump64, output: %q, error: %v", string(out), err)
}
dh, err := os.Open(exeDir)
if err != nil {
t.Fatalf("could not open executable file directory %q: %v", exeDir, err)
}
defer dh.Close()
fis, err := dh.Readdir(-1)
fis, err := os.ReadDir(exeDir)
if err != nil {
t.Fatalf("could not read executable file directory %q: %v", exeDir, err)
}

7
pkg/proc/gdbserial/rr.go
View File

@ -300,12 +300,7 @@ func RecordAndReplay(cmd []string, wd string, quiet bool, debugInfoDirs []string
// safeRemoveAll removes dir and its contents but only as long as dir does
// not contain directories.
func safeRemoveAll(dir string) {
dh, err := os.Open(dir)
if err != nil {
return
}
defer dh.Close()
fis, err := dh.Readdir(-1)
fis, err := os.ReadDir(dir)
if err != nil {
return
}

7
pkg/proc/test/support.go
View File

@ -279,12 +279,7 @@ func MustHaveRecordingAllowed(t testing.TB) {
// SafeRemoveAll removes dir and its contents but only as long as dir does
// not contain directories.
func SafeRemoveAll(dir string) {
dh, err := os.Open(dir)
if err != nil {
return
}
defer dh.Close()
fis, err := dh.Readdir(-1)
fis, err := os.ReadDir(dir)
if err != nil {
return
}