mirror of
https://github.com/flatcar/scripts.git
synced 2025-10-04 12:02:13 +02:00
Now that make_chroot.sh lives alongside enter_chroot, we're able to invoke it directly and use internal options not exposed through cros_sdk. Thus enter_chroot grows a --early_make_chroot flag. This flag bypasses the normal sudo usage, and runs the command as root. It is needed and used by make_chroot for when sudo may not yet exist (--bootstrap via stage3 lacks sudo). For where sudo exists and we need access to the source tree, distfiles, or profile sourcing, enter_chroot is directly used. For all other invocations we use a single sudo chroot call to bypass the overhead of enter_chroot. This is a complete fix to chromium-os:25697 while addressing all refactoring requests that came up in I8a6c5a26. Finally, convert all comments into complete sentences, upper case the leading word, etc to keep reviewers happy. BUG=chromium-os:25697 TEST=Within a trybot, cros_sdk --bootstrap --replace TEST=cros_sdk --replace TEST=cros_sdk --delete TEST=cros_sdk Change-Id: I270ee7fc325ef0bea74c61505d25cdbb49a9a333 Reviewed-on: https://gerrit.chromium.org/gerrit/15322 Commit-Ready: Brian Harring <ferringb@chromium.org> Reviewed-by: Brian Harring <ferringb@chromium.org> Tested-by: Brian Harring <ferringb@chromium.org>