The problem here is that most were doing their exiting w/in a subshell;
exit within a subshell kills the subshell, not the parent. Not all scripts
were using set -e (which would pick up the failing subshell); as such
just rewriting them to remove the potential via eliminateing the subshelling.
Beyond that, removed a couple of custom (working, although non-standard)
approaches, and removed a duplicate common.sh sourc'ing w/in mk_memento_images.sh
TEST=force 'find_common_sh' to fail, note the scripts fails to exit
BUG=none
Change-Id: Ia1108a091a6399ad6aedd3cade4a107f4411686c
Reviewed-on: http://gerrit.chromium.org/gerrit/3905
Reviewed-by: Brian Harring <ferringb@chromium.org>
Tested-by: Brian Harring <ferringb@chromium.org>
New toolchains should only be rolled out to developers running with
binary packages when the sdk-builder has completed and uploaded the
prebuilts. This ensures that we've vetted the toolchain properly
before it rolls out and also speeds up binary builds for developers.
This also provides consistency with the behavior of setup_board.
BUG=chromium-os:16363
TEST=Verify these 3 packages are only updated in --usepkg builds
when the prebuilts are also updated.
Change-Id: I6be7c6c98c12130751d3d4440bec7c71afb1d4c2
Reviewed-on: http://gerrit.chromium.org/gerrit/2391
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Tested-by: David James <davidjames@chromium.org>
BUG=quickfix for bot break
TEST=run ./update_chroot
Change-Id: I459d50f3e3374c1ff8ff8fc692c8ba7f3582bbd5
Reviewed-on: http://gerrit.chromium.org/gerrit/743
Tested-by: David James <davidjames@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
script
BUG=none
TEST=run build_packages, setup_board, make_chroot, with the paths fixed
to this script (http://gerrit.chromium.org/gerrit/700), see things work
Change-Id: I5a3950ddd5949fcf900a609f86092fce33db8cbd
Reviewed-on: http://gerrit.chromium.org/gerrit/720
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: Zdenek Behan <zbehan@chromium.org>
