Besides changing a lot of _ to not _, I added lots of docstrings, moved things around,
factored out the Marking component of the EBuildStableMarker (for use with other CL),
and fixed the version logic.
The versioning logic was too hacktastic. So I took a note from David's changes to
take the information from pkgsplit rather than doing the ugly parsing I was doing before.
This is much more robust in the case of no _r*'s and _rc or _alpha*, etc.
Used in http://codereview.chromium.org/4798001/
BUG=chromiumos:8693
TEST=Ran unit tests and chrome mark as stable. Will run some more tests.
Review URL: http://codereview.chromium.org/5172003
Change-Id: Id6ef9a480591d1a28352f360c6d076564b43e318
Change-Id: I1032932b696929fccf97f911c555ec5a24f589d4
BUG=9291
TEST=Run storageFio test since it need prebuild test and deps.
w/wo emerge autotest
w/wo cros_workon
in/outside of chroot.
and all its combinations.
Review URL: http://codereview.chromium.org/5188002
The update_bootloaders needs to unmount file system first for syslinux to
manipulate the raw device file, but the real "umount+losetup -d" in
cleanup stage would cause failure.
This CL remounts partition again so that cleanup can be executed
successfully.
BUG=chromium-os:9278
TEST=Manually executed ./build_image;
Before fix: seeing "umount: /tmp/esp.2q8fSn: not mounted" in last page.
After fix: no such error.
The output image is verified to be bootable successfully.
Change-Id: I19e2e062ad814e7bcd54777b5c3cee31f2b92e81
Review URL: http://codereview.chromium.org/5165001
Major changes are:
- prefix functions in cros_image_common with 'image' to avoid naming conflicts
- use awk to replace grep+sed+cut
- use case to handle board name list
- factory_setup.sh should return error if applying patch failed
- refine for shell script coding style guide:
* replace `` with $()
* quote variables
* replace "! -z" by "-n"
* no space between redirection symbol (>) and target name (eg, >>filename)
* 1> should be simply >
* no trailing \ for && and ||
BUG=chrome-os-partner:1583
TEST=manually verified:
./image_to_usb.sh --factory # calls mod_image_for_test --factory, and works fine
./make_factory_package.sh --factory PATH_TO_IMAGE --release PATH_TO_IMAGE ...
# factory payloads were created successfully
Change-Id: I6bb10bdfb12cbdb14e9816b3ad72dfe4b7b0472f
Review URL: http://codereview.chromium.org/5168001
BUG=n0ne
TEST=Ran the following command to test:
USE="-compat_wireless" ./build_image
Change-Id: I4b3fd12c1f62e1b2551045a5831a63d848fe2a3f
Review URL: http://codereview.chromium.org/5139003
Change-Id: Ie4632acf22bedb0c94de0cb3fe67b549fc2d0871
BUG=chromium-os:9323
TEST=Ran it and inserted exception for push_try < 3 and
mocked out push.
Review URL: http://codereview.chromium.org/5142003
This will prevent the firmware from updating the tries flag on a USB recovery image.
Change-Id: I47bf276eab5b40ae54b732d0e082e4c9f58bfed3
BUG=chromium-os:6550
TEST=build_package, build_image, cgpt show recovery_image.bin (successful flag should be set to 1)
Review URL: http://codereview.chromium.org/4979007
Change-Id: I906f1959769ac9d7a2abc04827cad8f5201984de
BUG=chromeos:9168
TEST=Made sure that setting and unsetting this value and enter_chroot is honoring the pass thru setting.
Review URL: http://codereview.chromium.org/5008006
Also add _Print statement so that stdout is printed.
BUG=chromium-os:9257
TEST=Run cros_mark_as_stable.py clean / commit
Change-Id: I9a01d6369d4b14ca0be812b8b1509c8375b1d575
Review URL: http://codereview.chromium.org/5063004
When the server returns a 5xx error code, we should retry. Such errors are
often due to flakiness, so retries resolve the issue.
BUG=chromium-os:9217
TEST=Tested parallel_emerge with fake URL to verify it retries.
Change-Id: Ie5cf003562b5261005be9929624769394b4802a1
Review URL: http://codereview.chromium.org/5056003
Modify repo sync to just sync the repo we are in,
this is what preflight does and is a proven acceptable approach over
the complete 'repo sync' approach.
BUG=8987
TEST=Ran retry command over dummy directories to be sure it retries
as expected.
Review URL: http://codereview.chromium.org/5082002
Modify repo sync to just sync the repo we are in, this is what preflight
does and is a proven acceptable approach over the complete 'repo sync' approach.
BUG=8987
TEST=Ran retry command over dummy directories to be sure it retries
as expected.
Preflight clean needs to wait until after the checkout happens before
it asserts that all of our overlays exist.
BUG=chromium-os:9197
TEST=Ran cbuildbot.py with missing chromiumos-overlay dir
Change-Id: If66574f01d1e85741e971919a9fa2da34f85872d
Review URL: http://codereview.chromium.org/5069001
This bug doesn't affect production but affects the unit tests.
BUG=chromium-os:9201
TEST=Confirmed this fixes an infinite loop in the unit tests, and that
cbuildbot.py still works.
Change-Id: I1a56b92d8229110c84cebbe877e55fb99f053212
Review URL: http://codereview.chromium.org/5025002
If there's no directory, I guess things are really, really clean.
BUG=chromium-os:9197
TEST=Ran cros_mark_as_stable.py clean with missing overlay directories.
Change-Id: I3f4811fe01bca56e850f823a973476884292e278
Review URL: http://codereview.chromium.org/4988004
Change-Id: I34e9d64656e04d4f5c477914512219d9b8563b78
BUG=chromium-os:9137
TEST=Ran with both wrong and right versions against a Google Chrome and
Chromium build
Review URL: http://codereview.chromium.org/4942001
Ass ${FLAGS_ssh_port} to ssh arguments for rsync
BUG=chromium-os:9187
TEST=Run rsync-related script with port argument
Change-Id: Iefabef230cfff03dcd66ac0c24798bb4b13ce40d
Review URL: http://codereview.chromium.org/4998004
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=795bd30
Review URL: http://codereview.chromium.org/4442001
Make removal of last ] more full-proof
Change-Id: I002e5ed513066a214fd6353f66e05bf5458f6ad4
BUG=7115
TEST= No file, with --subfolder
No file, without --subfolder
Empty file
File with one config already in it, with --subfolder
File with one config and garbage at the end, with --subfolder
File with one config and newlines at the end, with --subfolder
File with one config, without subfolder
Review URL: http://codereview.chromium.org/4688004
image read only to avoid unintended changes.
Change-Id: Id3a83786f2c1240a4401978c8cacffc0dcb9d66f
BUG=9073
TEST=Ran script with --patch_kernel, verified source image unmodified.
Ran ./image_to_live.sh to verify valid update was generated.
Review URL: http://codereview.chromium.org/4892002
These errors on extraction if you don't have the original targets
of the links on the image (i.e. if the stateful_partition gets wiped).
Change-Id: Id5d3f770830de6165613d506733c04edefccd3fb
BUG=chromium-os:9103
TEST=Ran update, wiped partition, ran stateful_update and ran bvt's.
Review URL: http://codereview.chromium.org/4882006
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
The team is moving utility/library scripts into 'lib' folder.
image_common.sh should follow this policy.
Also refined the parameter check of mk_memento_images.sh
BUG=chromium-os:5208
TEST=./make_factory_package.sh --factory PATH_TO_FACTORY --release PATH_TO_RELEASE;
# factory bundle created successfully
./mk_memento_images.sh PATH_TO_PART2 PATH_TO_PART3
# update.gz created successfully
./mk_memento_images.sh PATH_TO_IMGE 2 3
# update.gz created successfully
Change-Id: I3afecf05da2832986723f28b595045d0540ea9e9
Review URL: http://codereview.chromium.org/4825004
Change-Id: Ib9b6b9ba7787fba337e71e4968a5c152b5a21e14
BUG=chromiumos:8885
TEST=Ran with default options and setting --rootfs_mountpt and stateful_mountpt
to dirs in my current workig directory ... saw cleanup correctly on unmount
Review URL: http://codereview.chromium.org/4853001
This CL improves creation of memento / factory image payload by:
- verbose progress report
- allowing to compress by pigz, the parallel version of gzip
- prevents unpacking entire image if partition tools (cgpt/parted)
is available.
BUG=chromium-os:6536,chromium-os:5208
TEST=Verified executing "time ./make_factory_package.sh ..." for ToT factory bundle:
- before this CL (memento gzip param is not -9): 3m53.126s
- after this CL, without pigz, with cgpt: 2m34.897s
- after this CL, with pigz+cgpt, memento_gz=-9: 0m45.603s
- after this CL, with pigz, without cgpt/parted, memento_gz=-9: 1m49.748s
Also verified such bundle can be installed on a real netbook device.
Change-Id: Ie182844ea5482d6d321b9549fa584377edf7dfe3
Review URL: http://codereview.chromium.org/4824003
Change-Id: Ifc47ed28dc3efc0e7ebd018f6703b36913ffd39c
BUG=8716
TEST=Ran the script inside the chroot to makesure it is generating the package.
Review URL: http://codereview.chromium.org/4425004
