257 Commits

Author SHA1 Message Date
Mandeep Singh Baines
e46aa776a1 cros_workon_make: deprecate
BUG=11507
TEST=Ran and verified that an error is printed.

Change-Id: Icc494be4af8c5e3f462363280d5c17c12e16d24d

R=cmasone@chromium.org,anush@chromium.org

Review URL: http://codereview.chromium.org/6748008
2011-03-29 12:55:32 -07:00
Chris Sosa
fd2cdec118 Remove testing utilities and fix symlinks.
For run_remote_tests this required "fixing" restart_in_chroot if required.  Right now that script ->only<- works if its run on a scripts being called from src/scripts.  This change makes it more generic by doing this for any script called from within our source tree.

I borrow reinterpret_path_for_chroot from image_to_live.  Other CL to remove it from there.

Change-Id: If717beccd777ac178366d58b91521b9a62d55d85

BUG=chromium-os:11172
TEST=Ran them

Review URL: http://codereview.chromium.org/6730012
2011-03-24 16:06:59 -07:00
Chris Sosa
753977c09b Move some dev scripts into dev/host.
Change-Id: I8233aaab234eb6a3a7948abb1d311c4c9c162190

BUG=chromium-os:11172
TEST=Ran from new symlinks from previous locations.

Review URL: http://codereview.chromium.org/6731005
2011-03-23 14:34:53 -07:00
Chris Sosa
8d7caa720a Remove au_test_harness code and change symlinks to point to new location
Change-Id: I55a198e09ceac1e05b766864dbc920bfaedffb1f

BUG=chromium-os:11172
TEST=Tested ctest and cros_au_test_harness running from src/scripts
with buildbot params.

Review URL: http://codereview.chromium.org/6717011
2011-03-22 13:17:39 -07:00
Chris Sosa
798f78f0ee Fix case where we don't pass in a test base.
This should fix the failure seen in internal builds

Change-Id: I527acc37597ab9157aedf0330e43f3159ee66fdd

BUG=Should exist
TEST=Ran it locally
TBR=dgarret.  Internal builds have been failing on these for a while and no one yelled about it :(

Review URL: http://codereview.chromium.org/6676059
2011-03-16 19:54:03 -07:00
Chris Sosa
31b641ec3c Remove test keys from images we test with in the test harness.
Cleaned up _InsertKeyIntoImage to be more general (able to remove key if no key set).  Also made it much more intelligent ... only doing things when it needs to.

Moved mount / unmount code to cros_lib.

BUG=chromium-os:12684
TEST=Ran it a lot ... inspected images after and saw tests pass.

Review URL: http://codereview.chromium.org/6698017

Change-Id: Icd96d1178eeabf45a2d5916fbcab8bf7ffba7e21
2011-03-16 16:07:32 -07:00
Chris Sosa
574be57684 Avoid race condition on creating directory by pre-creating early.
Change-Id: I9fed7319609848ba90abfaa147fad85bd4114fdc

BUG=TreeCloser
TEST=Ran it locally in a VM a cpl times.

Review URL: http://codereview.chromium.org/6696002
2011-03-14 15:52:13 -07:00
Chris Sosa
9d30ce80fa Ignore git config errors that may occur in enter_chroot.
git config doesn't behave well if there are multiple callers
calling it at the same time.  Since this is best effort anyway,
I'm adding an || true so that multithreads calls to this don't
fail.

I removed my previous work around to this since it wasn't generic enough.

Change-Id: I12f2d3faaa745c1ff675a297bb09c567a88aa185

BUG=chromium-os:13070
TEST=Ran it a lot

Review URL: http://codereview.chromium.org/6693001
2011-03-14 15:00:46 -07:00
Chris Sosa
bc4c1574d0 Add logs for update_engine, devserver, and cros_run_vm_update to test artifacts.
Change-Id: Ib5617612be38bb6d7dafcb2edab887c998a676ab

BUG=chromium-os:12951
TEST=Ran it with Simple.  Saw logs generated (1_update) and in root/dev_server.log.  Ran unittests for cros_build_lib.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f53a8c7

Review URL: http://codereview.chromium.org/6672007
2011-03-14 13:21:16 -07:00
Chris Sosa
0cc50a4077 Revert "Add logs for update_engine, devserver, and cros_run_vm_update to test artifacts."
This reverts commit f53a8c769b2160fdf60a0d98a1f5f931d31e3366.

TBR=dgarret: revert CL to open tree

Change-Id: I03f80c715e9724f0759edcbeb9535948c9316200
2011-03-11 16:17:50 -08:00
Chris Sosa
f53a8c769b Add logs for update_engine, devserver, and cros_run_vm_update to test artifacts.
Change-Id: Ib5617612be38bb6d7dafcb2edab887c998a676ab

BUG=chromium-os:12951
TEST=Ran it with Simple.  Saw logs generated (1_update) and in root/dev_server.log.  Ran unittests for cros_build_lib.

Review URL: http://codereview.chromium.org/6672007
2011-03-11 15:42:31 -08:00
Chris Masone
6530f1bec8 [crosutils] Remove --use_emerged from cros_run_parallel_vm_tests
cros_run_parallel_vm_tests doesn't work unless you pass --use_emerged; there must be some underlying issue with trying to perform multiple run_remote_tests commands at the same time, even on different VMs.  So, remove the option and force --use_emerged on the calls to cros_run_vm_test.

BUG=8544
TEST=run two tests in parallel with cros_run_parallel_vm_tests and see that they both complete.

Change-Id: I1152ca3dd7f1de37261da894b9b903c90c2e6524

Review URL: http://codereview.chromium.org/6612058
2011-03-09 17:09:06 -08:00
Chris Sosa
cc0c062a3d Remove accidental test/debug regression I added in refactoring.
Not sure how I missed this.

Change-Id: Icd67b6119cbe5ef59bcf2c42784ac8fd011f2ab9

BUG=chromium-os:12953
TEST=Ran it

Review URL: http://codereview.chromium.org/6659009
2011-03-09 14:58:17 -08:00
David James
7a05e06dc9 Fix breakage in ctest.py.
Spotted the following error on the bots:

Traceback (most recent call last):
  File "bin/ctest", line 318, in <module>
    main()
  File "bin/ctest", line 314, in main
    options.remote, not options.cache)
TypeError: RunAUTestHarness() takes exactly 9 arguments (8 given)

http://chromeos-botmaster.mtv.corp.google.com:8026/builders/x86%20AGZ%20Full/builds/545/steps/cbuild/logs/stdio ( http://bit.ly/fdwOq1 )

This change fixes the error introduced in b54301bb9a284302d0f82c12a8753c3302a86d88.

TEST=Verify that new argument is passed through.
BUG=chromium-os:12211

Change-Id: Ibe8ee2f1fd0001525a5699a9dc107730f9c181de

Review URL: http://codereview.chromium.org/6625035
2011-03-04 19:14:09 -08:00
Chris Sosa
b54301bb9a Add ability to pass a base test root and create results dirs relative.
Sets up dir paths as follows:

test_root/test_name i.e. SimpleUpdate/<num>_stage

For example:

test_root/testNormalUpdateKeepStateful/2_verify/...test_results...
corresponds to the second invocation of verify image.  The test
results for this stage are stored here.

This is a predecessor for storing arbitrary logs e.g. update into
this test results root.

Change-Id: I7183420b5dcb0d6971aa508a338c048c3557e359

BUG=chromium-os:12211
TEST=With simple a full vm test suite w/ w/out explicit test root
set.

Review URL: http://codereview.chromium.org/6614029
2011-03-04 15:06:01 -08:00
Chris Sosa
5566eb1f7b Refactor au_test_harness into modules and refactor to use worker design flow.
This CL is a large refactoring that moves the test_harness from using sub-classed classes of au_test into a one where we have the same AU_Test for all test flows but different test workers that operate on different types of machines.  Specifically we move the VM / Real-image specific logic into real_au_worker and vm_au_worker.  There isn't anything functionally different in this change.

Also, we move the classes into their own modules and clean up use of cros_build_lib to be more stylistically correct.

Change-Id: I3e25141174c3d5ba22962bf94365815e69e5bedf

BUG=chromium-os:11172
TEST=Ran with simple and full w/ w/out delta update payloads and with unittest and without unittest keys.  Ran real test using full suite on test device using full update payloads.

Review URL: http://codereview.chromium.org/6597122
2011-03-02 19:24:52 -08:00
Chris Masone
2eae7c239d [crosutils] Add --quiet to cros_run_parallel_vm_tests
When running tests that generate huge amounts of output (like
desktopui_BrowserTest) it would be nice to suppress stdout and stderr
so that the buildbot logs aren't enormous.  Adding a --quiet flag that
requires the --results_dir_root flag ensures that we can trim the
output while still ensuring that the useful data is captured.

BUG=8544
TEST=run two tests in parallel with --quiet and --results_dir_root and see that the output is where you expect it

Change-Id: I25c7ad2bc1d017a30df0d1ad4604207443e711d7

Review URL: http://codereview.chromium.org/6602098
2011-03-02 16:37:23 -08:00
Zdenek Behan
99f7a5397d scripts: call devserver/payload generators from chroot & delete moved scripts
BUG=chromium-os:5246

TEST=below, During all tests, the directory platform/dev was manually removed
1) Ran cros_au_test_harness.py and saw it succeed
2) Ran generate_au_zip.py, compared the generated .zip with one before this
patch - they were identical
3) Ran cros_image_to_target.py and saw it succeed

Change-Id: Iab2620245a45442b79ee8369f3af1a3990f4644e

Review URL: http://codereview.chromium.org/6576023
2011-03-01 22:57:33 +01:00
Zdenek Behan
a400b3f5fa cros_image_to_target: use newstyle updates, followup after switching --nooldstyle to be the default
BUG=n0ne
TEST=run the script and see the update go

Change-Id: Ie767edf85876b7864f6425efed1ac554026ecdff

Review URL: http://codereview.chromium.org/6596062
2011-03-01 01:42:55 +01:00
Che-Liang Chiou
75ac2beb67 Add transitional flag for enabling arm kernel signing
For now arm kernel partitions are not signed. This CL is a transitionsl.
That is, the added flag should be removed after arm verified boot is stable.

To properly create an arm kernel partition, we also need another CL for
vbutil_kernel utility that turns off x86-only modifications on kernel
image. See CL:6538015.

BUG=chromium-os:3790,chromium-os:12352
TEST=see below

Build images for x86 and arm successfully, and notice that load_kernel_test
passes for x86 and signed arm image.

$ build_image --board=tegra2_seaboard --crosbug12352_arm_kernel_signing
$ build_image --board=tegra2_seaboard --nocrosbug12352_arm_kernel_signing
$ build_image --board=x86-generic

Review URL: http://codereview.chromium.org/6538014

Change-Id: I1be381bae2fc367a0603ac2ec67ee70fc9a257e4
2011-02-24 12:00:16 +08:00
Chris Sosa
4de24322bd Revert "Add build flag for iterative vm testing."
This reverts commit 519a6560e4dcd393d9ec3a959c4b2c894338fd1d.

BUG=For AU harness failures.
TEST=TBR

Review URL: http://codereview.chromium.org/6579014

Change-Id: I6001bf4c52951e4d9698985285538b162ae6b6f6
2011-02-23 14:22:39 -08:00
Will Drewry
b910de849c kernel build: use %U+1 for dm-verity booting
Using %U+1 will ensure that we avoid device enumeration issues during recovery mode
boots.

TEST=build_image+dev recovery kernel and boot to it on new cros fw / fixed enumeration problem
         used build with mp recovery kernel on cr-48 -> installed then booted fine
         used dev recovery kernel on a legacy machine; installed fine, booted fine
         tested with cr-48, mp recovery kernel, and noenable_rootfs_verification to ensure /dev/sd%D%P still worked as normal.

Change-Id: I5b1277a47536738a78c18988fd912cc05ebddd4b

BUG=chromium-os:5470

Review URL: http://codereview.chromium.org/6549034
2011-02-23 13:26:50 -06:00
Chris Sosa
519a6560e4 Add build flag for iterative vm testing.
Change-Id: Ib8258b33f87aeadfbaee145bdf7ab460af66c39f

BUG=N0ne
TEST=Ran it with --build

Review URL: http://codereview.chromium.org/6368129
2011-02-22 17:56:14 -08:00
Zdenek Behan
c264a45ba8 au_test_harness: fix a function call, add sudo in front of ifconfig
Note: sudo before ifconfig is for running on distros which do not
have /sbin or /usr/sbin in common user's paths, like gentoo.

Change-Id: I85bd379ad059d6ecaa8c11f3167fae27987479dd

BUG=5246
TEST=run cros_au_test_harness and see it not fail

Review URL: http://codereview.chromium.org/6541008
2011-02-18 06:06:55 +01:00
Don Garrett
c5ae0344d2 ReinterpretPathForChroot for public key
Change-Id: Ifcd52aad929453e801d143f5e16c26566aac4405

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/6532015
2011-02-16 21:27:32 -08:00
Don Garrett
2d08a983b2 I'm still breaking the build. Reverting again until I figure out why.
TBR

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6507034

Change-Id: I21283ed2b1f81086ccc95b0436e66c53584f4583
2011-02-16 18:39:35 -08:00
Don Garrett
e47eee3bc8 The original --quiet change failed (and was reverted) because cros_au_test_harness.py wasn't updated when the argument was changed from --quiet to --hide_info.
So... revert the reversion, and fix cros_au_test_harness.

BUG=chromium-os:11680
TEST=Manual

Review URL: http://codereview.chromium.org/6537005

Change-Id: I1bdf66a5735d4178ee1e2eaa838e7b4b7fb966d5
2011-02-16 15:49:14 -08:00
Don Garrett
8dcd981bbf Revert "Add --quiet to run_remote_tests, and use it"
This reverts commit 5b7e1d5da47cc748b31e42fb3ae7b43868b4342a.

Reverting to fix the build. TBR

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6480108

Change-Id: Idc9e60f97dd545225538420402c71b611233ce1e
2011-02-15 21:01:40 -08:00
Don Garrett
5b7e1d5da4 Add --quiet to run_remote_tests, and use it
Change-Id: I91f490ba4c4a834ba01b671c56c63ba230561ada

BUG=chromium-os:11680
TEST=Manual

Review URL: http://codereview.chromium.org/6529010
2011-02-15 17:40:56 -08:00
Chris Sosa
69cdce233e Fix tree closer. Deal with none case for PFQ.
Change-Id: Ia7883c196c688236051a4637561c9a01be5358cb

BUG=TreeCloser
TEST=Ran with simple prefix for x86-generic and no keys

Review URL: http://codereview.chromium.org/6480085
2011-02-15 12:51:06 -08:00
Chris Sosa
8dad50d97f Update test harness to take in optional public and private keys to sign payloads.
In addition some refactoring to make this cleaner and easier.

Change-Id: I1607700d065c71aff2b2833b10acbd3ebace68ce

BUG=chromium-os:8212
TEST=Ran with Simple ... running now with full

Review URL: http://codereview.chromium.org/6482017
2011-02-14 15:29:32 -08:00
Don Garrett
6620630c34 Switch ctest to array/appends for cros_au_test_harness call.
I was getting the error about passing along an empty string argument, and this will fix that.

Change-Id: Iffd05fe570f3a6092bbeee05abf8a1884decd644

BUG=N0ne
TEST=remote testing in progress (no VM testing)

Review URL: http://codereview.chromium.org/6465014
2011-02-09 13:51:43 -08:00
Chris Sosa
99768e8e12 Robustify starting of ssh connection to vm updater.
Change-Id: Ia5e0042250da22cebadfd48d143f21597bcada5d

BUG=chromium-os:11716
TEST=Ran vm test and vm update scripts.

Review URL: http://codereview.chromium.org/6413019
2011-02-07 09:02:22 -08:00
Mandeep Singh Baines
93da99be03 cros_workon: fix comments/messages to be consistent with new location
cros_workon has move to /usr/bin/

BUG=11507
TEST=none

Change-Id: I7301f659900713c432104ccceb3e658218e0ecac

Review URL: http://codereview.chromium.org/6334137
2011-02-05 11:42:19 -08:00
Anton Staaf
fd135cd9d0 Move cros_overlay_list to src/platform/dev.
This is step 3/3, after cros_overlay_list is added to dev, and
after the ebuilds are updated to install from dev and not
crosutils, then this can go in.

Change-Id: I8ae26938fb14ccf6737acd9ca99b58aaf65a1aca

BUG=chromium-os:11507
TEST=None

Review URL: http://codereview.chromium.org/6392034
2011-02-02 15:49:23 -08:00
Chris Sosa
79088f496e Remove buildbot code that has been added to chromite.
Change-Id: I7eb27ac81704de8689a65203a440303a52a01dc2

BUG=chromium-os:11171
TEST=we'll see if things explode

Review URL: http://codereview.chromium.org/6286040
2011-02-02 15:39:58 -08:00
Greg Spencer
798d75f3be This starts to fix the scripts so that they load from /usr/lib/crosutils
from within the chroot.

It also fixes a number of style issues.

It changes the meaning of cros_workon "list-all" to list all available
packages, and adds "list-live" to list all live packages.

It changes things that load chromeos-common.sh from the installer to
load it from /usr/lib/installer.

BUG=chromium-os:4230
TEST=synced, rebuilt chroot, made packages, made images, built chrome
from source, and wrote an image to a USB stick.

Review URL: http://codereview.chromium.org/6240018

Change-Id: I90c34420af1a64020402bafef8e9e77f56837c02
2011-02-01 22:04:49 -08:00
Chris Sosa
558940dddb Make git config optional to allow multiple calls to enter_chroot at the same time.
It's very rarely needed anyway but enter_chroot does everything under the sun.

Avoids:

error: could not lock config file ~/.gitconfig

Change-Id: Ide72b14fd434b182a88d2fc636559b3515905509

BUG=chromium-os:11523
TEST=Ran it ... 10x

Review URL: http://codereview.chromium.org/6312069
2011-02-01 13:07:55 -08:00
Chris Sosa
19ef17732c Do not pregenerate update payloads in parallel.
TBR dgarret

Change-Id: I71ef4b02108f43717e4bc404290952df99112654

BUG=n0ne
TEST=NA

Review URL: http://codereview.chromium.org/6349021
2011-02-01 09:57:29 -08:00
Chris Sosa
39ed0d0ebe Clear cache for runs of ctest if --cache not set.
Change-Id: I013c838c83dd23cbfe04f77f87df74778d8e874e

BUG=chromium-os:10723
TEST=Ran it

Review URL: http://codereview.chromium.org/6389004
2011-01-31 12:12:41 -08:00
Chris Sosa
b8a84b2cb7 Change uprev to False for Chrome pfq.
Change-Id: I8c635cf228c9bf1c77d97656d6b38de5289ff9e6

BUG=
TEST=

Review URL: http://codereview.chromium.org/6347027
2011-01-28 22:48:46 -08:00
Chris Sosa
25272888e8 add cwd
TBR dgarret

Change-Id: I8d7f86d716f1da76f4c85259f401c3ccc9a031ff

BUG=
TEST=

Review URL: http://codereview.chromium.org/6392010
2011-01-28 20:53:08 -08:00
Chris Sosa
d7beed79b6 Rebuild chroot for full builders.
TBR dgarrett

Change-Id: Ibed5341626d498adeeb259cac54ebb05ca1b4421

BUG=
TEST=

Review URL: http://codereview.chromium.org/6407001
2011-01-28 18:43:46 -08:00
Chris Sosa
b62c4860f8 Fix issue where full builders end prematurely.
TBR dgarrett

Change-Id: I08b7c19b8010003857f9791ca45ec9cadb972d47

BUG=N0ne
TEST=Ran

Review URL: http://codereview.chromium.org/6352027
2011-01-28 18:30:02 -08:00
Don Garrett
7b8075ac6d Added arm-tegra2-seaboard-full, should have added in previous change.
Change-Id: Iecb40121b4bc8ee652fe72c4a8c07e3d231293bf

BUG=chromium-os:11229
TEST=Passed unittests (shows correct syntax)

Review URL: http://codereview.chromium.org/6379015
2011-01-28 14:52:17 -08:00
Chris Sosa
436209ec5b Have the ability for the PFQ to both rev Chrome and other packages.
This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything.  This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly.  To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists).

EOM

Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3

BUG=chromium-os:11329
TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome,
and revved packages without error.  Doing more testing still.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8ac0ec

Review URL: http://codereview.chromium.org/6291013
2011-01-28 14:27:38 -08:00
Don Garrett
e7b9a4f558 Add new configs to cbuildbot_conf to match master.cfg
Change-Id: I4a28ac0f8e1a90313a9373e213e8a30003d1f8ad

BUG=chromium-os:11229
TEST=Unittests

Review URL: http://codereview.chromium.org/6268020
2011-01-28 14:14:26 -08:00
Vincent Palatin
3eb3543e9a Revert "Have the ability for the PFQ to both rev Chrome and ..."
This reverts the commit a8ac0ec8c3fd481c48e3846a8dfcae8105bab14a.

TBR the x86 PFQ buildbot fails

BUG=chromium-os:11447
TEST=
TBR=sosa

Change-Id: I019de669db13b753365e1208acc9923c4bb5c993

Review URL: http://codereview.chromium.org/6339018
2011-01-28 15:55:47 -05:00
Chris Sosa
a8ac0ec8c3 Have the ability for the PFQ to both rev Chrome and other packages.
This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything.  This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly.  To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists).

EOM

Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3

BUG=chromium-os:11329
TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome,
and revved packages without error.  Doing more testing still.

Review URL: http://codereview.chromium.org/6291013
2011-01-28 11:17:57 -08:00
Don Garrett
38a66574b6 Add more cbuild options, revise configs
BUG=chromium-os:11229
TEST=Local, unittests

Review URL: http://codereview.chromium.org/6245013

Change-Id: I103d693a2e6ce033c1f495f9f48450156ad72e94
2011-01-27 14:04:15 -08:00