Currently cros/master is used for the tracking branch in the preflight
rinse step. This is wrong if --tracking_branch is specified
differently in the command-line options to cbuildbot.py.
BUG=none
TEST=Ran unit tests
Change-Id: Id4fb989863ae11f57889faf6a8d8b043b81da58e
Review URL: http://codereview.chromium.org/4104005
Change-Id: Ic6d4a79a7ab58b8043805a6b826f251faa9f3a6c
BUG=
TEST=Running now (adding unit tests as well)
Review URL: http://codereview.chromium.org/4062003
Add small if statement in cros_run_wifi_tests to balk if we didn't get
valid cell info from the server.
BUG=none
TEST=reboot everything and rerun while testbed server hasn't caught up yet
Review URL: http://codereview.chromium.org/4069001
Change-Id: If7db175f828fccdd4caa342a0370e842503f16dc
BUG=8015
TEST=Ran it with cbuildbot with/without --clobber with/without old state.
Review URL: http://codereview.chromium.org/4007005
What's new?
- cros_mark_all_as_stable is now in Python and has unit tests.
- We now detect and report coding errors that can cause incorrect behavior.
E.g., if 9999 ebuild or stable ebuild can't be found, we report a hard
failure so that developers will know about the problem.
- We now check that git hashes we report actually match up with the
right repository.
- Unified diff of changes are now printed to stdout, so that developers
can see a list of the changes and debug any problems.
- cros_mark_all_as_stable now takes 2.5 seconds to run.
BUG=chromium-os:7795
TEST=Manually examined diff output from run of cros_mark_all_as_stable
on full repository.
Change-Id: I762597c9b94e5f8e8171b83c966ad54e21a65c1b
Review URL: http://codereview.chromium.org/3798003
This change makes more of the root filesyste metadata static across builds, but
more can be done there. It also changes the root filesystem to use ext2 as
we don't need journaling in normal mode. Optionally we could use ext3 for
non-verified if desired (it's an easy change).
In particular, this change cleans up the following:
- clears the rootfs uuid
- labels it C-ROOT (instead of C-KEYFOB)
- removes reserved inodes and blocks
The major feature of this change, however, is that it adds two simple
helpers to common.sh: disable_rw_mount and enable_rw_mount. They will
set high order byte (le) in the ro compat field to be 0xff. This will
tell the kernel that the filesystem uses features R24-R31 which are safe
for use on the running kernel iff the filesystem is mounted read-only.
These functions are called in cros_make_image_bootable and
mount_gpt_image, respectively. mount_gpt_image will always
enable_rw_mount and cros_make_image_bootable will disable_rw_mount if
--enable_rootfs_verification is true.
The approach is ugly but reasonably well contained. If ext2 ever gets a
new revision and new features in the same range are introduced, then we
would be getting inconsistent behavior. That said, it is unlikely that
that churmn will happen and if the impact is negative, it will ideally
show up during testing.
N.B., this will likely result in changes needing to be made to the
signing scripts in vboot_reference to ensure that rw mounting is
enabled/disabled in the same way (E.g., during stamping).
BUG=chromium-os:7468
TEST=- built x86-generic, imaged to usb stick, attempted to mount rw /dev/sdc3 on the host and was properly bounced.
- booted to the image just fine on a dogfood device.
- mod'd for recovery, then installed and booted.
- mod_image_for_test runs with no errors; booted the resulting image as well
- booted a factory_install with the pending dm changes
- BVT passed with build_image x86-generic (vboot enabled)
- [in progress] autotest that checks if the rootdev = /dev/dm-0 and
then does a dumpe2fs | grep -q FEATURE_R31
Review URL: http://codereview.chromium.org/3916002
Change-Id: If4dcba7568a110f4e32627c916d9e5741e5e5414
Change-Id: Idda6c7287cdb1863eb4abe8c56da2e763e9fe777
BUG=7926
TEST=Ran with --debug and verified I didn't push a change.
Review URL: http://codereview.chromium.org/3880002
Change-Id: I42741280656e9ee300dbc264ef7bf3345efa5223
BUG=
TEST=Ran it with test builder on own machine.
Review URL: http://codereview.chromium.org/3826015
src.chromium.org is no longer supported for git operations.
BUG=chromium-os:7830
TEST=none
Change-Id: Ia7cd9ff76625441f16d20d2f9a8e0f752dca0586
Review URL: http://codereview.chromium.org/3782010
This reverts commit 365d4b0cc8b21204e6e093bf910d53d3673f113c.
Fix preflight breakage, this seems like the most possible cause. Will recommit if not.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3767012
Change-Id: I93fe463fec77c445e7ff0ec86db25d5ef2997ad7
We always want to re-build packages we are revving, however, if the last
build succeeds in building but fails tests, we have a bad local cache that
has revved packages. This avoids this issue by working on all packages we
are revving.
Change-Id: I3bd7463a4090b1f007d09be81bdf65657bd9c3f3
BUG=7589
TEST=Ran it with cbuildbot.
Review URL: http://codereview.chromium.org/3745006
This changes the behavior of ctest to try to grab the latest zip from the zip web pages if it can't use the latest link (due to IOError or none provided). It assumes they have an Apache server and they reference images using version->ChromeOS-version-.*.zip) for each board/channel.
Change-Id: I4ee075db7afd58c8d08f59aca2e69b5bab5ff5e9
BUG=7675
TEST=Ran it with -l "http://Doesnotexist" and also without a -l option. Added new unittests to test and ran them as well.
Review URL: http://codereview.chromium.org/3659002
The "emerge" process sometimes copies files to /var/tmp
and then run it. Recent changes to images set the
"noexec" flag on /var, thus preventing such activities.
Temporarily clear this flag from within cros_package_to_live.
BUG=none
TEST=Manually set noexec on /var and run cros_package_to_live
Review URL: http://codereview.chromium.org/3739001
In order to more easily test kernel commandline tweaks, ensure that
--boot_args is propagated to all kernel cmdline sinks.
This is useful for changing default schedulers and any other kernel argument
tweaks we may want to quickly test out.
TEST=build and tested x86-generic
BUG=none
Change-Id: I5138755aa8c5e32e7f117f18291d2ae197e95bef
Review URL: http://codereview.chromium.org/3644004
1) image_to_vm aborts because e2fschk requires a terminal to
be connected in order to check whether or not you want to repair the fs. Since
we always want this to be true, set -p
2) Clean up test harness to only verify the number of tests that passed on the
base image are the same on the update back to. This is because older images
have many tests that fail. I leave 10% as a reasonable number to pass.
3) Redirect output from autotest in run_remote_tests to stderr so it gets
logged in a calling script that captures stdout.
Change-Id: If412274353683add20d136747113eb9c2bd41330
BUG=4690, 5533, 7287
TEST=Ran with internal tools for builders.
Review URL: http://codereview.chromium.org/3536018
Change-Id: I4de388bb1af6cd4568cdc154971927941eb73800
BUG=7503
TEST=Ran test by closing vm's as they start up to see retry work.
Review URL: http://codereview.chromium.org/3598019
Change-Id: I913acd95c49b1cf0fd666b49fb5ec1e24f0f83d1
BUG=7285
TEST=Ran through test against with two test images.
Review URL: http://codereview.chromium.org/3619009
Change-Id: I01d613527777098616e8d5bd2b4b27bce240c02f
BUG=
TEST=Ran cbuildbot and prematurely killed autotest to show test failure. CBuildbot fails saying that cros_run_vm_test smoke_Suite failed.
Review URL: http://codereview.chromium.org/3517010
This will allow dev who didn't build an image to still use cros_make_image_bootable
to update their image -- including mod_image_for_test / image_to_vm.
Change-Id: I1ba4292223b28b21d5416745e7744641100fa4ad
BUG=7370
TEST=Ran image_to_vm with other image and image I built myself. Also ran
cros_make_image_bootable directly on a the same two images.
Review URL: http://codereview.chromium.org/3569015
Change-Id: I4afa86fa7a6b772124de56114910a1ca5e3d4511
BUG=
TEST=Ran through update harness code and ran loman.
Review URL: http://codereview.chromium.org/3612004
This script had a short painful life, constantly being brittle
and broken. It is time for it to go. Please use
cros_image_to_target.py instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3536002
This harness has support for test on vm machines. It takes a base image and target image path, creates an update-enabled vm image from the base image and performs updates using cros_run_vm_update (vm wrapper around image_to_live). It uses --snapshot for updating vm's and keeps them on (like a real machine would) so that the VM image is clean on the next test.
The current check in has two test cases -- updates without clobbering the stateful partition and updates with clobbering the stateful partition.
Change-Id: I5406eadb39fa36601d17f8dd15625bd6a8b38c15
BUG=6911
TEST=Ran through tests.
Review URL: http://codereview.chromium.org/3554002
Right now we're leaving error_ok=True until the tests are shown to work on builder.
Change-Id: I6b8c690a0da30948389fd4312032c78d87115364
BUG=6906
TEST=Ran through it locally.
Review URL: http://codereview.chromium.org/3591002
- I looked at all of the x86 and ARM paths through out build image scripts,
these changes clean up stale comments, stale code, and unforks some small
things.
BUG=none
TEST=Built images for x86-generic, arm-generic and tegra2-seaboard, booted tegra2-seaboard image.
Review URL: http://codereview.chromium.org/3448022
Change-Id: Ibad2774ff2cbf5f15528454506542b87e43e24a2
Also fixed get latest image logic in image_to_vm and allowed for using the most recent image in cros_run_vm_test to follow other shell convention of using latest.
Change-Id: I60ed4c03d609500da7f6ae34ef57ba2e32f4b0bb
BUG=
TEST=Tested by running image_to_vm with --full and cros_run_vm_test with suite_Smoke
Review URL: http://codereview.chromium.org/3597001
If cbuildbot.py printed out a manifest when it syncs, it would make it possible
for us to reproduce the build later by looking at what revisions the buildbot
was using. This is useful for debugging.
Change-Id: I186ad01eef0090b6c618cb7ad583085197474018
BUG=chromium-os:7069
TEST=Ran test suite with 3441027 patched in (Sosa's patch that fixes an unrelated issue with the unit tests)
Review URL: http://codereview.chromium.org/3461028
repo sync --jobs doesn't check for errors, so we shouldn't use it in
automated scripts. repo --trace is needed so that we can diagnose
whether git is hanging.
BUG=chromium-os:7048, chromium-os:6774
TEST=Ran test suite
Change-Id: I9e68cfffe841a231f5fabef951ea2d45b81c1d5e
Review URL: http://codereview.chromium.org/3419024
This is needed in order to do the right thing when adding projects
which require a revision attribute.
BUG=6811
TEST=Updated unittests and verified they pass.
Verified that I can add chromeos-kernel-next and revision gets set.
Change-Id: I12818dad464094cd50098170da3fcf38b1e32f17
Review URL: http://codereview.chromium.org/3400019
- This unbreaks the devserver's update server for ARM.
- This also unforks some of build_image.
BUG=None
TEST=Installed to tegra2_seaboard from USB without --skip_vblock,
updated tegra2_seaboard.
Review URL: http://codereview.chromium.org/3493004
Change-Id: I6e66344de51609393407934f78aa20f49974efef
BUG=
TEST=Tested by persisting, ctrl+c, continuing and using same vm.
Also without --persist
Review URL: http://codereview.chromium.org/3419014
Change-Id: I49e26eb86101e8b8b50e58a9f277d62d5fadc664
