This script is a bit of mess in general as it copies client directories
back onto client proper. This creates issues when you add additional
directories that might exist in client to base that either the
FACTORY_TEST_INSTALL_MASK isn't expecting.
BUG=chromium-os:26561
TEST=Ran build_image factory_test with/without packages directory.
Change-Id: I692d44f7c56668d689350d0f3a2a2c2790c6c13a
Reviewed-on: https://gerrit.chromium.org/gerrit/17713
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Scott Zawalski <scottz@chromium.org>
Commit-Ready: Chris Sosa <sosa@chromium.org>
The factory test image was created by using rsync from build artifacts
in chroot, which has some concerns:
- Runtime dependencies of autotest-factory won't be picked into image.
- If a developer skips build_package and builds image by using only pre-built
binary packages, he will get nothing in factory test image.
- It's hard for developers to figure out how and when his changes will be
merged to next build_image (cros_workon does not really work).
- Output image will be definitely different for every developers, also the
official build bots.
- If developers never wipes his chroot (setup_board), the factory test image
will grow until out of space. (For example, my environment outputs a 825M
image while the official buildbot generates only 563M for same ToT source).
This CL changes image build command to using portage emerge, so that output
image can be prepared faster and smaller, and easier for maintenance.
BUG=chromium-os:3335
TEST=./build_packages; ./build_image --factory # Image starts factory UI successfully
# Also tried tests in test_list.all, seems fine.
time ./mod_image_for_test.sh --factory --force_copy --no_inplace
# time: 3m2s => 1m55s, factory test image data: 825/563M => 378M
./build_image --factory_install # factory install shim is also fine
Change-Id: I82b4505c74cd31e718aaff4a319d50b69b2c852c
Reviewed-on: https://gerrit.chromium.org/gerrit/14473
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
This is the counterpart of http://gerrit.chromium.org/gerrit/6992 ,
which moves init modification from scripts folder into ebuild file.
The 'customizeRelease' is also already deprecated.
BUG=chromium-os:9596
TEST=build_images --factory # pass
Change-Id: I8087f627f4b13d9f6b1d4bf6003630298a87c627
Reviewed-on: http://gerrit.chromium.org/gerrit/7040
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
The '500populateQualDbs' script is now deprecated by the new chromeos-hwid
ebuild package.
HWQual database are merged into images automatically, no more need for
post-processing.
QUALDB and --qualdb are also removed, with typo in comments fixed.
BUG=chrome-os-partner:4276
TEST=./build_image --factory
Change-Id: I76d9a72943567444e26200fccc6fe5dff95b2687
Reviewed-on: http://gerrit.chromium.org/gerrit/3431
Reviewed-by: Vince Laviano <vlaviano@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
update-engine.conf has changed, adjust this patch to match.
BUG=chromium-os:16079
TEST=none
Change-Id: I90572f0a42bcc6eb5c501fa32212d846f2357757
Reviewed-on: http://gerrit.chromium.org/gerrit/2431
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
ui.conf has changed, adjust this patch to match.
BUG=chromium-os:16079
TEST=none
Change-Id: I33d0bb7150a549c7203f22f4c3a05bfaea13379a
Reviewed-on: http://gerrit.chromium.org/gerrit/2430
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
chrontel.conf has changed, adjust this patch to match.
BUG=chromium-os:16079
TEST=none
Change-Id: I50709efe1d37084be5d974ba5a6353e6039d65f1
Reviewed-on: http://gerrit.chromium.org/gerrit/2394
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
mod_for_factory patches boot-complete since it disables the ui job,
meaning that login-prompt-visible will never happen. The correct
place to move "boot-complete" to is "started boot-services" - this
means all boot services are done.
system-services depends on boot-complete, so this means that without
ui, system-services will be run on started boot-services which is
what we want.
BUG=chromium-os:16079
TEST=none
Change-Id: I93b86eefe8df9da2e9fbff75aa1e9b80a1f9ad1b
Reviewed-on: http://gerrit.chromium.org/gerrit/2323
Reviewed-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
we don't want any possibility for firmware to be changed in factory setup
BUG=none
TEST=build_image; image_to_usb --factory
Change-Id: Ibef767ea621193afb7fbca5ea96120a506891dcb
R=nsanders@chromium.org
Review URL: http://codereview.chromium.org/6764010
To get best factory test image performance, we should disable update engine.
BUG=chromium-os:13613
TEST=image_to_usb --factory --to=FACTORY
then verified /etc/init/update-engine.conf is disabled.
Change-Id: Ifb7b6c821f434ee68625ffea0eb7907c38d77315
R=nsanders@chromium.org
Review URL: http://codereview.chromium.org/6759023
This also deletes the code from mod_for_factory_scripts/200patchInitScript
that created the files that now come from the new package.
BUG=chromium-os:13258
TEST=Build and boot a factory test image
Review URL: http://codereview.chromium.org/6665048
Change-Id: I115d1a2e3afe2fdefc0e07247b21b67e0cf9cc62
In http://codereview.chromium.org/6567004 in order to help developers stopping
factory UI, we've added an "chvt 2". However changing foreground terminal may
hang when executing "shutdown -r" inside Wipe test.
Removing the "chvt" call solved this issue. The only side effect is that
developers executing "initctl stop factory" may end seeing a black scren - and
they need to hit Ctrl-Alt-F2 to get the console back.
BUG=chrome-os-partner:2631
TEST=build a factory image then verified following steps:
(1) in VT2, do "initctl stop factory, then C-A-F2: screen changed to VT2.
(2) Execute factory tests until Wipe: reboots immediately when X closed
(3) Execute Reboot in HWID test: reboots immediately when 'reboot' is ACTIVE
Change-Id: Ib6f44a6ad07db08862929179d0fe21cbbcc2b22a
Review URL: http://codereview.chromium.org/6621041
Developers may want to run their own factory test UI after finishing the
Google official one, so the "factory" test should be stoppable.
BUG=chrome-os-partner:2456
TEST=build a factory image, install and start factory testing UI,
then switch to VT2, login and type: "initctl stop factory"
the screen should switch to a virtual terminal (VT2) without
hanging / reboot.
Change-Id: I6a9d1c951d48d448f5c83c5f645ea531e8fd1499
Review URL: http://codereview.chromium.org/6567004
The factory tests should not use default results folder, otherwise a developer
running autotests by command line would corrupt the whole factory test
framework.
Since tools/autotest cannot support additional parameters and our state (to
continue) is clear, the command is also changed to directly invoke bin/autotest.
BUG=chrome-os-partner:2378
TEST=manually patched into a factory test device and verified factory
UI works at new boot and a reboot.
Change-Id: I9f6ef31114bdda740319072c6f9ac624f6850b95
Review URL: http://codereview.chromium.org/6529046
I'm changing the boot-complete init script to start on
login-prompt-visible instead of login-prompt-ready in
http://codereview.chromium.org/5868004/.
This also adds a missing description and fixes an outdated
email address.
BUG=chromium-os:10349
TEST=ran mod_image_for_test.sh with --factory and with --factory_install and checked that resulting image contained boot-complete.conf change
Review URL: http://codereview.chromium.org/5975002
Change-Id: I709bc2b4eaaccd222b31388633522c32514206ac
The default DB is an all-pass DB. If no DB found, the hardware_Components test
falls back to the all-pass one and skip the real check. In order to prevent
skipping the check, remove the default DB in the boards already have DB
directories.
TEST=run "image_to_usb.sh --factory" and check the default DB removed
BUG=chrome-os-partner:1737
Change-Id: Ia25f2551a5eba3a95fe736e86bfe52c340f329a8
Review URL: http://codereview.chromium.org/5339011
- Conditionally patch chrontel.conf
- Add a patch for nvrm to start on factory, so that X can start.
BUG=crosbug.com/p/1721
TEST=Built and run factory image for tegra2_seaboard
Change-Id: Ied87b6d959f940ef8e99e124ab419fdeea48aa26
Review URL: http://codereview.chromium.org/5126005
Major changes are:
- prefix functions in cros_image_common with 'image' to avoid naming conflicts
- use awk to replace grep+sed+cut
- use case to handle board name list
- factory_setup.sh should return error if applying patch failed
- refine for shell script coding style guide:
* replace `` with $()
* quote variables
* replace "! -z" by "-n"
* no space between redirection symbol (>) and target name (eg, >>filename)
* 1> should be simply >
* no trailing \ for && and ||
BUG=chrome-os-partner:1583
TEST=manually verified:
./image_to_usb.sh --factory # calls mod_image_for_test --factory, and works fine
./make_factory_package.sh --factory PATH_TO_IMAGE --release PATH_TO_IMAGE ...
# factory payloads were created successfully
Change-Id: I6bb10bdfb12cbdb14e9816b3ad72dfe4b7b0472f
Review URL: http://codereview.chromium.org/5168001
This caused a build break after http://codereview.chromium.org/3995007 was
committed, since we try to patch a now-nonexistent file.
BUG=None
TEST=Adhoc
./mod_image_for_test.sh --factory_install doesn't hang
Change-Id: Iac299c850765eedfcefcffb80c385b0e8c0fa277
Signed-off-by: Elly Jones <ellyjones@chromium.org>
Signed-off-by: Kliegs <kliegs@chromium.org>
Review URL: http://codereview.chromium.org/3973004
We use the filename format gbb_${BOARD}_${HWID} for GBB blob files and
place them in the same directory of site_tests/factory_WriteGBB, but in
private git.
Actually, these files will be automatically put in the factory image.
This change is to remove those not belonging to the same board.
Also do some fixes and rename QualDbs stuffs.
TEST=run image_to_usb.sh and check the gbb files.
BUG=chrome-os-partner:789
Change-Id: I5913a14eb3ceef5abfdf1a87156faa6bb7dbd561
Review URL: http://codereview.chromium.org/3111014
All Qual DBs may be existed in the same directory of hardware_Components (overlaid internal git). So, if QUALDB is not specified, first check the existence of DBs matched the board name. Then remove other DBs not belonging to the board.
TEST=build_packages, build_image, image_to_usb
Review URL: http://codereview.chromium.org/3032036
The DBs are named in the format of qualified_components_${BOARD}_${HWQUALID}.
If only one hwqual id for the board, named in qualified_components_${BOARD}.
Review URL: http://codereview.chromium.org/3038026
A file name changed which breaks the factory test phase on the builders.
This change was LGTM'd but not submitted.
Patch from Tom Wai-Hong Tam <waihong@chromium.org>.
Change-Id: I961515ba4667891d82833035f2d312a653f746fd
* Leave ui.conf there, not run by default.
* dump autotest log into /dev/tty1
* Don't let tty1 eat keayboard events.
Review URL: http://codereview.chromium.org/1742018
Dropping caches (writing back all dirty pages to disk and clearing all the caches) is not necessary for factory tests. It can reduce the latency significantly. The scale is about 27s -> 3s, for running 2 empty tests.
Review URL: http://codereview.chromium.org/1780011
Add feature to mod_image_for_test to patch rootfs.
Change initctl path to get network but no chrome.
./image_to_usb.sh --install_mfg --install_autotest --test_image
which calls ./mod_image_for_test.sh --manuf
Review URL: http://codereview.chromium.org/1542011
