This also removes the rw_checkout var as it's not longer changes the affect of whether we use the ssh url or not.
Note that this replaces the other CL from last night because the other CL didn't work. The other CL still pulled in the same manifest that has http: url's for each git repo. I reverted that change last night after I noticed this.
Change-Id: I3d4ad2be6887ac2cf4ed2009bad9cae6dfdf5bbf
BUG=chromium-os:9509
TEST=Ran with cbuildbot --clobber and incremental
Review URL: http://codereview.chromium.org/5278010
Other things:
Removing commit|clean|push command from cros_mark_chrome because it's unnecessary ... I'm just gonna use the same stabilizing branch as the other stable marker, so I can use the same clean / push from the other script. This makes this change fit in much more nicely to cbuildbot.
Other changes:
Add ability for cros_mark_chrome_as_stable to communicate to calling script through stdout.
Make STABLE_BRANCH in cros_mark_as_stable public for above reason.
Removed push_options from cros_mark and accompanying change to cbuildbot as it isn't used anymore.
Made it easier to debug with cbuildbot (I ran cbuildbot A LOT of times to test this change so I felt the pain)...this includes:
- only build when syncing
- allow one to explicitly disable tests
- use dryrun is options.debug is set
Change-Id: I413a2e81a99cdde2e4d9139561cd518245b9b346
BUG=chromium-os:8693
TEST=Ran cbuildbot with --notest --debug --nosync x86-pre-flight and
saw it go through correctly and dryrun push. Ran cbuildbot with same and --chrome_rev=tot. Ran with syncing and running tests too.
Review URL: http://codereview.chromium.org/5154008
This is a complement to the proposed fix for http://crosbug.com/9447, and I am getting it out first since it is a relatively simple change.
This change ensures that the rootfs on the image output by cros_make_image_bootable wasn't corrupted accidentally (for example, no boot.desc was provided and the defaults were incorrect for the image). This should catch rootfs errors that we end up discovering at delta AU time.
BUG=chromium-os:9578
TEST= Ran cros_make_image_bootable manually on an existing image with and without boot.desc. As expected, without boot.desc the output image rootfs had errors.
Also ran ./build_image - which worked fine too.
Change-Id: I4ed3a56634f37ab7d5ff2dc052ad607740356a40
Review URL: http://codereview.chromium.org/5216003
Change-Id: I680e28bcafbfeb4f19e2404e2b28761e26111f7f
BUG=chromium-os:9509
TEST=Ran cbuildbot on my local builder checkout with both clobber and without.
It sync'd and built.
Review URL: http://codereview.chromium.org/5312002
added --test option
removed superfluous output (e.g. from dd) unless --verbose given
added --debug option for when you really want that output
added use of pv for a nice progress bar
TEST=(run script several times)
BUG=chromium-os:9563
Change-Id: Ib9d89ad5649b6cb6d5db35f66f6a3fda1ada0c53
Review URL: http://codereview.chromium.org/5176002
Change-Id: I6744aac09fb075f91f710f16343fab45b8dc8af9
BUG=chromium-os:7283
TEST=Ran it with cbuildbot through the unit tests phase and looked
at the file and saw it get parsed correctly.
Review URL: http://codereview.chromium.org/5124006
Have subsequent review for cbuildbot that calls this for the pfq.
This module has 3 modes ... TOT, latest_release, sticky_release that describe the three different types of revs for chrome we will be supporting.
For tot, we grab the latest svn revision # from the chrome src tree, and rev to the corresponding ebuild i.e. 9.0.553.0_alpha-r1 with CROS_SVN_COMMIT=svn revision number.
For latest_release, we grab the latest release from the releases page, and create an ebuild (or rev a previously existing on with same version) and use the release candidate suffix _rc.
For sticky_release, we use much of the same logic as latest_release, however, we specifically look to rev _rc's in the sticky branch.
This change depends on http://codereview.chromium.org/5172003 for the cros_mark_as_stable changes.
Change-Id: Idc1f4cd905cc1dcb4c44422f6104760077a24b8d
BUG=chromium-os:8693
TEST=Ran cros_mark_as_stable with --packages="chromeos-base/chromeos-chrome" --chrome_version=0.8.65.0 --chrome_revision=67890 commit. Re-ran unit-tests as well (though thinking about adding another unit test for chrome revving)
Review URL: http://codereview.chromium.org/4798001
This would not have been a problem if "--no_graphics" is used.
Change-Id: I3645391d25d4bb8618109ff5be0ca2fbe8e96a60
BUG=chromium-os:9373
TEST=Ran by hand
Review URL: http://codereview.chromium.org/5104006
Preflight clean needs to wait until after the checkout happens before
it asserts that all of our overlays exist.
BUG=chromium-os:9197
TEST=Ran cbuildbot.py with missing chromiumos-overlay dir
Change-Id: If66574f01d1e85741e971919a9fa2da34f85872d
Review URL: http://codereview.chromium.org/5069001
Change-Id: I34e9d64656e04d4f5c477914512219d9b8563b78
BUG=chromium-os:9137
TEST=Ran with both wrong and right versions against a Google Chrome and
Chromium build
Review URL: http://codereview.chromium.org/4942001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=795bd30
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
BUG=8544
TEST=build chrome with build_tests, cros_workon start autotest, and then run desktopui_BrowserTest with cros_run_parallel_vm_tests
Change-Id: I19e181238fd75450d41f6debb3a8f7d0c17d15dc
Review URL: http://codereview.chromium.org/4669007
Change-Id: I87c41e60797848192cee1f0c165215fcec8f5bd2
BUG=8850
TEST=Ran a few tests including suite_Smoke
Review URL: http://codereview.chromium.org/4647001
...so that the console doesn't get messed up due to the serial port being
redirected from stdin.
BUG=8729
TEST=./bin/cros_run_parallel_vm_tests suite_Smoke suite_Smoke; checked console
Change-Id: I5a0cedba2b0ac7f453b4574666c645e84b30b379
Review URL: http://codereview.chromium.org/4501001
If the option is specified, the utility will pipe the test stdout/stderr
to separate files and dump them at the end.
BUG=8585
TEST=./bin/cros_run_parallel_vm_tests suite_Smoke suite_Smoke --order_output
Change-Id: I6c4fcb02456441b4e4fc3f1717cdb5d607d733b9
Review URL: http://codereview.chromium.org/4422001
This allows the user to specify a custom results directory root. cbuildbot can
be switched to use cros_run_parallel_vm_tests if necessary without any further
changes.
Also create parents directories for user-specified results directory roots in
run_remote_tests.
BUG=8585
TEST=./bin/cros_run_parallel_vm_tests suite_Smoke suite_Smoke \
--results_dir_root=/tmp/foo
Change-Id: I7314c1d9e74ca139eaa4bd95290866a43a3606ff
Review URL: http://codereview.chromium.org/4297003
When you pass '--foo="bar baz"' to a script, the argument is literally
passed as "bar baz", with the quotes. So we need to not add unnecessary
quotes in there.
When enter_chroot.sh parses arguments, it actually removes the quotes
for you, and splits up arguments. As a result, it may actually
be necessary to (1) use the above broken syntax when you call scripts
using enter_chroot.sh; but (2) don't use that syntax when calling
scripts without enter_chroot.sh. That's a broken situation, so I've
added a TODO for that. I've also added more warnings to
cros_mark_as_stable.py so that it's easier to debug when it doesn't
work.
BUG=chromium-os:8633
TEST=Ran unit tests. Planning to watch TOT buildbot post-commit to make sure behavior is right.
Change-Id: Ia1a0e60153fec60cb7ed4db2da128ffd9ae81e23
Review URL: http://codereview.chromium.org/4385002
Current usage is simple: just specify a list of tests and each one will be run
on a separate VM using the latest image on a default board. Exit code is
non-zero if any of the tests fail. Output from separate tests is interleaved.
More CLs to follow -- specifying a result directory, non-interleaved output,
base ssh port, board, image path, etc.
BUG=8585
TEST=./bin/cros_run_parallel_vm_tests suite_Smoke suite_Smoke
Change-Id: Ifa3396768050905ec02e4cad8b8f065a6d129154
Review URL: http://codereview.chromium.org/4337003
Currently works around issue till we get a good fix in for 9.x.
Change-Id: I9c7225508fa8f46a5fa5e0b41abc4e373cc80085
BUG=8606
TEST=Tested by sending SEGV to a delta update during update and saw it successfully fall back to a full update and succeed.
Review URL: http://codereview.chromium.org/4258002
BUG=chromium-os:8493
TEST=Ran unit tests. Verified that cros_mark_as_stable.py supports
running on just the private or public overlay.
Change-Id: I5e2e8fc5e63b3c93bb688a5ce87233315c0c2d1c
Review URL: http://codereview.chromium.org/4250001
BUG=8306
TEST=Ran au_test_harness with CL for adding vm option for the devserver on the last channel release and my TOT. All tests passed.
Review URL: http://codereview.chromium.org/4165009
Change-Id: Ia2ce305dff2911dc4008d5f6e383535e4bbd4ab0
Change-Id: Iabc931f2eb1751ca9d05e92e64e5361755791648
BUG=
TEST=Copied and pasted from other try/except
Review URL: http://codereview.chromium.org/4109006
Currently cros/master is used for the tracking branch in the preflight
rinse step. This is wrong if --tracking_branch is specified
differently in the command-line options to cbuildbot.py.
BUG=none
TEST=Ran unit tests
Change-Id: Id4fb989863ae11f57889faf6a8d8b043b81da58e
Review URL: http://codereview.chromium.org/4104005
Change-Id: Ic6d4a79a7ab58b8043805a6b826f251faa9f3a6c
BUG=
TEST=Running now (adding unit tests as well)
Review URL: http://codereview.chromium.org/4062003
Add small if statement in cros_run_wifi_tests to balk if we didn't get
valid cell info from the server.
BUG=none
TEST=reboot everything and rerun while testbed server hasn't caught up yet
Review URL: http://codereview.chromium.org/4069001
Change-Id: If7db175f828fccdd4caa342a0370e842503f16dc
BUG=8015
TEST=Ran it with cbuildbot with/without --clobber with/without old state.
Review URL: http://codereview.chromium.org/4007005
What's new?
- cros_mark_all_as_stable is now in Python and has unit tests.
- We now detect and report coding errors that can cause incorrect behavior.
E.g., if 9999 ebuild or stable ebuild can't be found, we report a hard
failure so that developers will know about the problem.
- We now check that git hashes we report actually match up with the
right repository.
- Unified diff of changes are now printed to stdout, so that developers
can see a list of the changes and debug any problems.
- cros_mark_all_as_stable now takes 2.5 seconds to run.
BUG=chromium-os:7795
TEST=Manually examined diff output from run of cros_mark_all_as_stable
on full repository.
Change-Id: I762597c9b94e5f8e8171b83c966ad54e21a65c1b
Review URL: http://codereview.chromium.org/3798003
