Commit Graph

2152 Commits

Author SHA1 Message Date
Zdenek Behan
99f7a5397d scripts: call devserver/payload generators from chroot & delete moved scripts
BUG=chromium-os:5246

TEST=below, During all tests, the directory platform/dev was manually removed
1) Ran cros_au_test_harness.py and saw it succeed
2) Ran generate_au_zip.py, compared the generated .zip with one before this
patch - they were identical
3) Ran cros_image_to_target.py and saw it succeed

Change-Id: Iab2620245a45442b79ee8369f3af1a3990f4644e

Review URL: http://codereview.chromium.org/6576023
2011-03-01 22:57:33 +01:00
Darin Petkov
87dd2be709 Remove obsolete CHROMEOS_REVISION setting in enter_chroot.
BUG=chromium-os:11647
TEST=enter_chroot, build_image

Change-Id: Ib97e27fd0e6292ec7504dbc4312254bc574ba171

Review URL: http://codereview.chromium.org/6598056
2011-03-01 09:25:09 -08:00
Anton Staaf
dec0a5be72 Revert "Add optional logging prefix to info, warn and error messages."
The build bots run things a little different it seems.  I'll look into
what it is that they do that a normal run doesn't do that causes
this change to fail there.  But for now I'm reverting it.

This reverts commit 6d65c0f1b3.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6594062

Change-Id: I7cdfb25c28f1c139981aaf7382cd3e9dbfd4446b
2011-02-28 17:02:53 -08:00
Zdenek Behan
a400b3f5fa cros_image_to_target: use newstyle updates, followup after switching --nooldstyle to be the default
BUG=n0ne
TEST=run the script and see the update go

Change-Id: Ie767edf85876b7864f6425efed1ac554026ecdff

Review URL: http://codereview.chromium.org/6596062
2011-03-01 01:42:55 +01:00
Anton Staaf
6d65c0f1b3 Add optional logging prefix to info, warn and error messages.
BUG=chromium-os:11981
TEST=run cros_sign_bootstub with and without CROS_LOG_PREFIX set.

Change-Id: I320622d4161479dcc29ebdee68e160d94f1d3196

Review URL: http://codereview.chromium.org/6597053
2011-02-28 16:21:53 -08:00
Zdenek Behan
b9a951a13d scripts: allow calling cros_generate_update_payload from outside the chroot
This was broken by 798d75f3be and there
isn't a proper way to fix it right now, as that commit generally moves
everything inside the chroot. The few remaining scripts that need to be
called from outside need to do a path magic here or there to survive.

BUG=n0ne
TEST=below
1) generate_au_zip.py, unzip it outside the chroot and try running the script
2) cros_au_test_harness

Change-Id: I14bf0267ba2864d7946d657b23812b3dcd512f48

Review URL: http://codereview.chromium.org/6602018
2011-03-01 00:27:19 +01:00
Jim Hebert
5d184029ef jimhebert -> watch for kernel boot param changes so I can maintain tests.
Change-Id: I6a7b6c9ecb4380abb99df9cc12d29d975eb913db

BUG=chromium-os:12582
TEST=none
STATUS=Fixed

Review URL: http://codereview.chromium.org/6588059
2011-02-28 13:09:04 -08:00
Vadim Bendebury
8e623f6ea5 Modify x86 kernel command line to enable nmi watchog.
For the kernel nmi to be activated and function properly it
must be enabled in the kernel command line. This CL adds
`nmi_watchdog=panic,lapic' (which is equivalent of
nmi_watchdog=2) to the command line. The reason '2' was used
and not '1' is that nmi_watchdog=1 is known to break audio
functionality on chromeos devices.

Note that only x86 platforms are affected by this change,
ARM platforms will be added later.

This CL is required by the autotest CL

http://codereview.chromium.org/6596002

Change-Id: Ie8a9ba3f0de6d236cbe098e402b0240aa64ddcd0

BUG=chromium-os:12463, chromium-os:12464
TEST=see below

. build new image for test and install it on the target
. restart the target
. observe the contents of /proc/sys/kernel/nmi_watchdog (it
  should read '1' after reboot)
. run autotest as follows
 (chroot) ~/trunk/src/scripts $ ./run_remote_tests.sh \
   --board=x86-mario --remote=172.22.75.163 \
   platform_KernelErrorPaths kernel_BootMessagesServer \
platform_HighResTimers
. observe the results:

INFO   : Test results:
---------------------------------------------------------
kernel_BootMessagesServer                           PASS
kernel_BootMessagesServer/kernel_BootMessagesServer PASS
  coldboot_active_mb                                50
  coldboot_anonpages_mb                             36
  coldboot_buffers_mb                               3
  coldboot_cached_mb                                166
  coldboot_inactive_mb                              156
  coldboot_memfree_mb                               1649
platform_HighResTimers                              PASS
platform_HighResTimers/platform_HighResTimers       PASS
platform_KernelErrorPaths                           PASS
platform_KernelErrorPaths/platform_KernelErrorPaths PASS
---------------------------------------------------------
Total PASS: 6/6 (100%)

No crashes detected during testing.
Elapsed time: 4m28s

Review URL: http://codereview.chromium.org/6597001
2011-02-28 10:28:31 -08:00
Dale Curtis
2e671be911 Remove the crash whitelist for chromeos-wm sig 6 now that a fix has been pushed and cycled through the builders.
Change-Id: I91ebdcd62630011bb55c7d65d947bcab51533633

BUG=chromium-os:12212
TEST=Ran against a result set with crashes.

Review URL: http://codereview.chromium.org/6598010
2011-02-25 14:15:58 -08:00
Raymes Khoury
9e1084c7b8 Modified build_image to support new crossdev.
BUG=none
TEST=Ran build_image with and without the crossdev upgrade. Made sure it was picking up the correct tarball.

Review URL: http://codereview.chromium.org/6592013

Change-Id: I83e1c35b0d971aa9a5d69fb404a69f2a712bbe38
2011-02-25 14:01:10 -08:00
Mandeep Singh Baines
7b86ec098e run_remote_tests: fix bug where new symlink got created instead of update
The one symlink should be update instead of new links being created.

BUG=12233
TEST=Ran run_remote_test.sh many time and verified that the link is updated.

Change-Id: I63f325e03439e5c922e9fe2300444193146182f9

Review URL: http://codereview.chromium.org/6576051
2011-02-25 10:18:41 -08:00
Dmitry Polukhin
0a649b57d9 Remove /mnt/partner_partition
BUG=chromium-os:6840
TEST=Build and install Chrome OS image, no issues observed

Change-Id: I24ea3a96490a81c8926852eff6d2451e57e196f7

Review URL: http://codereview.chromium.org/6546045
2011-02-24 13:02:52 +03:00
Benson Leung
393c17b0cc Allow run_remote_tests to learn board instead of default board
If no board is specified for run remote tests,
learn board from device under test instead of using
default board.

BUG=none
TEST= ./run_remote_tests.sh without --board. Verify detects board and
deploys appropriate version for that board.
./run_remote_test.sh with --board x86-mario. Verify that it deploys
that specific board, regardless of target.

Change-Id: I6e71f0f1bf4b2bcfcd3430b29adc16531c6a8c81
Signed-off-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Chris Sosa <sosa@chromium.org>

Review URL: http://codereview.chromium.org/6580017
2011-02-24 01:46:14 -08:00
Hung-Te Lin
fa2dd93743 crosutils: fixing factory upstart script to allow stopping factory test ui.
Developers may want to run their own factory test UI after finishing the
Google official one, so the "factory" test should be stoppable.

BUG=chrome-os-partner:2456
TEST=build a factory image, install and start factory testing UI,
     then switch to VT2, login and type: "initctl stop factory"
     the screen should switch to a virtual terminal (VT2) without
     hanging / reboot.

Change-Id: I6a9d1c951d48d448f5c83c5f645ea531e8fd1499

Review URL: http://codereview.chromium.org/6567004
2011-02-24 16:32:35 +08:00
Che-Liang Chiou
75ac2beb67 Add transitional flag for enabling arm kernel signing
For now arm kernel partitions are not signed. This CL is a transitionsl.
That is, the added flag should be removed after arm verified boot is stable.

To properly create an arm kernel partition, we also need another CL for
vbutil_kernel utility that turns off x86-only modifications on kernel
image. See CL:6538015.

BUG=chromium-os:3790,chromium-os:12352
TEST=see below

Build images for x86 and arm successfully, and notice that load_kernel_test
passes for x86 and signed arm image.

$ build_image --board=tegra2_seaboard --crosbug12352_arm_kernel_signing
$ build_image --board=tegra2_seaboard --nocrosbug12352_arm_kernel_signing
$ build_image --board=x86-generic

Review URL: http://codereview.chromium.org/6538014

Change-Id: I1be381bae2fc367a0603ac2ec67ee70fc9a257e4
2011-02-24 12:00:16 +08:00
Luigi Semenzato
3635aaa55e Revert "RunCommand was catching and rethrowing an exception, which seemed to generate"
This reverts commit 01c8423582.

BUG=chromium-os:11717
TEST=none

Review URL: http://codereview.chromium.org/6575022

Change-Id: I4e66e7b2fcf01a4cb35557bdf208f990e6d8eb2b
2011-02-23 19:14:53 -08:00
Don Garrett
01c8423582 RunCommand was catching and rethrowing an exception, which seemed to generate
extra noise in the final exception output.

This change stops catching and rethrowing the same exception, and generally
makes the RunCommand slightly more readable (if longer).

Some unit tests are added, but they only test RunCommand, and not all options
to RunCommand.

BUG=chromium-os:11717
TEST=Manual, and new lib/cros_build_lib_unittest

Review URL: http://codereview.chromium.org/6576016

Change-Id: Ibe9b13ff302621e93196008f86914cb65a232d61
2011-02-23 17:36:52 -08:00
David James
e8875485ea Update build_image to link to make.globals directly, instead of to directory.
The xorg-server ebuild creates /usr/share/portage on the rootfs partition. This
breaks build_image which wants to point the same directory at the stateful
partition.

To work around this we just link to make.globals directly. This workaround fixes
gmerge but doesn't address the problem that there might be more files inside
/usr/share/portage. A better fix should be addressed as part of
crosbug.com/11502

BUG=chromium-os:12441
TEST=Run build_image and verify /usr/share/portage/config/make.globals points to
     /usr/local/share/portage/config/make.globals and that the latter also
     exists.

Review URL: http://codereview.chromium.org/6583001

Change-Id: I52fd9d34bf29573fbf6ca013ba49d1c8608e066d
2011-02-23 15:24:14 -08:00
Chris Sosa
4de24322bd Revert "Add build flag for iterative vm testing."
This reverts commit 519a6560e4.

BUG=For AU harness failures.
TEST=TBR

Review URL: http://codereview.chromium.org/6579014

Change-Id: I6001bf4c52951e4d9698985285538b162ae6b6f6
2011-02-23 14:22:39 -08:00
Will Drewry
b910de849c kernel build: use %U+1 for dm-verity booting
Using %U+1 will ensure that we avoid device enumeration issues during recovery mode
boots.

TEST=build_image+dev recovery kernel and boot to it on new cros fw / fixed enumeration problem
         used build with mp recovery kernel on cr-48 -> installed then booted fine
         used dev recovery kernel on a legacy machine; installed fine, booted fine
         tested with cr-48, mp recovery kernel, and noenable_rootfs_verification to ensure /dev/sd%D%P still worked as normal.

Change-Id: I5b1277a47536738a78c18988fd912cc05ebddd4b

BUG=chromium-os:5470

Review URL: http://codereview.chromium.org/6549034
2011-02-23 13:26:50 -06:00
Chris Sosa
519a6560e4 Add build flag for iterative vm testing.
Change-Id: Ib8258b33f87aeadfbaee145bdf7ab460af66c39f

BUG=N0ne
TEST=Ran it with --build

Review URL: http://codereview.chromium.org/6368129
2011-02-22 17:56:14 -08:00
Zdenek Behan
18d5703fd7 scripts: use /sbin/ifconfig where appropriate
BUG=n0ne
TEST=cros_au_test_harness

Change-Id: Ic26cc191fdb995b091d910f1c8a46e37085fea72

Review URL: http://codereview.chromium.org/6538067
2011-02-19 00:36:23 +01:00
Mandeep Singh Baines
0cb1d1def8 run_remote_tests: create a symlink to the last test that completed
Having this symlink is extremely useful if your running the same
test over and over again.

BUG=n0ne
TEST=Verified that the symlink is there.

Change-Id: I625a48ce4348082db05951ffd67929687ad461cc

Review URL: http://codereview.chromium.org/6543021
2011-02-18 14:04:18 -08:00
Zdenek Behan
c264a45ba8 au_test_harness: fix a function call, add sudo in front of ifconfig
Note: sudo before ifconfig is for running on distros which do not
have /sbin or /usr/sbin in common user's paths, like gentoo.

Change-Id: I85bd379ad059d6ecaa8c11f3167fae27987479dd

BUG=5246
TEST=run cros_au_test_harness and see it not fail

Review URL: http://codereview.chromium.org/6541008
2011-02-18 06:06:55 +01:00
Zdenek Behan
9a776566e9 image_to_live.sh: fix ip address detection
Change-Id: I6d05da5d1deaf45c42a3285c105fd310a588ef4e

BUG=5246
TEST=update an image, live

Review URL: http://codereview.chromium.org/6531005
2011-02-18 00:51:21 +01:00
David James
49523439a1 Update make.globals fixing code to point at new location of make.globals.
BUG=chromium-os:12264
TEST=Ran build_image, verified existence of /usr/share/portage/config/make.globals

Review URL: http://codereview.chromium.org/6532038

Change-Id: I621110738a1e8d789a4f58bdc1db1a7b2251ad29
2011-02-17 15:19:16 -08:00
Chris Sosa
9769c6bc9f Move check for image until we actually need it.
This addresses the case where we don't have chromiumos_image.bin but don't
actually need it since we've previously generated a test image.

Change-Id: Ie7be0165e0f68bbd9d34156b55e17d971cb86fa9

BUG=chromium-os:12268
TEST=Ran it with --noinplace and missing dev image.

Review URL: http://codereview.chromium.org/6538031
2011-02-17 12:42:22 -08:00
Andrew de los Reyes
ed145d0c51 Revert "start_devserver: update relative paths in command line flags"
This reverts commit d5e061957f.

BUG=chromium-os:12122
TEST=None

Review URL: http://codereview.chromium.org/6534027

Change-Id: I286ac77dd463be067055ecbef6ba2dd0e321cad2
2011-02-17 12:26:38 -08:00
Andrew de los Reyes
d5e061957f start_devserver: update relative paths in command line flags
Because this scripts changes directory, it's possible for relative
paths to be incorrect when read by the actual dev server. This fixes
the issue by prepending the current working directory to relative path
args.

BUG=chromium-os:12122
TEST=tested relative paths w/ dev server

Change-Id: I7a85e4af5df291ec78afb0f2c1580855c38a258e

Review URL: http://codereview.chromium.org/6525011
2011-02-17 10:44:00 -08:00
Darin Petkov
ab463c0844 Move crypted passwd file to /etc in build_image.
This temporary hack is intended to provide to developers a smooth transition to
the new crypted password file location.

BUG=chromium-os:11664
TEST=build_image

Change-Id: I34383f6e08ee8db53e407b30df604c403c72b5eb

Review URL: http://codereview.chromium.org/6539019
2011-02-17 10:42:24 -08:00
J. Richard Barnette
60a5ce0751 Enhancements to bootperf, based on recent user feedback.
Enhancement 1:  Fail if we run outside the chroot, because otherwise
you have to wait 10 minutes to find out your results won't be gathered.

Enhancement 2:  Print the location of the log output file, for the
benefits of looky-loos who want to see what's going on.

Change-Id: I388b1855c5b6bb20b0efffbf0babd1f60caf7bcb

BUG=None
TEST=run the script per instructions, and see the new output
TEST=run the script outside the chroot, and see it fail immediately

Review URL: http://codereview.chromium.org/6519039
2011-02-17 10:33:28 -08:00
Darin Petkov
36e69d0c77 set_shared_user_password.sh updates /etc/shared_user_passwd.txt
This is necessary so that the baselayout ebuild can be
changed to set /etc/passwd and /etc/shadow appropriately.
A previous attempt to do this through an environment
variable in make.conf.user failed because pkg_postinst
from binary packages run in their prebuilt environment
(and, thus, are not picking the user specific variables).

BUG=chromium-os:11664
TEST=ran set_shared_user_password.sh multiple times, observed
/etc/shared_user_passwd.txt and shared_user_passwd.txt getting updated.

Change-Id: I23b77c7417db0fd18b251f7cca62027813b182a8

Review URL: http://codereview.chromium.org/6534003
2011-02-17 09:34:29 -08:00
Don Garrett
c5ae0344d2 ReinterpretPathForChroot for public key
Change-Id: Ifcd52aad929453e801d143f5e16c26566aac4405

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/6532015
2011-02-16 21:27:32 -08:00
Don Garrett
2d08a983b2 I'm still breaking the build. Reverting again until I figure out why.
TBR

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6507034

Change-Id: I21283ed2b1f81086ccc95b0436e66c53584f4583
2011-02-16 18:39:35 -08:00
Don Garrett
e47eee3bc8 The original --quiet change failed (and was reverted) because cros_au_test_harness.py wasn't updated when the argument was changed from --quiet to --hide_info.
So... revert the reversion, and fix cros_au_test_harness.

BUG=chromium-os:11680
TEST=Manual

Review URL: http://codereview.chromium.org/6537005

Change-Id: I1bdf66a5735d4178ee1e2eaa838e7b4b7fb966d5
2011-02-16 15:49:14 -08:00
Chris Sosa
b885b80a33 Remove old logic ... and don't needlessly modifiy dev image.
Change-Id: I9b4047f2f124875553542df73e16cba6be41c561

BUG=chromium-os:chromium-os:8364
TEST=Ran it with pfq options.

Review URL: http://codereview.chromium.org/6527001
2011-02-16 15:33:11 -08:00
Dale Curtis
900bbd53ed Add crash whitelist for chromeos-wm: sig 6.
Change-Id: I776b3b92c81f6e00b179766fd16a322af4c0379c

BUG=chromium-os:12212
TEST=Ran against test logs for failed build.

Review URL: http://codereview.chromium.org/6534006
2011-02-16 14:33:06 -08:00
Dale Curtis
1838b64fcf Add crash detection to test report generation.
As titled, similarly to http://codereview.chromium.org/6508003/, crashes are now detected in Autotest runs and will result in an error being thrown when detected.

The error thrown during crash detection will cause smoke failures and close the tree.

Change-Id: I403833c99c6c37f971bdbe962655ead10a1014c5

BUG=chromium-os:12100
TEST=Ran bvt, smoke with good and bad builds through run_remote_tests.

Review URL: http://codereview.chromium.org/6526031
2011-02-16 12:01:17 -08:00
David Rochberg
33373ef899 Make mount points before attempting to mount on them
BUG=chromium-os:11944
TEST=the correct test for this is a complete rebuild; I have this running, but it's going to take a little while.  I have tested this on the specific cases of ssh_auth_sock and .subversion

Change-Id: I61723356c58bfb7c2090e950208b8a6ab8fa2fc9

Review URL: http://codereview.chromium.org/6519022
2011-02-16 14:48:27 -05:00
David Rochberg
351a76fc96 enter_chroot: Only mount SSH auth socket when we need to.
Also refactors some cut-and-paste code

Fix:  makes mountpoint for subversion directory

BUG=chromium-os:11944 chromium-os:12058
TEST=enter_chroot.sh with and without another enter_chroot running.  Note that there are 0 or 1 mounts of the /tmp/ssh-.... directory.  Check that /proc,/sys,/dev,$SSH_AUTH_SOCK,/dev/pts,/home/${USER}/trunk,/home/${USER}/.subversion are all mounted.   Test that subversion mountpoint is created

Change-Id: I9dada6f7f98d263345af29a5734c1c70709f6a1e

Review URL: http://codereview.chromium.org/6498001

Review URL: http://codereview.chromium.org/6525020
2011-02-16 11:14:00 -05:00
Hung-Te Lin
da36382f03 crosutils: let factory test uses its own results folder
The factory tests should not use default results folder, otherwise a developer
running autotests by command line would corrupt the whole factory test
framework.

Since tools/autotest cannot support additional parameters and our state (to
continue) is clear, the command is also changed to directly invoke bin/autotest.

BUG=chrome-os-partner:2378
TEST=manually patched into a factory test device and verified factory
     UI works at new boot and a reboot.

Change-Id: I9f6ef31114bdda740319072c6f9ac624f6850b95

Review URL: http://codereview.chromium.org/6529046
2011-02-16 18:37:03 +08:00
Don Garrett
8dcd981bbf Revert "Add --quiet to run_remote_tests, and use it"
This reverts commit 5b7e1d5da4.

Reverting to fix the build. TBR

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6480108

Change-Id: Idc9e60f97dd545225538420402c71b611233ce1e
2011-02-15 21:01:40 -08:00
Don Garrett
5b7e1d5da4 Add --quiet to run_remote_tests, and use it
Change-Id: I91f490ba4c4a834ba01b671c56c63ba230561ada

BUG=chromium-os:11680
TEST=Manual

Review URL: http://codereview.chromium.org/6529010
2011-02-15 17:40:56 -08:00
Chris Sosa
69cdce233e Fix tree closer. Deal with none case for PFQ.
Change-Id: Ia7883c196c688236051a4637561c9a01be5358cb

BUG=TreeCloser
TEST=Ran with simple prefix for x86-generic and no keys

Review URL: http://codereview.chromium.org/6480085
2011-02-15 12:51:06 -08:00
Chris Sosa
8dad50d97f Update test harness to take in optional public and private keys to sign payloads.
In addition some refactoring to make this cleaner and easier.

Change-Id: I1607700d065c71aff2b2833b10acbd3ebace68ce

BUG=chromium-os:8212
TEST=Ran with Simple ... running now with full

Review URL: http://codereview.chromium.org/6482017
2011-02-14 15:29:32 -08:00
David James
1ed7fe6b70 Update links to point at new location of parallel_emerge.
BUG=chromium-os:4230
TEST=grep for references to old parallel_emerge location

Change-Id: I3238e719e01df57648d3d91c0dfd7c37f7a934ee

Review URL: http://codereview.chromium.org/6246058
2011-02-14 14:49:25 -08:00
Chris Sosa
c04833cb5b Add tarball option and print out what gsutil would do to make it easier to debug.
Change-Id: I041053a017ee0aabbbeb30b4753bf9594e8d1d83

BUG=chromium-os:8364
TEST=Ran it manually here.

Review URL: http://codereview.chromium.org/6508011
2011-02-14 11:31:14 -08:00
David Rochberg
a821a8c856 Revert "enter_chroot: Only mount SSH auth socket when we need to."
This reverts commit 11753bf13442ce1da1488abb372940353f8844ff.

BUG=12058

Change-Id: I5175ea81dbf20cc3a4c290c750a7cc5c9841e3fa

TEST=

Review URL: http://codereview.chromium.org/6520012
2011-02-14 12:13:37 -05:00
David Rochberg
abaf1ccf15 enter_chroot: Only mount SSH auth socket when we need to.
Also refactors some cut-and-paste code

BUG=11944
TEST=enter_chroot.sh with and without another enter_chroot running.  Note that there are 0 or 1 mounts of the /tmp/ssh-.... directory.  Check that /proc,/sys,/dev,$SSH_AUTH_SOCK,/dev/pts,/home/${USER}/trunk,/home/${USER}/.subversion are all mounted

Change-Id: I9dada6f7f98d263345af29a5734c1c70709f6a1e

Review URL: http://codereview.chromium.org/6498001
2011-02-14 11:09:26 -05:00
Chris Sosa
89e9244910 Print out full path to archive url.
Change-Id: I6df0244d786794107c7d166c882c3585837c48a5

BUG=chromium-os:8364
TEST=Visually

Review URL: http://codereview.chromium.org/6512004
2011-02-11 17:42:55 -08:00