* Bend iterate to accept either list of packages or --all, following the new
semantics
This is a re-upload of the original CL which seems to be broken beyond repair
by the git malfunctions yesterday
Review URL: http://codereview.chromium.org/3040001
* Replaced listall with list --all
* stop/start without arguments will now fail
* stop/start with --all will do just the expected thing
* Rewritten package list decision logic
TBR: msb - already got LGTM, then fixed a comment i noticed
Review URL: http://codereview.chromium.org/2963011
Override locally warn/error functions to not interfere with stdout of canonicalize_name.
Future FIXME in common.sh.
Review URL: http://codereview.chromium.org/2985003
* Warn if user stops working on a package he wasn't working on
* Warn if user starts to work on a package he already is working on
Review URL: http://codereview.chromium.org/2978002
* This fixes the issue, where cros-workon packages have a package.mask set
to prevent upstream ebuilds from rolling in. In general, it brings out the
cavalry for unmasking the live package in every possible way.
Review URL: http://codereview.chromium.org/2934007
We need to be able to use "cros_workon list" in pipelines. Also, would
be nice if the other commands were less verbose. Ideally, they should
die and return a non-zero value.
Also cleaned up the logic in some of the functions. This fixed a couple
of bugs:
1) "cros-workon list" would fail if KEYWORDS_FILE didn't exist
2) "cros-workon start" would fail if KEYWORDS_DIR didn't exit
Change-Id: I76c87f0e36b72c12e8ae937cbadca6cf21a34bad
Review URL: http://codereview.chromium.org/2880005
Moves ebuild(s) between stable and live states.
Lists ebuilds currently under development in the testing branch.
Stable ebuilds obtain and build against the last known good commit.
Live ebuilds (9999) perform a 'git clone' during the src_unpack
step to obtain and save the source for development and building.
Example usage:
Sync & build 'ibus-hangul' testing ebuild (9999)
./cros_workon start app-i18n/ibus-hangul
Build 'ibus-hangul' from the last stable commit
./cros_workon stop app-i18n/ibus-hangul
List of ebuilds under development
./cros_workon list
Change-Id: I2ea4babd7597d5cea9ca96419a74152f9f0b23f1
Note: --board must be specified if the --default option
to setup_board was not used.
Review URL: http://codereview.chromium.org/2852019
All tools have been modified to use /usr/bin/cros_workon. So we can
start removing from src/scripts.
For now, print an error so users aren't caught off guard. In a couple
of weeks, I'll remove from src/scripts.
BUG=11507
TEST=none
Change-Id: Ia5f9996bc54fd97b1264cddcf4a0f945fbcb01b4
Review URL: http://codereview.chromium.org/6594132
from within the chroot.
It also fixes a number of style issues.
It changes the meaning of cros_workon "list-all" to list all available
packages, and adds "list-live" to list all live packages.
It changes things that load chromeos-common.sh from the installer to
load it from /usr/lib/installer.
BUG=chromium-os:4230
TEST=synced, rebuilt chroot, made packages, made images, built chrome
from source, and wrote an image to a USB stick.
Review URL: http://codereview.chromium.org/6240018
Change-Id: I90c34420af1a64020402bafef8e9e77f56837c02
Fixes the following issue:
/home/msb/trunk/src/overlays/overlay-x86-generic/make.conf: line 7: prebuilt.conf: No such file or directory
BUG=11513
TEST=Verified that the error goes away.
Change-Id: I5b1dfab55394ba40c02e2a1a2ee7b03a5c4a7941
Review URL: http://codereview.chromium.org/6409031
cros_workon is the only user of cros_workon_common.sh
This is pre-requisite to moving cros_workon into devutils.git
BUG=11507
TEST=Ran ./cros_workon --board x86-generic --all list
Change-Id: I1eab551ab33646360e507328932c151a0d36f50a
Review URL: http://codereview.chromium.org/6347052
Previously, you could not stop working on a package if its ebuild had
been removed. This fixes this issue by skipping canonicalization if the
package name exactly matches a name in the workon file.
BUG=11214
TEST=See below.
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
(cros-chroot) msb@msb ~/trunk/src/scripts $ echo "=foo/bar-9999" >> ~/trunk/.config/cros_workon/x86-generic
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
foo/bar
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic stop foo/bar
!!! No packages matching 'foo/bar'
WARNING: error looking up package foo/bar
ERROR : Error parsing package list
*** I made changes to cros_workon here
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
foo/bar
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic stop foo/bar
INFO : Stopped working on 'foo/bar' for 'x86-generic'
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
Change-Id: Id5cbd2b145b4d0fca96cfb245f1ac99e0b3cbdf3
Review URL: http://codereview.chromium.org/6379006
We stopped using ~ in the workon files many months ago.
BUG=n0ne
TEST=See below.
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic start perf
Please run "repo sync" now.
INFO : Started working on 'dev-util/perf' for 'x86-generic'
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
dev-util/perf
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic stop perf
INFO : Stopped working on 'dev-util/perf' for 'x86-generic'
(cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list
sys-kernel/chromeos-kernel
Change-Id: I61babd89073d749111be7257b2e8491f07ca52f2
Review URL: http://codereview.chromium.org/6268012
Otherwise, you'll duplicate an entry already in the developers
manifest and cause repo to get confused.
BUG=6898
TEST=Verified that local_manifest gets updated when using minilayout.xml
Verified that the local_manifset does not get updated when not.
Change-Id: I67ffc7004a2267d0d5aaa31570ac2bbeaa8f4f96
Review URL: http://codereview.chromium.org/3468009
If the checkout dir doesn't already exist cros_workon start will print
the wrong dir. Fixed by using readlink -m instead.
BUG=none
TEST=Verified that first start is incorrect without this patch
but is fixed with this patch.
Change-Id: I5db29a8c1737dea1dbe4866e18576f67b9355f84
Review URL: http://codereview.chromium.org/3434008
This fixes a bug where user added local_manifest.xml entries
get clobbered.
BUG=5787
TEST=Verified start of various packages works correctly.
Change-Id: I2348dfb1be098b81ede5928426192c655160564d
Review URL: http://codereview.chromium.org/3389013
BUG=none
TEST=Verified that WORKON_FILE is now owned by the user.
Change-Id: I32f05d5de5177756945b6f5bc037a2f738ffffe5
Review URL: http://codereview.chromium.org/3446002
* Modified all workon listing functions to also look for keyword
* Added a fallback to list all workon ebuilds if keyword is not specified, which
is needed for cros_mark_all_as_stable, which does not differentiate between boards.
This, amongst other potential issues, resolves the case when it was possible to
start working on a package not keyworded for the given board, and making
build_packages fail unconditionally.
TEST=below
$ ./cros_workon list --all --board=x86-generic |wc -l
73
$ ./cros_workon list --all --host |wc -l
57
Looking at the lists rather than "|wc -l" looks correct
$ ./cros_mark_all_as_stable
^ Produces satisfactory result
BUG=6700
Change-Id: Ieee92a39febcef5fb95e59cf97b6e63281a7c750
Review URL: http://codereview.chromium.org/3400001
BUG=6325
TEST=cros_workon start and stop for board and host and see it work
Change-Id: Ic0680a273391fdf93b6ebbe0e34497807f31f240
Review URL: http://codereview.chromium.org/3352002
cros_workon would clobber local edits to local_manifest in many cases
This is a quick fix to prevent it. The proper solution is to actually parse
local_manifest as an XML doc and modify the DOM. Not play tricks with grep.
BUG=chromium-os:6272
TEST=Ran cros_workon against missing local_manifest, auto-generated local_manifest, local_manifest with indented tags. local_manifest with multi-line tags and local_manifest with <remote tags.
Review URL: http://codereview.chromium.org/3227006
Change-Id: I008c11a43ac21336575445273453373645f96398
This fixes a case where you can't specify host if you have a
default board set.
BUG=6039
TEST=cros_workon start with --host, --board, both
Change-Id: Iad0d3f646dde10cc4adc4131e93f75fabe92f392
Review URL: http://codereview.chromium.org/3157044
This solves the problem of cros_workon list of packages being clobbered
by a new setup_board.
BUG=5641
TEST=Verified all cases work correctly.
1. Verified that a pre-existing list of workon packages continues to work.
2. Verified that the package.unmask symlink is created correctly.
3. Verified that a new package can be worked on.
4. Verified that an existing package continues to be worked on.
Change-Id: I566ac898ac4f74bdd5beb532c1ef0f70d4c02cec
Review URL: http://codereview.chromium.org/3151039
This is a refactoring change I want to do before I solve the problem
of cros_workon list of packages being clobbered by a new setup_board.
BUG=5641
TEST=Verified all cases work correctly.
1. Verified that a pre-existing list of workon packages continues to work.
2. Verified that the package.keywords symlink is created correctly.
3. Verified that a new package can be worked on.
4. Verified that an existing package continues to be worked on.
Change-Id: I566ac898ac4f74bdd5beb532c1ef0f70d4c02cec
pause
Change-Id: Ie2d96c897da13292f985d87adfaf3a416a614613
Review URL: http://codereview.chromium.org/3143035
* Only run the regenerate once, after start
* Make regenerate preserve old projects from local manifest
* Make pkgname not found a non-fatal error
* Delete misc debug messages
modified: cros_workon
Review URL: http://codereview.chromium.org/3115001
* Bend iterate to accept either list of packages or --all, following the new
semantics
This is a re-upload of the original CL which seems to be broken beyond repair
by the git malfunctions yesterday
Review URL: http://codereview.chromium.org/3040001
* Replaced listall with list --all
* stop/start without arguments will now fail
* stop/start with --all will do just the expected thing
* Rewritten package list decision logic
TBR: msb - already got LGTM, then fixed a comment i noticed
Review URL: http://codereview.chromium.org/2963011
Override locally warn/error functions to not interfere with stdout of canonicalize_name.
Future FIXME in common.sh.
Review URL: http://codereview.chromium.org/2985003
* Warn if user stops working on a package he wasn't working on
* Warn if user starts to work on a package he already is working on
Review URL: http://codereview.chromium.org/2978002
* This fixes the issue, where cros-workon packages have a package.mask set
to prevent upstream ebuilds from rolling in. In general, it brings out the
cavalry for unmasking the live package in every possible way.
Review URL: http://codereview.chromium.org/2934007
We need to be able to use "cros_workon list" in pipelines. Also, would
be nice if the other commands were less verbose. Ideally, they should
die and return a non-zero value.
Also cleaned up the logic in some of the functions. This fixed a couple
of bugs:
1) "cros-workon list" would fail if KEYWORDS_FILE didn't exist
2) "cros-workon start" would fail if KEYWORDS_DIR didn't exit
Change-Id: I76c87f0e36b72c12e8ae937cbadca6cf21a34bad
Review URL: http://codereview.chromium.org/2880005
Moves ebuild(s) between stable and live states.
Lists ebuilds currently under development in the testing branch.
Stable ebuilds obtain and build against the last known good commit.
Live ebuilds (9999) perform a 'git clone' during the src_unpack
step to obtain and save the source for development and building.
Example usage:
Sync & build 'ibus-hangul' testing ebuild (9999)
./cros_workon start app-i18n/ibus-hangul
Build 'ibus-hangul' from the last stable commit
./cros_workon stop app-i18n/ibus-hangul
List of ebuilds under development
./cros_workon list
Change-Id: I2ea4babd7597d5cea9ca96419a74152f9f0b23f1
Note: --board must be specified if the --default option
to setup_board was not used.
Review URL: http://codereview.chromium.org/2852019
