This should fix the failure seen in internal builds
Change-Id: I527acc37597ab9157aedf0330e43f3159ee66fdd
BUG=Should exist
TEST=Ran it locally
TBR=dgarret. Internal builds have been failing on these for a while and no one yelled about it :(
Review URL: http://codereview.chromium.org/6676059
Cleaned up _InsertKeyIntoImage to be more general (able to remove key if no key set). Also made it much more intelligent ... only doing things when it needs to.
Moved mount / unmount code to cros_lib.
BUG=chromium-os:12684
TEST=Ran it a lot ... inspected images after and saw tests pass.
Review URL: http://codereview.chromium.org/6698017
Change-Id: Icd96d1178eeabf45a2d5916fbcab8bf7ffba7e21
Change-Id: I9fed7319609848ba90abfaa147fad85bd4114fdc
BUG=TreeCloser
TEST=Ran it locally in a VM a cpl times.
Review URL: http://codereview.chromium.org/6696002
git config doesn't behave well if there are multiple callers
calling it at the same time. Since this is best effort anyway,
I'm adding an || true so that multithreads calls to this don't
fail.
I removed my previous work around to this since it wasn't generic enough.
Change-Id: I12f2d3faaa745c1ff675a297bb09c567a88aa185
BUG=chromium-os:13070
TEST=Ran it a lot
Review URL: http://codereview.chromium.org/6693001
Change-Id: Ib5617612be38bb6d7dafcb2edab887c998a676ab
BUG=chromium-os:12951
TEST=Ran it with Simple. Saw logs generated (1_update) and in root/dev_server.log. Ran unittests for cros_build_lib.
Review URL: http://codereview.chromium.org/6672007
cros_run_parallel_vm_tests doesn't work unless you pass --use_emerged; there must be some underlying issue with trying to perform multiple run_remote_tests commands at the same time, even on different VMs. So, remove the option and force --use_emerged on the calls to cros_run_vm_test.
BUG=8544
TEST=run two tests in parallel with cros_run_parallel_vm_tests and see that they both complete.
Change-Id: I1152ca3dd7f1de37261da894b9b903c90c2e6524
Review URL: http://codereview.chromium.org/6612058
Not sure how I missed this.
Change-Id: Icd67b6119cbe5ef59bcf2c42784ac8fd011f2ab9
BUG=chromium-os:12953
TEST=Ran it
Review URL: http://codereview.chromium.org/6659009
Sets up dir paths as follows:
test_root/test_name i.e. SimpleUpdate/<num>_stage
For example:
test_root/testNormalUpdateKeepStateful/2_verify/...test_results...
corresponds to the second invocation of verify image. The test
results for this stage are stored here.
This is a predecessor for storing arbitrary logs e.g. update into
this test results root.
Change-Id: I7183420b5dcb0d6971aa508a338c048c3557e359
BUG=chromium-os:12211
TEST=With simple a full vm test suite w/ w/out explicit test root
set.
Review URL: http://codereview.chromium.org/6614029
This CL is a large refactoring that moves the test_harness from using sub-classed classes of au_test into a one where we have the same AU_Test for all test flows but different test workers that operate on different types of machines. Specifically we move the VM / Real-image specific logic into real_au_worker and vm_au_worker. There isn't anything functionally different in this change.
Also, we move the classes into their own modules and clean up use of cros_build_lib to be more stylistically correct.
Change-Id: I3e25141174c3d5ba22962bf94365815e69e5bedf
BUG=chromium-os:11172
TEST=Ran with simple and full w/ w/out delta update payloads and with unittest and without unittest keys. Ran real test using full suite on test device using full update payloads.
Review URL: http://codereview.chromium.org/6597122
When running tests that generate huge amounts of output (like
desktopui_BrowserTest) it would be nice to suppress stdout and stderr
so that the buildbot logs aren't enormous. Adding a --quiet flag that
requires the --results_dir_root flag ensures that we can trim the
output while still ensuring that the useful data is captured.
BUG=8544
TEST=run two tests in parallel with --quiet and --results_dir_root and see that the output is where you expect it
Change-Id: I25c7ad2bc1d017a30df0d1ad4604207443e711d7
Review URL: http://codereview.chromium.org/6602098
BUG=chromium-os:5246
TEST=below, During all tests, the directory platform/dev was manually removed
1) Ran cros_au_test_harness.py and saw it succeed
2) Ran generate_au_zip.py, compared the generated .zip with one before this
patch - they were identical
3) Ran cros_image_to_target.py and saw it succeed
Change-Id: Iab2620245a45442b79ee8369f3af1a3990f4644e
Review URL: http://codereview.chromium.org/6576023
BUG=n0ne
TEST=run the script and see the update go
Change-Id: Ie767edf85876b7864f6425efed1ac554026ecdff
Review URL: http://codereview.chromium.org/6596062
For now arm kernel partitions are not signed. This CL is a transitionsl.
That is, the added flag should be removed after arm verified boot is stable.
To properly create an arm kernel partition, we also need another CL for
vbutil_kernel utility that turns off x86-only modifications on kernel
image. See CL:6538015.
BUG=chromium-os:3790,chromium-os:12352
TEST=see below
Build images for x86 and arm successfully, and notice that load_kernel_test
passes for x86 and signed arm image.
$ build_image --board=tegra2_seaboard --crosbug12352_arm_kernel_signing
$ build_image --board=tegra2_seaboard --nocrosbug12352_arm_kernel_signing
$ build_image --board=x86-generic
Review URL: http://codereview.chromium.org/6538014
Change-Id: I1be381bae2fc367a0603ac2ec67ee70fc9a257e4
Using %U+1 will ensure that we avoid device enumeration issues during recovery mode
boots.
TEST=build_image+dev recovery kernel and boot to it on new cros fw / fixed enumeration problem
used build with mp recovery kernel on cr-48 -> installed then booted fine
used dev recovery kernel on a legacy machine; installed fine, booted fine
tested with cr-48, mp recovery kernel, and noenable_rootfs_verification to ensure /dev/sd%D%P still worked as normal.
Change-Id: I5b1277a47536738a78c18988fd912cc05ebddd4b
BUG=chromium-os:5470
Review URL: http://codereview.chromium.org/6549034
Note: sudo before ifconfig is for running on distros which do not
have /sbin or /usr/sbin in common user's paths, like gentoo.
Change-Id: I85bd379ad059d6ecaa8c11f3167fae27987479dd
BUG=5246
TEST=run cros_au_test_harness and see it not fail
Review URL: http://codereview.chromium.org/6541008
Change-Id: Ia7883c196c688236051a4637561c9a01be5358cb
BUG=TreeCloser
TEST=Ran with simple prefix for x86-generic and no keys
Review URL: http://codereview.chromium.org/6480085
In addition some refactoring to make this cleaner and easier.
Change-Id: I1607700d065c71aff2b2833b10acbd3ebace68ce
BUG=chromium-os:8212
TEST=Ran with Simple ... running now with full
Review URL: http://codereview.chromium.org/6482017
I was getting the error about passing along an empty string argument, and this will fix that.
Change-Id: Iffd05fe570f3a6092bbeee05abf8a1884decd644
BUG=N0ne
TEST=remote testing in progress (no VM testing)
Review URL: http://codereview.chromium.org/6465014
Change-Id: Ia5e0042250da22cebadfd48d143f21597bcada5d
BUG=chromium-os:11716
TEST=Ran vm test and vm update scripts.
Review URL: http://codereview.chromium.org/6413019
This is step 3/3, after cros_overlay_list is added to dev, and
after the ebuilds are updated to install from dev and not
crosutils, then this can go in.
Change-Id: I8ae26938fb14ccf6737acd9ca99b58aaf65a1aca
BUG=chromium-os:11507
TEST=None
Review URL: http://codereview.chromium.org/6392034
Change-Id: I7eb27ac81704de8689a65203a440303a52a01dc2
BUG=chromium-os:11171
TEST=we'll see if things explode
Review URL: http://codereview.chromium.org/6286040
from within the chroot.
It also fixes a number of style issues.
It changes the meaning of cros_workon "list-all" to list all available
packages, and adds "list-live" to list all live packages.
It changes things that load chromeos-common.sh from the installer to
load it from /usr/lib/installer.
BUG=chromium-os:4230
TEST=synced, rebuilt chroot, made packages, made images, built chrome
from source, and wrote an image to a USB stick.
Review URL: http://codereview.chromium.org/6240018
Change-Id: I90c34420af1a64020402bafef8e9e77f56837c02
It's very rarely needed anyway but enter_chroot does everything under the sun.
Avoids:
error: could not lock config file ~/.gitconfig
Change-Id: Ide72b14fd434b182a88d2fc636559b3515905509
BUG=chromium-os:11523
TEST=Ran it ... 10x
Review URL: http://codereview.chromium.org/6312069
This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything. This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly. To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists).
EOM
Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3
BUG=chromium-os:11329
TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome,
and revved packages without error. Doing more testing still.
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8ac0ec
Review URL: http://codereview.chromium.org/6291013
This reverts the commit a8ac0ec8c3.
TBR the x86 PFQ buildbot fails
BUG=chromium-os:11447
TEST=
TBR=sosa
Change-Id: I019de669db13b753365e1208acc9923c4bb5c993
Review URL: http://codereview.chromium.org/6339018
This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything. This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly. To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists).
EOM
Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3
BUG=chromium-os:11329
TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome,
and revved packages without error. Doing more testing still.
Review URL: http://codereview.chromium.org/6291013
Change-Id: I24b498fffb7e7ce54517945730c91fecd1d57586
BUG=chromium-os:10723
TEST=Ran it and killed a test
Review URL: http://codereview.chromium.org/6260023
Change-Id: If4c2852568454c2dccf09b0fc1e180ed228a1bb7
BUG=chromium-os:4230
TEST=run cros_overlay_list from both locations in the chroot and src/scripts outside the chroot.
Review URL: http://codereview.chromium.org/6293021
Change-Id: Ie1ee6554ec0973a85a11c264346295fd27f59ebf
BUG=chromium-os:11329
TEST=Ran with cbuildbot on local system.
Review URL: http://codereview.chromium.org/6384017
It also caches sudo credentials before running jobs (for devs) and
exits if any updater returns an error code != 0 with the output
of pregenerate update
BUG=chromium-os:10723
TEST=Ran it ... killed one pregeneration to make sure it did print + exit
correctly
Review URL: http://codereview.chromium.org/6381013
Change-Id: I04842211e469b3a0022cb53b78efd17fbebe7010
As a warning, this is a pretty big change. At a high-level,
this changes the harness to move the managing of the devserver from
image_to_live into the actual test harness. Paths of the cache locations (for
archive_url) are taken when pre-generating the updates and stored
in a dictionary (maps "path_to_base->path_to_target" (or path for full updates)->
cache paths).
This change also has the tests run in parallel. Because we now start
X number of VM's at once, each VM needs it's own pid file and ssh_port.
This logic was added as well as running the actual tests in parallel.
Change-Id: I1275d79740c50c2a8028489b43dcbbcf5bbd56c4
BUG=chromium-os:10723
TEST=Ran it ... a lot with -q but without a test_prefix (so full test suite).
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c418a8f
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=be787f3
Review URL: http://codereview.chromium.org/6277015
As a warning, this is a pretty big change. At a high-level,
this changes the harness to move the managing of the devserver from
image_to_live into the actual test harness. Paths of the cache locations (for
archive_url) are taken when pre-generating the updates and stored
in a dictionary (maps "path_to_base->path_to_target" (or path for full updates)->
cache paths).
This change also has the tests run in parallel. Because we now start
X number of VM's at once, each VM needs it's own pid file and ssh_port.
This logic was added as well as running the actual tests in parallel.
Change-Id: I1275d79740c50c2a8028489b43dcbbcf5bbd56c4
BUG=chromium-os:10723
TEST=Ran it ... a lot with -q but without a test_prefix (so full test suite).
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c418a8f
Review URL: http://codereview.chromium.org/6277015
As a warning, this is a pretty big change. At a high-level,
this changes the harness to move the managing of the devserver from
image_to_live into the actual test harness. Paths of the cache locations (for
archive_url) are taken when pre-generating the updates and stored
in a dictionary (maps "path_to_base->path_to_target" (or path for full updates)->
cache paths).
This change also has the tests run in parallel. Because we now start
X number of VM's at once, each VM needs it's own pid file and ssh_port.
This logic was added as well as running the actual tests in parallel.
Change-Id: I1275d79740c50c2a8028489b43dcbbcf5bbd56c4
BUG=chromium-os:10723
TEST=Ran it ... a lot with -q but without a test_prefix (so full test suite).
Review URL: http://codereview.chromium.org/6277015
image_to_live runs dev_server with sudo so old cached entries are
owned by root rather than $USER. Change to pre-generate also with
sudo.
Change-Id: I587f15953b37d4de439977e7dbac9fced175c173
BUG=chromium-os:10723
TEST=Ran it
Review URL: http://codereview.chromium.org/6380008
First CL of many. Thought I'd commit this before the others since
it sets stuff up for the other CL's (i.e. Thread Pool).
With this CL, all updates will be pre-generated before the test run.
This should improve some speeds since the two updates will be produced
at the same time rather than at the time of the sequential tests.
Change-Id: Iaf0a06f0d99c31d3d749e478fd2fb6efa0763a28
BUG=chromium-os:10723
TEST=Ran it with -q
Review URL: http://codereview.chromium.org/6264005
build problems, and will give better diagnostics if not.
Change-Id: I2f7a5d9b2e0c63a8189ad212125c7a5c0178c3c4
BUG=10567
TEST=
Review URL: http://codereview.chromium.org/6331007
Change-Id: I046d49c7002586671dc7c6707afeeeb0a0360cd5
BUG=10934
TEST=Ran it with bin/cros_mark_chrome_as_stable tot. Verified output and that it still did the right thing
Review URL: http://codereview.chromium.org/6327002
This cleanup code consolidates parsing of options, removes
globals, cleans up private vs. public functions, removes the backup full update option, and cleans up
docstrings.
Change-Id: I3eba26b3634fd87f4a36f195ab42ec7bd11e963f
BUG=chromium-os:8901
TEST=Ran with prefix SimpleTest and ran whole suite for a vm using my latest built image. Also ran normal update test using latest image against latest dev channel image for mario. Re-tested with new changes after build break.
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2b2d7a1
Review URL: http://codereview.chromium.org/6015013
Clobbering the builder uncovered a bug that was lurking.
Change-Id: Ieb487d2112a7048438943aa96fba23e9c8412a13
BUG=chromium-os:8693
TEST=Running now
Review URL: http://codereview.chromium.org/6050004
This CL also fixes the outstanding issue where to won't report progress in
image_to_live on updates.
Change-Id: I1efaf17f0fd5ebb367ae0872377b4d5d0bf5dbf6
BUG=chromium-os:8680,chromium-os:8901
TEST=Ran it with --debug on the x86 pfq locally.
Review URL: http://codereview.chromium.org/6135002
This reverts commit 2b2d7a1426.
The internal x86 buildbots have been reporting failures from
cros_au_test_harness with every build, starting with the build
that included the change being reverted.
BUG=chromium-os:8901
TEST=None
Review URL: http://codereview.chromium.org/5962019
Change-Id: Iac8c0a13d659f927b3ff61a9a894c10191432e2d
This cleanup code consolidates parsing of options, removes
globals, cleans up private vs. public functions, removes the backup full update option, and cleans up
docstrings.
Change-Id: I3eba26b3634fd87f4a36f195ab42ec7bd11e963f
BUG=chromium-os:8901
TEST=Ran with prefix SimpleTest and ran whole suite for a vm using my latest built image. Also ran normal update test using latest image against latest dev channel image for mario
Review URL: http://codereview.chromium.org/6015013
All blocking reasons for au test harness flakiness have been resolved. Removing try/catch from ctest so that we propagate the correct error code upon exit.
Change-Id: Iee1f09ade37ac7a590c2dbf4ebb96985818f1882
BUG=chromium-os:10434
TEST=Ran ctest unittests.
Review URL: http://codereview.chromium.org/5971009
Also some cleanup and fixing so we don't create unnecessary ebuilds.
I noticed that both the latest release and stable release code
were trying to rev the same branch whenever we moved to a new stable
version. It was harmless before but now that we're pushing this as
stable we want exactly to have the minimum number of revs that are
correct
Change-Id: I9f834d35be8e85c27ab0505ec81637f9a3c27b88
BUG=
TEST=Unittests and mocked in my own directory by creating new stable
branch.
Review URL: http://codereview.chromium.org/6025012
This deals with the condition where on a clobber we don't actually
re-config to use ssh:// until the second run (because git config is
called before we first sync the code).
Change-Id: Icf1a46aced633b570db9d280b10ae6866af04709
BUG=chromium-os:10545
TEST=Unit tests
Review URL: http://codereview.chromium.org/6027006
Change-Id: Ie80843a7b81a37b41ae19fc33244b5c0b8152282
BUG=chromium-os:10434
TEST=Ran it with full au test harness (still running but already showing promise).
Review URL: http://codereview.chromium.org/5988006
We had a major issue because the latest dev channel release pre-dates the virtio change. Because of this, ctest was connecting to update that channel using virtio (which is unsupported for that). This change drops a file telling the vm lib to use e1000 as before.
Also, fixed stateful change logic.
Change-Id: I394a8cece71bdd0d55efa21ba5b6d24804432c6b
BUG=chromium-os:10434
TEST=Ran it with ctest and cros_au_test_harness on images with/without the file.
Review URL: http://codereview.chromium.org/5928005
Since the package.keywords change, it's already built as part of build_packages.
With this change we don't have to needlessly build chrome twice as part of the
pfq.
Change-Id: I8dae745496a5d6f6213663b034ffe8d279d4efd3
BUG=chromium-os:8693
TEST=Ran unittests
Review URL: http://codereview.chromium.org/5973003
Change-Id: I42a6110d41e79bb0ad50817e2e76b06f7973f6c2
BUG=chromium-os:10434
TEST=Ran it with --test_prefix for delay payload test and it succeeded.
Review URL: http://codereview.chromium.org/5877007
Also add some more information output when we detect that there
is nothing to do.
Change-Id: Ia3dcf0d3c276e10d3368d6bd508f3a0d72be79cd
BUG=chromium-os:8693
TEST=Ran it with all 3 paramaters and current overlay.
Review URL: http://codereview.chromium.org/5884004
We also print to /dev/stderr directly to avoid flushing issues which have been occassionally given us broken manifests printed out
Change-Id: I97819bbc31142432aa5ef926f99f2c4f90fd50ef
BUG=chromium-os:9714
TEST=Ran cbuildbot through sync
Review URL: http://codereview.chromium.org/5888003
Change-Id: I2760e33e1473ce04f7adeda39d0db5725eaa81ae
BUG=chromium-os:7072
TEST=Replaced ./build_packages with bash and ran command; valided env var set right.
Review URL: http://codereview.chromium.org/5930002
Change-Id: I32c17e7353b420d7a895acffab4579c9b861095c
BUG=chromium-os:8693
TEST=Ran it with chrome_rev=tot, latest_release and stable_release
Review URL: http://codereview.chromium.org/5854001
This specifically gets the pfq one step closer to being completely ready to rev. We add --noprebuilts for the chrome pfq as its not ready to host prebuilts and instead we push unstable ebuilds. Anush noticed an Anush today where we are revving even when we don't change, and I've addressed this also in this CL.
Specifically:
1) Sort in cbuildbot long options by long format
2) Add --noprebuilts so that the Chrome PFQ can use this for now.
3) Fixed a unittest that had broken in a previous CL for cros_mark_chrome_as_stable.
4) Add ability for chrome to only rev if something really has changed:
-- This means, if the new ebuild either:
-- doesn't have the exact same chrome_version
-- or diff -Bu (actual diff) between last ebuild and new ebuild isn't the same (i.e. detecting a 9999 change or different CROS_SVN_COMMIT)
Change-Id: I9b289c2168d6868299573f5d7c7a676380ee497e
BUG=chromium-os:8693
TEST=Ran unittests (cbuildbot, cros_mark_*) and ran cbuildbot with new chrome pfq items.
Review URL: http://codereview.chromium.org/5783001
Change-Id: I1ac3ed12df00424ba5ba2d1c61fd6fe9716e13b9
BUG=chromium-os:9714
TEST=Ran new unittests as well as ran cbuildbot on local b/cbuild
Review URL: http://codereview.chromium.org/5689003
ability to filter or manipulate content as it's passed through.
Create two example tests using this utility that cause
updates to close early to test resumes, and to add delays
to make sure the update still completes correctly.
What other tests should be created for this?
BUG=chromium-os:8207
TEST=Run by hand
Review URL: http://codereview.chromium.org/5632002
Change-Id: Iefb8c8e223fb2ba6bad2c551f7c4403a0bec6ecf
This allows us to avoid deleting the board and still ensure our packages are
in sync with the full buildbot. This allows us to detect conflicts between
old and new packages.
BUG=chromium-os:10127
TEST=Run cbuildbot.py with emptytree feature forced to on and verify that
build_packages rebuilds all packages. Also run unit tests.
Change-Id: I83e186937e28eef44285724697895a4583910b58
Review URL: http://codereview.chromium.org/5652007
Adds verbose flag to print output while updates are running rather than on error.
Adds test_prefix to specify a prefix of tests you want to run
Flushes stderr more reliably for builders and debugging purposes
Dies when stateful_updates fail
Change-Id: I9e4289deec3688c52b92763eee9334a8868f948e
BUG=chromium-os:6910
TEST=Ran with test_prefix and verbose on and off
Review URL: http://codereview.chromium.org/5573007
Change-Id: I0dda2cfb6e11cb69a6a1a6a4bae478cab78b8947
BUG=chromium-os:8693
TEST=Ran it with cros_mark_chrome with stable_release
TBR=Config change to get chrome builder up.
I started to use /tmp, but it doesn't exist both inside and outside of the chroot. Using a consistent name like this has the advantage that the files will be cached and not redownloaded every time. Well, except on the build servers that wipe the related directories between builds.
Change-Id: I58b42d9f1bd18cc4eb44043ed2436d4ffa482767
BUG=chromium-os:10012
TEST=
Review URL: http://codereview.chromium.org/5597004
Chrome PFQ right now is uploading prebuilts which wasn't meant to happen :(
Change-Id: I502a0621a6c9f655e5a3f890dd79e00652925902
BUG=chromium-os:8693
TEST=Ran cbuildbot with --debug
Review URL: http://codereview.chromium.org/5595004
Also, fixed to honour external FEATURES for the install case.
BUG=n0ne
TEST=Built a kernel with this CL.
Change-Id: I17d50cc382b297766761f12d47a555630fedc016
Review URL: http://codereview.chromium.org/5530004
Change-Id: Ia94f1c983aec533fc2813f9c300266d394b8ee7c
BUG=chromium-os:9946
TEST=Ran ctest and saw through the download and start of the test harness
Review URL: http://codereview.chromium.org/5628002
Add two new tests that test update-engine handling of a corrupted image,
or a truncated image.
BUG=chromium-os:9502
TEST=Ran against Dell L13, Mario
Review URL: http://codereview.chromium.org/5373008
Change-Id: Ie1043004f01131ea837798c06327c486e1901c15
We also fix some of the configs for existing configurations.
Change-Id: I34baa9664ff9e91268c8bac976ab2ab0aee51bfb
BUG=chromium-os:9714
TEST=Running now with cbuildbot x86-generic-pre-flight-queue.
Review URL: http://codereview.chromium.org/5531002
