Commit Graph

15 Commits

Author SHA1 Message Date
Chris Sosa
a33a445a8d Don't mask out errors in cros_mark_as_stable
Change-Id: Ib6722b99008f8515aecc3f27896963291d197947

Review URL: http://codereview.chromium.org/3130031
2010-08-18 18:03:46 -07:00
Chris Sosa
b34604c49a Change default tracking branch for new workflow
As I was writing a doc to describe how to manually uprev I decided
that this was a good time to change the default to be consistent
with the new workflow.

Change-Id: I18932f66004161303f22835ab3b4a8436995300a

Review URL: http://codereview.chromium.org/3125024
2010-08-18 15:12:37 -07:00
Chris Sosa
bb1d3b0076 Don't throw an error if not on stabilizing branch and give more information on exit.
TEST=Ran "cros_mark_as_stable push" with no stabilizing_branch

Review URL: http://codereview.chromium.org/3159010

Change-Id: I31dadc354e224f0f19f0878581204678391ac108
2010-08-12 10:33:53 -07:00
Mandeep Singh Baines
91a5215c0b cros_mark_as_stable: use git push instead of git-cl push
Using git-cl push requires setting up Rietveld authentication
cookies on the bots. This is non-trivial. So instead just use
git. This removes a point of failure.

BUG=5258
TEST=Verified by successfully pushing.

Change-Id: Ic3cd68f2d2a9cc59bbe69270896172ee4a418226

Review URL: http://codereview.chromium.org/3015061
2010-08-06 10:14:03 -07:00
Mandeep Singh Baines
6d523e1a56 cros_mark_as_stable: modify push to use tracking branch
BUG=5258
TEST=Successfully pushed.

Change-Id: I985da7577e88f4a734f8281cae4aafce8dda5933

Review URL: http://codereview.chromium.org/3046051
2010-08-05 11:39:03 -07:00
Mandeep Singh Baines
642382095d cros_mark_as_stable: make it work better in repo
Instead of using master, use the tracking branch.

BUG=5258
TEST=Verified that cleanup now works with repo.

Change-Id: I6e415d9068d54b602238b89c77ba4dbe2f9ff4c6

Review URL: http://codereview.chromium.org/3076035
2010-08-05 11:01:36 -07:00
Mandeep Singh Baines
52ed3f969a cros_mark_as_stable: add a --srcroot command-line option
This is required to enable running cros_mark_as_stable from outside
the chroot.

BUG=5258
TEST=Successfully ran outside the chroot and pushed a change.
All unit tests continue to pass.

Change-Id: Ibd23ace6326b8453c132c416d6db6e42c8c2c239

Review URL: http://codereview.chromium.org/2884060
2010-08-02 11:48:52 -07:00
David James
265588e4f4 Add newline after CROS_WORKON_COMMIT="" line.
Currently, cros_mark_as_stable.py does not add a newline after its
CROS_WORKON_COMMIT="" line. This works fine for 9999 ebuilds that have a newline
after the EAPI="" line, but doesn't work for ebuilds that don't do this.

This should fix the preflight queue build.

TEST=Ran cros_mark_as_stable.py on the update engine and verified that the
     CROS_WORKON_COMMIT="" line was not joined together with the next line.
BUG=none

Review URL: http://codereview.chromium.org/3036029
2010-07-30 10:58:40 -07:00
Chris Sosa
ffff7d76cc Add attempt to update remote and rebase before pushing
TEST=Ran cros_mark_all

Review URL: http://codereview.chromium.org/3066010
2010-07-28 13:21:32 -07:00
Chris Sosa
80a3b2810a Add flag to cros_mark_as_stable to specify tracking_branch.
TEST=Ran using default option and then tried -t chromiumorg/master and
saw a correct failure since I don't have that branch to track against.

Review URL: http://codereview.chromium.org/3032019
2010-07-23 17:00:34 -07:00
Chris Sosa
2566c3fc3c Adding --desc_from_logs option from git cl upload
TEST=Tested git cl upload --desc_from_logs -m "Message" in http://codereview.chromium.org/3027010/show

Review URL: http://codereview.chromium.org/3048005
2010-07-21 12:19:08 -07:00
Chris Sosa
db51f31139 Add wrapper script to get list of updates to pass to stablizing script without other changes
TEST=Ran script

Review URL: http://codereview.chromium.org/3034011
2010-07-19 11:57:31 -07:00
Chris Sosa
92d3779dff Return error when error occurs by raising exception
Review URL: http://codereview.chromium.org/2819052
2010-07-19 11:12:20 -07:00
Chris Sosa
16caaf0c7d Adds remaining functions to cros_mark_as_stable and cleaned up error messaging.
TEST=Tested with following workflow:
cros_mark_as_stable -p 'crash-reporter' -i 'boogabooga' commit
cros_mark_as_stable push
cros_mark_as_stable clean

Also passed in some real options for push_options in a branch that had nothing in it.

Review URL: http://codereview.chromium.org/3017002
2010-07-16 15:04:26 -07:00
Chris Sosa
bebf3798e5 First cut at stable script
TEST=Tested by using crash-reporter and crash_ids set to "12345"

Review URL: http://codereview.chromium.org/2873016
2010-07-13 15:34:11 -07:00