This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything. This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly. To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists).
EOM
Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3
BUG=chromium-os:11329
TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome,
and revved packages without error. Doing more testing still.
Review URL: http://codereview.chromium.org/6291013
Change-Id: I046d49c7002586671dc7c6707afeeeb0a0360cd5
BUG=10934
TEST=Ran it with bin/cros_mark_chrome_as_stable tot. Verified output and that it still did the right thing
Review URL: http://codereview.chromium.org/6327002
Also some cleanup and fixing so we don't create unnecessary ebuilds.
I noticed that both the latest release and stable release code
were trying to rev the same branch whenever we moved to a new stable
version. It was harmless before but now that we're pushing this as
stable we want exactly to have the minimum number of revs that are
correct
Change-Id: I9f834d35be8e85c27ab0505ec81637f9a3c27b88
BUG=
TEST=Unittests and mocked in my own directory by creating new stable
branch.
Review URL: http://codereview.chromium.org/6025012
Also add some more information output when we detect that there
is nothing to do.
Change-Id: Ia3dcf0d3c276e10d3368d6bd508f3a0d72be79cd
BUG=chromium-os:8693
TEST=Ran it with all 3 paramaters and current overlay.
Review URL: http://codereview.chromium.org/5884004
This specifically gets the pfq one step closer to being completely ready to rev. We add --noprebuilts for the chrome pfq as its not ready to host prebuilts and instead we push unstable ebuilds. Anush noticed an Anush today where we are revving even when we don't change, and I've addressed this also in this CL.
Specifically:
1) Sort in cbuildbot long options by long format
2) Add --noprebuilts so that the Chrome PFQ can use this for now.
3) Fixed a unittest that had broken in a previous CL for cros_mark_chrome_as_stable.
4) Add ability for chrome to only rev if something really has changed:
-- This means, if the new ebuild either:
-- doesn't have the exact same chrome_version
-- or diff -Bu (actual diff) between last ebuild and new ebuild isn't the same (i.e. detecting a 9999 change or different CROS_SVN_COMMIT)
Change-Id: I9b289c2168d6868299573f5d7c7a676380ee497e
BUG=chromium-os:8693
TEST=Ran unittests (cbuildbot, cros_mark_*) and ran cbuildbot with new chrome pfq items.
Review URL: http://codereview.chromium.org/5783001
Change-Id: I0dda2cfb6e11cb69a6a1a6a4bae478cab78b8947
BUG=chromium-os:8693
TEST=Ran it with cros_mark_chrome with stable_release
TBR=Config change to get chrome builder up.
Other things:
Removing commit|clean|push command from cros_mark_chrome because it's unnecessary ... I'm just gonna use the same stabilizing branch as the other stable marker, so I can use the same clean / push from the other script. This makes this change fit in much more nicely to cbuildbot.
Other changes:
Add ability for cros_mark_chrome_as_stable to communicate to calling script through stdout.
Make STABLE_BRANCH in cros_mark_as_stable public for above reason.
Removed push_options from cros_mark and accompanying change to cbuildbot as it isn't used anymore.
Made it easier to debug with cbuildbot (I ran cbuildbot A LOT of times to test this change so I felt the pain)...this includes:
- only build when syncing
- allow one to explicitly disable tests
- use dryrun is options.debug is set
Change-Id: I413a2e81a99cdde2e4d9139561cd518245b9b346
BUG=chromium-os:8693
TEST=Ran cbuildbot with --notest --debug --nosync x86-pre-flight and
saw it go through correctly and dryrun push. Ran cbuildbot with same and --chrome_rev=tot. Ran with syncing and running tests too.
Review URL: http://codereview.chromium.org/5154008
Have subsequent review for cbuildbot that calls this for the pfq.
This module has 3 modes ... TOT, latest_release, sticky_release that describe the three different types of revs for chrome we will be supporting.
For tot, we grab the latest svn revision # from the chrome src tree, and rev to the corresponding ebuild i.e. 9.0.553.0_alpha-r1 with CROS_SVN_COMMIT=svn revision number.
For latest_release, we grab the latest release from the releases page, and create an ebuild (or rev a previously existing on with same version) and use the release candidate suffix _rc.
For sticky_release, we use much of the same logic as latest_release, however, we specifically look to rev _rc's in the sticky branch.
This change depends on http://codereview.chromium.org/5172003 for the cros_mark_as_stable changes.
Change-Id: Idc1f4cd905cc1dcb4c44422f6104760077a24b8d
BUG=chromium-os:8693
TEST=Ran cros_mark_as_stable with --packages="chromeos-base/chromeos-chrome" --chrome_version=0.8.65.0 --chrome_revision=67890 commit. Re-ran unit-tests as well (though thinking about adding another unit test for chrome revving)
Review URL: http://codereview.chromium.org/4798001
