This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything. This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly. To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists).
EOM
Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3
BUG=chromium-os:11329
TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome,
and revved packages without error. Doing more testing still.
Review URL: http://codereview.chromium.org/6291013
Change-Id: Ie1ee6554ec0973a85a11c264346295fd27f59ebf
BUG=chromium-os:11329
TEST=Ran with cbuildbot on local system.
Review URL: http://codereview.chromium.org/6384017
This CL also fixes the outstanding issue where to won't report progress in
image_to_live on updates.
Change-Id: I1efaf17f0fd5ebb367ae0872377b4d5d0bf5dbf6
BUG=chromium-os:8680,chromium-os:8901
TEST=Ran it with --debug on the x86 pfq locally.
Review URL: http://codereview.chromium.org/6135002
We also fix some of the configs for existing configurations.
Change-Id: I34baa9664ff9e91268c8bac976ab2ab0aee51bfb
BUG=chromium-os:9714
TEST=Running now with cbuildbot x86-generic-pre-flight-queue.
Review URL: http://codereview.chromium.org/5531002
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=795bd30
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
BUG=chromium-os:8493
TEST=Ran unit tests. Verified that cros_mark_as_stable.py supports
running on just the private or public overlay.
Change-Id: I5e2e8fc5e63b3c93bb688a5ce87233315c0c2d1c
Review URL: http://codereview.chromium.org/4250001
Right now we're leaving error_ok=True until the tests are shown to work on builder.
Change-Id: I6b8c690a0da30948389fd4312032c78d87115364
BUG=6906
TEST=Ran through it locally.
Review URL: http://codereview.chromium.org/3591002
BUG=5468
TEST=Ran default and ran x86-generic. Took board values from master.cfg in buildbot
Review URL: http://codereview.chromium.org/3200006
Change-Id: I1d3e4216dc9ca9af0d9e8c1bfffabffa87f89b04
TEST=Ran several non-checked in unit tests (will check in later) and tested
with cbuildbot as it is now.
BUG=5989
Review URL: http://codereview.chromium.org/3165052
Change-Id: I867a597b34bbf63261b9d19b57cef9631100c339
TEST=Ran locally outside of chroot. Required change to remove Exception OSError as
e because "as" is a Python 2.6'ism
Review URL: http://codereview.chromium.org/3146001