If you source this script inside chroot, you would get <tab> completion for the --board= argument for some build scripts.
For example,
. bash_completion
./build_image --board=x<tab>
may complete to
./build_image --board=x86-generic
if x86-generic is the only available board starting with "x". If not, it will list available boards with the given prefix.
We could extend this to work with setup_board and other scripts. Also, it may be nice to extend it to work outside chroot.
Does it make sense to make this part of the regular dev chroot by default? If so, not sure what the best way to do that. Maybe install this as a hard-host-depends and source it from the chroot user .bashrc?
Review URL: http://codereview.chromium.org/652129
Remove make_local_repo stage as it's not used by either build process.
Make portage build the default (--noportage still builds the old way).
Also add total time to build. A run of sync_build_test without args
on my machine takes 2:20min. Defaulting to --jobs=1 due to
instability reports.
Review URL: http://codereview.chromium.org/646015
ecee13e13945c7df79e397012054206cac6cb2f0 back to the previous revision.
This new file should be identical to the one at
ce18a0349a88ffbe01a2e88526aeb271b54dec60
Review URL: http://codereview.chromium.org/646057
1. work with the new portage build system. Yes, cross compiling works.
2. work with new upstream changes to build a single or a subset of site test which specified from command line.
I will update the how-to document after all code checked in.
Please also refer to change from 582012 which had been included here and 582012 will be abandoned after this CL checked in.
Review URL: http://codereview.chromium.org/596110
The original pattern "chrome-chromeos/chrome*" was loose enough
to include "chromeos/libcros.so" if it's present. The file should
not be included in chrome-chromeos.zip file, which is used to build
the chromeos-chrome deb package, since libcros.so is provided by
the chromeos-libcros deb package.
I had "chromium/src/out/Release/chromeos/libcros.so" to run the
Chromium OS version of Chromium browser locally with libcros.so
enabled.
TEST=manually:
% cd ../build/x86/local_assets
% unzip -l chrome-chromeos.zip > before
... made this change ...
% cd ../build/x86/local_assets
unzip -l chrome-chromeos.zip > after
% diff -u before after
--- before 2010-01-22 13:53:39.361522119 +0900
+++ after 2010-01-22 13:54:52.117212719 +0900
@@ -2,8 +2,6 @@
Length Date Time Name
--------- ---------- ----- ----
12584626 2010-01-22 13:46 chrome-chromeos/candidate_window
- 0 2010-01-22 13:13 chrome-chromeos/chromeos/
- 432316 2010-01-22 13:13 chrome-chromeos/chromeos/libcros.so
4850 2009-12-09 15:37 chrome-chromeos/product_logo_48.png
54594 2010-01-22 13:46 chrome-chromeos/session
0 2010-01-18 11:52 chrome-chromeos/resources/
@@ -220,4 +218,4 @@
127262 2010-01-21 14:05 chrome-chromeos/locales/ro.pak
112422 2010-01-21 14:05 chrome-chromeos/locales/en-GB.pak
--------- -------
- 66476904 218 files
+ 66044588 216 files
Review URL: http://codereview.chromium.org/552101
Another CL is coming to automatically add depot_tools to the PATH
inside the chroot. It's in a different repo.
Review URL: http://codereview.chromium.org/605016
If one passes --chrome_root=.../path/to/chrome_root/outside/chroot to
enter_chroot.sh once, enter_chroot will make a note inside the croot
and mount it on all subsequent calls to enter_chroot, even if the
argument is not passed again. If ever enter_chroot can't find the
proper dir, it deletes any stored note.
chrome_root must contain a "src" subdirectory.
Review URL: http://codereview.chromium.org/596102
This is a short term fix for machines that can't boot a kernel from
the root file system of an SDCard.
This issue depends on issue 602027.
Review URL: http://codereview.chromium.org/600074
Change enter_chroot.sh to keep a list of open PIDs (enter_chroot.sh
instances) in chroot/var/lock, and use flock on that file to support
atomic operations to it.
When entering chroot, append the PID to the lock file.
When exiting chroot, clear out current PID and any dead
PIDs/duplicates. If the lock file is empty, only then clean up the
mounts.
Note that I have a little bit of code duplication: the number 200,
which is a manually numbered fd in bash, seemed impossible to place
inside a variable. If you know how to do it, please let me know.
Review URL: http://codereview.chromium.org/584010
this is necessary for portage-based builds which change the
chroot. You must pass --chroot to the run_remote_tests in this
case.
Review URL: http://codereview.chromium.org/588010
Don't punish the good people trying to write python-only autotests by
requiring them to sit through a long build_autotest run to test
every change. run_remote_tests and build_autotest both update
the chroot copy now.
Review URL: http://codereview.chromium.org/578027
so that tests have access to the source/build trees during setup.
For example, gl_APICheck requires access to OpenGL headers.
Review URL: http://codereview.chromium.org/555111
