There were two bugs:
1) The test [ ${ARCH} -eq "arm" ] was wrong because -eq is a
numeric comparison operator, not legal on strings.
2) Variable ${ARCH} was used before set.
The code change includes comment changes to clarify the reasons for
the code, and a future-proofing logic change.
Change-Id: I63f502cc33cf8a9a441b4b305fc49ed57d0a55b1
BUG=None
TEST=build_image --factory_install, and boot the resulting image
Review URL: http://codereview.chromium.org/6905119
It seems like we are seeing whacky errors with sys.stderr
dying when trying to print out a process and its exception.
I think controlling how the output is printed in RunCommand
is better than passing it with the exception.
Change-Id: I3711575e5d9e710c3aea6ff19d43d149fd83f44c
BUG=chromium-os:14398
TEST=Ran it with au_test_harness
Review URL: http://codereview.chromium.org/6902129
On x86, booting factory install shim on SD card needs to have the kernel
initrmafs enabled. But on ARM, booting factory install image on network does
not needs initramfs.
TEST=build_image --factory_install
BUG=chromium-os:13211
Change-Id: Id008a3bfaf4f17772e04f02d18844dd09b33fbe1
R=rongchang@chromium.org
Review URL: http://codereview.chromium.org/6901047
verity_depth must be 0. No other values are supported. So changing the
default to 0.
Needs to go in before:
http://codereview.chromium.org/6901005
BUG=chromium-os:14357
TEST=Ran build_image, mod_image_for_test.sh, mod_image_for_recovery.sh
chromeos-install, and image_to_live.sh.
Change-Id: I6208327d9ce68c9ba56d78e99bc145e34bee9d1d
R=wad@chromium.org,scottz@chromium.org,gauravsh@chromium.org
Review URL: http://codereview.chromium.org/6902061
This CL depends on http://codereview.chromium.org/6765018 which adds fbconsole
USE flag.
Change-Id: I159680e2cd53b6493545f6c0b1caaa8a7e833cb3
BUG=chromium-os:13607
TEST=run mod_image_for_recovery.sh and boot to recovery image to see messages
showed on framebuffer console.
Review URL: http://codereview.chromium.org/6814041
This reverts commit dc2cb4b8f6efbde3b7527def32147d80663cd2dd.
This commit is reverted because it is not needed.
R=rongchang@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6882115
Change-Id: If21b788986c878c5d0e3e29487b6d58b86532775
Auto-detect use of verity, and if verity is not used, copy over modules and firmware.
Also, while I was at it, I added a --noreboot argument.
And also copy over vmlinux.uimg on ARM if on non-verity.
Change-Id: Ida9d3fbf4f342db65ebd0002a8b1a528440ea7fe
BUG=chromium-os:13321
TEST=Build kernel, try updating on x86 and ARM, both with and without verity
Review URL: http://codereview.chromium.org/6881029
Verity only supports a depth of 0. Passing anything other than 0 will
cause a verity failure.
BUG=14314
TEST=Verified that verity does not fail when do depth is passed.
Before this change, verity would fail with the error message
reported in the bug.
Change-Id: I68495c4486284744ee0779b6c9cdc0ef214519c7
R=gauravsh@google.com,scottz@google.com,drewry@google.com
Review URL: http://codereview.chromium.org/6873134
Change-Id: If46fd1558a00498ce4721dd756532e916f49bc19
BUG=chromium-os:12950
TEST=Ran with autestharness and ran unittests.
Review URL: http://codereview.chromium.org/6877015
Also includes a style nit fix: don't quote arguments to numeric
comparison test operators.
BUG=chromium-os:13582
TEST=setup_board --force && build_packages && build_image; boot the result
Review URL: http://codereview.chromium.org/6801027
Change-Id: I689ca9697a05cf93a789fde1242fb2fa50f21612
It makes debugging system boot issues harder, so let's re-enable console
output for a while. It will be quieted down again later.
Change-Id: I7c543c09818c0152470c9f5e54d36c614d05bf3a
BUG=chrome-os-partner:3199
TEST=Boot a system, check for console output before login screen
Review URL: http://codereview.chromium.org/6801045
Plan is to eventually deprecate depth as a configurable parameter.
depth=0 means compute the depth based on a regular trie with a
single block of hashes at the root node.
BUG=chromium-os:9752
TEST=platform_DMVerity
Change-Id: I5c5f1b1f2c2079d7e1ef6c7a55c859b463a59aee
R=wad@chromium.org,taysom@chromium.org,ups@chromium.org,gauravsh@chromium.org,jimherbert@chromium.org
Review URL: http://codereview.chromium.org/6810006
Currently used for resolv.conf and hosts, because these files can
change during the lifetime of a chroot, for example on computers
with more dynamic network (laptops).
While this creates a persistent process in the background for the
sole purpose of syncing files, the performance impact is negligible.
BUG=12316
TEST=below
1) enter_chroot once+quit, many times + quit, verify correct exit
behaviour
2) enter_chroot, modify host resolv.conf, see chroot being updated
Change-Id: I26573570c027acc2c214a00838a6f982a7585b13
R=robotboy@chromium.org,dparker@chromium.org,sosa@chromium.org
Review URL: http://codereview.chromium.org/6720005
This fixes an issue where passing USE= to build_packages would always
cause build_image to fail.
BUG=none
TEST=create a USE-inconsistent package, run build_image, observe it working
Change-Id: Id9eb3891d9c292423c837a0d097a33155f03b794
R=davidjames@chromium.org,kliegs@chromium.org
Review URL: http://codereview.chromium.org/6677163
we don't want any possibility for firmware to be changed in factory setup
BUG=none
TEST=build_image; image_to_usb --factory
Change-Id: Ibef767ea621193afb7fbca5ea96120a506891dcb
R=nsanders@chromium.org
Review URL: http://codereview.chromium.org/6764010
To get best factory test image performance, we should disable update engine.
BUG=chromium-os:13613
TEST=image_to_usb --factory --to=FACTORY
then verified /etc/init/update-engine.conf is disabled.
Change-Id: Ifb7b6c821f434ee68625ffea0eb7907c38d77315
R=nsanders@chromium.org
Review URL: http://codereview.chromium.org/6759023
BUG=none
TEST=Run ChromeOS under qemu, the screen should be 1280x1024 not 800x600.
Review URL: http://codereview.chromium.org/6768009
Change-Id: I9a73025244a85d3b07e98136b373b00bb40cd9dd
to the output of images uploaded to Google Storage. This is a stop gap solution
until I migrate all builders to uploading with the new structure.
BUG=NA
TEST=Ran on a finished buildbot to ensure the proper behaviour
Review URL: http://codereview.chromium.org/6749018
Change-Id: I52901180e962c463bdaacbc573f93700cf9ab4bd
BUG=None
TEST=Run Chrome OS in qemu, check that the mouse is back.
Review URL: http://codereview.chromium.org/6749020
Moved this incorrectly. This is only used by
cros_vm_lib.sh and therefore should stay wherever it is.
Change-Id: Ib9cc02479f53184a85345288f6abd8fedffb563e
BUG=chromium-os:13948
TEST=NA
Review URL: http://codereview.chromium.org/6747015
Change-Id: Id0fa142e0e4705e0ec742dd2c926687140507dc4
BUG=chromium-os:13498
TEST=Ran other CL's without this file.
Review URL: http://codereview.chromium.org/6713120
BUG=chromium-os:13221
TEST=Run build_images without ext2 loaded
Specifying a filesystem type explicitly for ext* filesystems will avoid
weird fallbacks like mounting ext2 filesystem as ext3 or even ext4.
Instead it attempts to autoload the given filesystem as a module if
available or fail right away.
Change-Id: I6be7f3f994babd8efc8eda97ea9c802e04d98be6
R=dgarret@chromium.org,sosa@chromium.org
Review URL: http://codereview.chromium.org/6696092
For run_remote_tests this required "fixing" restart_in_chroot if required. Right now that script ->only<- works if its run on a scripts being called from src/scripts. This change makes it more generic by doing this for any script called from within our source tree.
I borrow reinterpret_path_for_chroot from image_to_live. Other CL to remove it from there.
Change-Id: If717beccd777ac178366d58b91521b9a62d55d85
BUG=chromium-os:11172
TEST=Ran them
Review URL: http://codereview.chromium.org/6730012
Change-Id: I8233aaab234eb6a3a7948abb1d311c4c9c162190
BUG=chromium-os:11172
TEST=Ran from new symlinks from previous locations.
Review URL: http://codereview.chromium.org/6731005
This also deletes the code from mod_for_factory_scripts/200patchInitScript
that created the files that now come from the new package.
BUG=chromium-os:13258
TEST=Build and boot a factory test image
Review URL: http://codereview.chromium.org/6665048
Change-Id: I115d1a2e3afe2fdefc0e07247b21b67e0cf9cc62
BUG=none
TEST=build and boot a factory test image
Review URL: http://codereview.chromium.org/6713049
Change-Id: Ia0c4c9780fccc91c4464acf84ca4c0327b8ea7bd
This CL removes --factory_install support from mod_image_for_test.
Factory install images are no longer produced using mod_image_for_test.
BUG=chromium-os:12899
TEST=manual
Change-Id: Ia6d6cac07f710cb82473fd696c2717ee660543b6
Review URL: http://codereview.chromium.org/6688015
The dev install shim is deprecated. This CL removes --dev_install
support from build_image.
This is part of a larger rewrite of build_image to allow it to be the
single script from which all image types are generated.
BUG=chromium-os:12899
TEST=manual
Change-Id: Ic3a49f0d476d198f81001a05c75f24f16bc640c0
Review URL: http://codereview.chromium.org/6694042
This should fix the failure seen in internal builds
Change-Id: I527acc37597ab9157aedf0330e43f3159ee66fdd
BUG=Should exist
TEST=Ran it locally
TBR=dgarret. Internal builds have been failing on these for a while and no one yelled about it :(
Review URL: http://codereview.chromium.org/6676059
