Commit Graph

5 Commits

Author SHA1 Message Date
Brian Harring
d5d5dbffa1 Fix/standardize exiting if common.sh can't be found
The problem here is that most were doing their exiting w/in a subshell;
exit within a subshell kills the subshell, not the parent.  Not all scripts
were using set -e (which would pick up the failing subshell); as such
just rewriting them to remove the potential via eliminateing the subshelling.

Beyond that, removed a couple of custom (working, although non-standard)
approaches, and removed a duplicate common.sh sourc'ing w/in mk_memento_images.sh

TEST=force 'find_common_sh' to fail, note the scripts fails to exit
BUG=none

Change-Id: Ia1108a091a6399ad6aedd3cade4a107f4411686c
Reviewed-on: http://gerrit.chromium.org/gerrit/3905
Reviewed-by: Brian Harring <ferringb@chromium.org>
Tested-by: Brian Harring <ferringb@chromium.org>
2011-07-22 12:06:59 -07:00
Nick Sanders
fa28c16842 Add u-boot env editor to factory bundle
BUG=chrome-os-partner:4606
TEST=no

Change-Id: Ie3f60a33a1bef9513ec8da8a170697eecb752a68
Reviewed-on: http://gerrit.chromium.org/gerrit/4296
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Nick Sanders <nsanders@chromium.org>
2011-07-20 20:47:56 -07:00
Elly Jones
c871ba2df4 make_netboot: Fix syntax error.
http://chromeos-botmaster.mtv.corp.google.com:8026/builders/tegra2_dev-board-binary/builds/199/steps/cbuildbot/logs/stdio

BUG=None
TEST=Adhoc
Ran it. No error.

Change-Id: I7a6a2745bbde4a773b9c3a79df9ca135af823149
Signed-off-by: Elly Jones <ellyjones@chromium.org>
Reviewed-on: http://gerrit.chromium.org/gerrit/3017
Reviewed-by: Grant Grundler <grundler@chromium.org>
2011-06-22 12:18:57 -07:00
Grant Grundler
7c4328a65f Fix ARM generic build: no u-boot/legacy_image.bin built
Additional fix needed on top of nsanders commit from yesterday:
    http://gerrit.chromium.org/gerrit/#change,2028

ARM generic doesn't build chromeos-u-boot and thus has no u-boot
directory in the $SYSROOT.

BUG=chromium-os:16833
TEST=archive_build.sh

Change-Id: Ic8422419779dca1965c6832a4a0bd73078945e69
Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-on: http://gerrit.chromium.org/gerrit/3001
Reviewed-by: Anton Staaf <robotboy@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
2011-06-22 11:10:17 -07:00
Nick Sanders
119677f3b9 Add netboot output to factory bundle
* kernel, initrd, legacy firmware

BUG=chrome-os-partner:3667
TEST=archive_build.sh

Change-Id: I54b11067624e1c626cb6f059d4b8a52602c5837c
Reviewed-on: http://gerrit.chromium.org/gerrit/2028
Tested-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Rong Chang <rongchang@chromium.org>
2011-06-21 17:13:19 -07:00