What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
When you pass '--foo="bar baz"' to a script, the argument is literally
passed as "bar baz", with the quotes. So we need to not add unnecessary
quotes in there.
When enter_chroot.sh parses arguments, it actually removes the quotes
for you, and splits up arguments. As a result, it may actually
be necessary to (1) use the above broken syntax when you call scripts
using enter_chroot.sh; but (2) don't use that syntax when calling
scripts without enter_chroot.sh. That's a broken situation, so I've
added a TODO for that. I've also added more warnings to
cros_mark_as_stable.py so that it's easier to debug when it doesn't
work.
BUG=chromium-os:8633
TEST=Ran unit tests. Planning to watch TOT buildbot post-commit to make sure behavior is right.
Change-Id: Ia1a0e60153fec60cb7ed4db2da128ffd9ae81e23
Review URL: http://codereview.chromium.org/4385002
BUG=chromium-os:8493
TEST=Ran unit tests. Verified that cros_mark_as_stable.py supports
running on just the private or public overlay.
Change-Id: I5e2e8fc5e63b3c93bb688a5ce87233315c0c2d1c
Review URL: http://codereview.chromium.org/4250001
Currently cros/master is used for the tracking branch in the preflight
rinse step. This is wrong if --tracking_branch is specified
differently in the command-line options to cbuildbot.py.
BUG=none
TEST=Ran unit tests
Change-Id: Id4fb989863ae11f57889faf6a8d8b043b81da58e
Review URL: http://codereview.chromium.org/4104005
Change-Id: Ic6d4a79a7ab58b8043805a6b826f251faa9f3a6c
BUG=
TEST=Running now (adding unit tests as well)
Review URL: http://codereview.chromium.org/4062003
Change-Id: If7db175f828fccdd4caa342a0370e842503f16dc
BUG=8015
TEST=Ran it with cbuildbot with/without --clobber with/without old state.
Review URL: http://codereview.chromium.org/4007005
What's new?
- cros_mark_all_as_stable is now in Python and has unit tests.
- We now detect and report coding errors that can cause incorrect behavior.
E.g., if 9999 ebuild or stable ebuild can't be found, we report a hard
failure so that developers will know about the problem.
- We now check that git hashes we report actually match up with the
right repository.
- Unified diff of changes are now printed to stdout, so that developers
can see a list of the changes and debug any problems.
- cros_mark_all_as_stable now takes 2.5 seconds to run.
BUG=chromium-os:7795
TEST=Manually examined diff output from run of cros_mark_all_as_stable
on full repository.
Change-Id: I762597c9b94e5f8e8171b83c966ad54e21a65c1b
Review URL: http://codereview.chromium.org/3798003
Change-Id: Idda6c7287cdb1863eb4abe8c56da2e763e9fe777
BUG=7926
TEST=Ran with --debug and verified I didn't push a change.
Review URL: http://codereview.chromium.org/3880002
src.chromium.org is no longer supported for git operations.
BUG=chromium-os:7830
TEST=none
Change-Id: Ia7cd9ff76625441f16d20d2f9a8e0f752dca0586
Review URL: http://codereview.chromium.org/3782010
This reverts commit 365d4b0cc8.
Fix preflight breakage, this seems like the most possible cause. Will recommit if not.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3767012
Change-Id: I93fe463fec77c445e7ff0ec86db25d5ef2997ad7
We always want to re-build packages we are revving, however, if the last
build succeeds in building but fails tests, we have a bad local cache that
has revved packages. This avoids this issue by working on all packages we
are revving.
Change-Id: I3bd7463a4090b1f007d09be81bdf65657bd9c3f3
BUG=7589
TEST=Ran it with cbuildbot.
Review URL: http://codereview.chromium.org/3745006
Right now we're leaving error_ok=True until the tests are shown to work on builder.
Change-Id: I6b8c690a0da30948389fd4312032c78d87115364
BUG=6906
TEST=Ran through it locally.
Review URL: http://codereview.chromium.org/3591002
If cbuildbot.py printed out a manifest when it syncs, it would make it possible
for us to reproduce the build later by looking at what revisions the buildbot
was using. This is useful for debugging.
Change-Id: I186ad01eef0090b6c618cb7ad583085197474018
BUG=chromium-os:7069
TEST=Ran test suite with 3441027 patched in (Sosa's patch that fixes an unrelated issue with the unit tests)
Review URL: http://codereview.chromium.org/3461028
repo sync --jobs doesn't check for errors, so we shouldn't use it in
automated scripts. repo --trace is needed so that we can diagnose
whether git is hanging.
BUG=chromium-os:7048, chromium-os:6774
TEST=Ran test suite
Change-Id: I9e68cfffe841a231f5fabef951ea2d45b81c1d5e
Review URL: http://codereview.chromium.org/3419024
Change-Id: Id81fe4e7bd9cae7a51a45b6ea8a535c4ea9430f8
BUG=
TEST=Ran locally on top of previous build area.
Review URL: http://codereview.chromium.org/3337007
BUG=5468
TEST=Ran default and ran x86-generic. Took board values from master.cfg in buildbot
Review URL: http://codereview.chromium.org/3200006
Change-Id: I1d3e4216dc9ca9af0d9e8c1bfffabffa87f89b04
TEST=Ran several non-checked in unit tests (will check in later) and tested
with cbuildbot as it is now.
BUG=5989
Review URL: http://codereview.chromium.org/3165052
Change-Id: I867a597b34bbf63261b9d19b57cef9631100c339
The buildbot drops a source stamp (repo1.git@commit1 repo2.git@commit2 ...).
If CBuildbot finds the source stamp, it uses it and revs only those packages.
If this file is either missing or set to "None", it assumes a Force Build
has been pressed and keeps the old behavior (attempts to mark all).
TEST=Ran with 3 states of revisions file.
BUG=5006
Review URL: http://codereview.chromium.org/3163030
Change-Id: I226fd3bec642224b31ce51eee34d028043964943
TEST=Ran script and re-ran cbuildbot to completion of sync.
Change-Id: I31fddca6f720fecb461a96c1ffa54d4923b3c1c4
Review URL: http://codereview.chromium.org/3166019
Ugh, it worked on my machine because of my .ssh/config but need to
explicitly specify port for it to work on buildbot.
TBR=sosa
BUG=5532
TEST=This change was in the previous location of cbuilbot.py and working
correctly.
Change-Id: Id53a76bcb5d43c37ac725267864048d833f5a6ee
Review URL: http://codereview.chromium.org/3144005
TEST=Ran locally outside of chroot. Required change to remove Exception OSError as
e because "as" is a Python 2.6'ism
Review URL: http://codereview.chromium.org/3146001
