RunCommand should only pass in stdin, stdout, and stderr to processes,
not other file handles. Fixing this prevents issues where child
processes can cause the parent to hang by forgetting to close the
file handle when launching daemons.
BUG=chromium-os:18104
TEST=Buildbot run with smoke suite. Unit tests.
Change-Id: Ib85095e1fb592ef05a972a5412348363049e6d86
Reviewed-on: http://gerrit.chromium.org/gerrit/4673
Reviewed-by: Brian Harring <ferringb@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: David James <davidjames@chromium.org>
It seems like we are seeing whacky errors with sys.stderr
dying when trying to print out a process and its exception.
I think controlling how the output is printed in RunCommand
is better than passing it with the exception.
Change-Id: I3711575e5d9e710c3aea6ff19d43d149fd83f44c
BUG=chromium-os:14398
TEST=Ran it with au_test_harness
Review URL: http://codereview.chromium.org/6902129
Change-Id: If46fd1558a00498ce4721dd756532e916f49bc19
BUG=chromium-os:12950
TEST=Ran with autestharness and ran unittests.
Review URL: http://codereview.chromium.org/6877015
Cleaned up _InsertKeyIntoImage to be more general (able to remove key if no key set). Also made it much more intelligent ... only doing things when it needs to.
Moved mount / unmount code to cros_lib.
BUG=chromium-os:12684
TEST=Ran it a lot ... inspected images after and saw tests pass.
Review URL: http://codereview.chromium.org/6698017
Change-Id: Icd96d1178eeabf45a2d5916fbcab8bf7ffba7e21
Change-Id: Ib5617612be38bb6d7dafcb2edab887c998a676ab
BUG=chromium-os:12951
TEST=Ran it with Simple. Saw logs generated (1_update) and in root/dev_server.log. Ran unittests for cros_build_lib.
Review URL: http://codereview.chromium.org/6672007
This reintroduces the change after commit 3635aaa55e, which reverted 01c8423582.
BUG=chromium-os:11717
TEST=Ran new unit tests, and did full build.
Review URL: http://codereview.chromium.org/6579048
Change-Id: I598e459ddaa156af47d47d0482cac16ce44f07a4
extra noise in the final exception output.
This change stops catching and rethrowing the same exception, and generally
makes the RunCommand slightly more readable (if longer).
Some unit tests are added, but they only test RunCommand, and not all options
to RunCommand.
BUG=chromium-os:11717
TEST=Manual, and new lib/cros_build_lib_unittest
Review URL: http://codereview.chromium.org/6576016
Change-Id: Ibe9b13ff302621e93196008f86914cb65a232d61
Note: sudo before ifconfig is for running on distros which do not
have /sbin or /usr/sbin in common user's paths, like gentoo.
Change-Id: I85bd379ad059d6ecaa8c11f3167fae27987479dd
BUG=5246
TEST=run cros_au_test_harness and see it not fail
Review URL: http://codereview.chromium.org/6541008
As a warning, this is a pretty big change. At a high-level,
this changes the harness to move the managing of the devserver from
image_to_live into the actual test harness. Paths of the cache locations (for
archive_url) are taken when pre-generating the updates and stored
in a dictionary (maps "path_to_base->path_to_target" (or path for full updates)->
cache paths).
This change also has the tests run in parallel. Because we now start
X number of VM's at once, each VM needs it's own pid file and ssh_port.
This logic was added as well as running the actual tests in parallel.
Change-Id: I1275d79740c50c2a8028489b43dcbbcf5bbd56c4
BUG=chromium-os:10723
TEST=Ran it ... a lot with -q but without a test_prefix (so full test suite).
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c418a8f
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=be787f3
Review URL: http://codereview.chromium.org/6277015
As a warning, this is a pretty big change. At a high-level,
this changes the harness to move the managing of the devserver from
image_to_live into the actual test harness. Paths of the cache locations (for
archive_url) are taken when pre-generating the updates and stored
in a dictionary (maps "path_to_base->path_to_target" (or path for full updates)->
cache paths).
This change also has the tests run in parallel. Because we now start
X number of VM's at once, each VM needs it's own pid file and ssh_port.
This logic was added as well as running the actual tests in parallel.
Change-Id: I1275d79740c50c2a8028489b43dcbbcf5bbd56c4
BUG=chromium-os:10723
TEST=Ran it ... a lot with -q but without a test_prefix (so full test suite).
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c418a8f
Review URL: http://codereview.chromium.org/6277015
As a warning, this is a pretty big change. At a high-level,
this changes the harness to move the managing of the devserver from
image_to_live into the actual test harness. Paths of the cache locations (for
archive_url) are taken when pre-generating the updates and stored
in a dictionary (maps "path_to_base->path_to_target" (or path for full updates)->
cache paths).
This change also has the tests run in parallel. Because we now start
X number of VM's at once, each VM needs it's own pid file and ssh_port.
This logic was added as well as running the actual tests in parallel.
Change-Id: I1275d79740c50c2a8028489b43dcbbcf5bbd56c4
BUG=chromium-os:10723
TEST=Ran it ... a lot with -q but without a test_prefix (so full test suite).
Review URL: http://codereview.chromium.org/6277015
dump output until after the command has finished, so not useful for
following 'live'.
Change-Id: Ia8562f5e6f8d7ed8af7e188faa68f5cdbba487c6
BUG=chromium-os:11164
TEST=None
Review URL: http://codereview.chromium.org/6296013
fix, but it leads to better error messages from ctest.
Change-Id: I624ad805ef037b022e6e67b56f0ed10ca05fe325
BUG=11096
TEST=Test currently in progress.
Review URL: http://codereview.chromium.org/6257007
Adds verbose flag to print output while updates are running rather than on error.
Adds test_prefix to specify a prefix of tests you want to run
Flushes stderr more reliably for builders and debugging purposes
Dies when stateful_updates fail
Change-Id: I9e4289deec3688c52b92763eee9334a8868f948e
BUG=chromium-os:6910
TEST=Ran with test_prefix and verbose on and off
Review URL: http://codereview.chromium.org/5573007
It's like RunCommand, but you can run the command, capture it's error code and output together.
This is to support tests that need to capture output of image_to_live, and to know if it succeeded.
Change-Id: If674b6d79697c0f0b5c96be9fc83adbed9b9893e
BUG=chromium-os:9502
TEST=Ran by hand
Review URL: http://codereview.chromium.org/5339006
This bug doesn't affect production but affects the unit tests.
BUG=chromium-os:9201
TEST=Confirmed this fixes an infinite loop in the unit tests, and that
cbuildbot.py still works.
Change-Id: I1a56b92d8229110c84cebbe877e55fb99f053212
Review URL: http://codereview.chromium.org/5025002
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=795bd30
Review URL: http://codereview.chromium.org/4442001
Change-Id: I4afa86fa7a6b772124de56114910a1ca5e3d4511
BUG=
TEST=Ran through update harness code and ran loman.
Review URL: http://codereview.chromium.org/3612004
Right now we're leaving error_ok=True until the tests are shown to work on builder.
Change-Id: I6b8c690a0da30948389fd4312032c78d87115364
BUG=6906
TEST=Ran through it locally.
Review URL: http://codereview.chromium.org/3591002
