Commit Graph

14 Commits

Author SHA1 Message Date
Chris Sosa
9ef57d996b Enter chroot can return an error code on cleanup. We make cleanup best effort
Review URL: http://codereview.chromium.org/1158006
2010-03-23 11:15:45 -07:00
Andrew de los Reyes
e8b6315eee enter_chroot: allow depot_tools to fail to mount
Review URL: http://codereview.chromium.org/601082
2010-02-16 14:18:34 -08:00
Andrew de los Reyes
c1e8d2728f enter_choot: fix breakage some people ran into
Review URL: http://codereview.chromium.org/593102
2010-02-13 12:39:21 -08:00
Andrew de los Reyes
2832fe84e1 enter chroot: permit chrome_root to contain symlink
Review URL: http://codereview.chromium.org/596108
2010-02-12 23:47:01 -08:00
Andrew de los Reyes
5d0248feb8 enter_chroot: bind mount depot_tools if present outside chroot.
Another CL is coming to automatically add depot_tools to the PATH
inside the chroot. It's in a different repo.

Review URL: http://codereview.chromium.org/605016
2010-02-12 16:12:31 -08:00
Andrew de los Reyes
6d0ca16277 Enter_chroot: Mount chrome browser source inside chroot.
If one passes --chrome_root=.../path/to/chrome_root/outside/chroot to
enter_chroot.sh once, enter_chroot will make a note inside the croot
and mount it on all subsequent calls to enter_chroot, even if the
argument is not passed again. If ever enter_chroot can't find the
proper dir, it deletes any stored note.

chrome_root must contain a "src" subdirectory.

Review URL: http://codereview.chromium.org/596102
2010-02-12 14:36:08 -08:00
Andrew de los Reyes
c9317eac02 Chroot: allow multiple simultaneous entry.
Change enter_chroot.sh to keep a list of open PIDs (enter_chroot.sh
instances) in chroot/var/lock, and use flock on that file to support
atomic operations to it.

When entering chroot, append the PID to the lock file.

When exiting chroot, clear out current PID and any dead
PIDs/duplicates. If the lock file is empty, only then clean up the
mounts.

Note that I have a little bit of code duplication: the number 200,
which is a manually numbered fd in bash, seemed impossible to place
inside a variable. If you know how to do it, please let me know.

Review URL: http://codereview.chromium.org/584010
2010-02-10 13:16:36 -08:00
Colin Watson
3a3566b51f Reduce noise in buildbot logs
Set LANG=C also when providing a command to enter_chroot.sh. Should make
buildbot logs quite a bit shorter.

Review URL: http://codereview.chromium.org/521053
2010-01-07 07:36:32 +00:00
David McMahon
857dbb59c0 Add --official_build option, and skip checking HEAD against origin/HEAD for official builds.
Review URL: http://codereview.chromium.org/486002
2009-12-09 18:21:05 -08:00
David McMahon
03aeb20079 Revert versioning to original (odd=trunk/dev, even=release) style.
Add handling for third type - continuous builds and (label) appropriately.
2009-12-08 16:30:21 -08:00
derat@google.com
4e7a92bd48 build: Update build_image.sh for non-~/chromeos setups.
BUG=659

Review URL: http://codereview.chromium.org/431001

git-svn-id: svn://chrome-svn/chromeos/trunk@305 06c00378-0e64-4dae-be16-12b19f9950a1
2009-11-21 23:44:14 +00:00
derat@google.com
86dcc8e68b build: Make enter_chroot.sh fail if run as root.
BUG=684

Review URL: http://codereview.chromium.org/429006

git-svn-id: svn://chrome-svn/chromeos/trunk@304 06c00378-0e64-4dae-be16-12b19f9950a1
2009-11-21 19:49:49 +00:00
djmm@google.com
7ba1563d79 Use git for "revision" if svn is unavailable.
Review URL: http://chromereview.prom.corp.google.com/1186033

git-svn-id: svn://chrome-svn/chromeos/trunk@219 06c00378-0e64-4dae-be16-12b19f9950a1
2009-11-13 00:00:16 +00:00
rspangler@google.com
d74220d772 Start copying over source.
git-svn-id: svn://chrome-svn/chromeos/trunk@4 06c00378-0e64-4dae-be16-12b19f9950a1
2009-10-09 20:56:14 +00:00