Commit Graph

4592 Commits

Author SHA1 Message Date
Tan Gao
2fcfbbe8cf replace mod_image_for_recovery.sh with new --recovery flag to build_image
Change-Id: I407d39ca461bbe609812e2b3bd2a51e67e331659

TEST=manually built a recovery image (non-dev mode, --withnodev) and verified
chromeos-install completed successfully when installing from USB to target HD

Review URL: http://codereview.chromium.org/3174005
2010-08-16 11:25:51 -07:00
Raymes Khoury
cbf5b86dcb Moved running unit tests to occur after building Chrome browser in sync_build_test.sh.
Also added back check to test whether --nounittest is passed in.

Review URL: http://codereview.chromium.org/3031056
2010-08-16 11:20:25 -07:00
Ken Mixter
0d11563bfd Move leave_core where other similar files exist
BUG=5696

Review URL: http://codereview.chromium.org/3109014
2010-08-13 15:51:07 -07:00
Darin Petkov
4faf84bc14 cros_workon bash completion -- handle flags anywhere.
BUG=5623
TEST=tried ./cros_workon with various arguments

Change-Id: Ia1a48b73e4f55006fd767a7d15b8e38e467aa23e

Review URL: http://codereview.chromium.org/3152018
2010-08-13 15:32:50 -07:00
Darin Petkov
593e796dfa Implement basic tab-completion for cros_workon arguments.
Takes effect when you sync/re-enter chroot.

Also, minor non-exhaustive style cleanup of existing code.

BUG=5623
TEST=tried tab completion with ./cros_workon and various options

Change-Id: I46d2eb29205a3a4ce350b82e7eced7f2069095ca

Review URL: http://codereview.chromium.org/3185003
2010-08-13 14:45:02 -07:00
David James
8055a1fc25 Don't pass on --jobs to individual emerge processes in parallel_emerge.
When we pass on --jobs to individual emerge processes, it causes them
to hide their output. This makes it harder to debug why they are
failing or hanging. Example: http://goo.gl/C6Ru

TEST=Made sure that output is shown by emerge processes when --jobs is used.
BUG=chromium-os:5684

Review URL: http://codereview.chromium.org/3168012
2010-08-13 13:35:56 -07:00
J. Richard Barnette
5c2290cda4 Print a newline after reading password in cros_download
BUG=none
TEST=./cros_download_latest_image

Review URL: http://codereview.chromium.org/3151013
2010-08-13 11:52:13 -07:00
David James
a8ddd0bfdb Remove ltp from set of tests to build.
The ltp tests don't pass, and take a long time to build. Once they pass,
it'll make sense to add them back. But otherwise, no point waiting for their
long build process to complete.

BUG=none
TEST=Run build_packages --withautotest

Review URL: http://codereview.chromium.org/3121010
2010-08-12 17:34:57 -07:00
David James
f4170f83c3 Move printing of output to a separate thread.
This should cut several minutes off the time for build_packages --nousepkg
--showoutput.

TEST=Ran build_packages --showoutput, verified output.
BUG=chromium-os:5647

Review URL: http://codereview.chromium.org/3106008
2010-08-12 17:34:06 -07:00
Ken Mixter
bc69d7bae4 Utility to generate minidump symbols for developer diagnostics
BUG=4882, 4886

Review URL: http://codereview.chromium.org/2825054
2010-08-12 17:03:47 -07:00
Ken Mixter
1334788772 Leave core files around for developers to inspect.
BUG=5358

Review URL: http://codereview.chromium.org/3170008
2010-08-12 16:51:52 -07:00
Chris Sosa
bb1d3b0076 Don't throw an error if not on stabilizing branch and give more information on exit.
TEST=Ran "cros_mark_as_stable push" with no stabilizing_branch

Review URL: http://codereview.chromium.org/3159010

Change-Id: I31dadc354e224f0f19f0878581204678391ac108
2010-08-12 10:33:53 -07:00
Chris Sosa
82047a9d48 Add some information to cbuildbot output.
TEST=Ran cbuildbot locally.

Review URL: http://codereview.chromium.org/3137006

Change-Id: I8c80334480a4a2e4bb32234d323c0b129bed4692
2010-08-12 10:07:35 -07:00
Ken Mixter
6cb2462132 Use generate_test_report to generate the run_remote_test report.
BUG=5359

Review URL: http://codereview.chromium.org/3164008
2010-08-11 17:23:40 -07:00
Chris Sosa
cf7e8ff5b7 Exit cleanly if nothing to mark
TEST=Ran cros_mark_all_as_stable with packages and without packages to
mark and had them both succeed with exit code 0.
BUG=5486

Review URL: http://codereview.chromium.org/3179004
2010-08-11 16:23:33 -07:00
David James
71fa14b024 Don't install autotest bits to the image.
Autotest installs stuff to the image via ssh, so there's no need to include
all of this stuff to the image. This saves disk space. Note that
/usr/local/autotest-chrome is currently already excluded from the image
because of a hack in the chrome ebuild, and that /usr/local/autotest is
usually also excluded from the image because autotest is not included
as a dependency of any packages that are installed.

In the factory setting, it looks like the factory has its own code for
installing autotests via rsync. Presumbably, if the factory tests are
managing the autotest directly, they won't want emerge mucking with the
directory as well on the image. Currently, emerge doesn't muck with the same
directory, but we probably want to ensure that it doesn't start doing that in
future to ensure sanity.

TEST=Built images. Modded for factory test. Verified that (a) build directory contains autotests, (b) regular images do not contain autotests; and (c) images modified for factory test do contain autotests

Review URL: http://codereview.chromium.org/3124010
2010-08-11 16:15:16 -07:00
Mandeep Singh Baines
6718164717 cbuildbot: use correct port
Ugh, it worked on my machine because of my .ssh/config but need to
explicitly specify port for it to work on buildbot.

TBR=sosa
BUG=5532
TEST=This change was in the previous location of cbuilbot.py and working
correctly.

Change-Id: Id53a76bcb5d43c37ac725267864048d833f5a6ee

Review URL: http://codereview.chromium.org/3144005
2010-08-11 10:29:56 -07:00
Zdenek Behan
077af11ba9 cros_workon: check for existence of local manifest before cat
* Fixes a dumb error message

	modified:   cros_workon

Review URL: http://codereview.chromium.org/3129008
2010-08-10 18:27:25 -07:00
David James
a1c046d469 Tell emerge to stop beeping at us.
By default, emerge will pause and beep when it has messages that it wants the
user to see. This beeping is not useful during a parallel merge, so we turn it
off.

TEST=Ran parallel_emerge udev. It stopped beeping and completed faster.
BUG=none

Review URL: http://codereview.chromium.org/3080005
2010-08-10 12:43:25 -07:00
Chris Sosa
cd358fe1cb Adding cbuildbot to cros_utils. Leaving old version in repo until buildbot changes over.
TEST=Ran locally outside of chroot.  Required change to remove Exception OSError as
e because "as" is a Python 2.6'ism

Review URL: http://codereview.chromium.org/3146001
2010-08-09 19:33:22 -07:00
Zdenek Behan
5f66b8667a cros_workon: misc fixes to manifest re-generation
* Only run the regenerate once, after start
* Make regenerate preserve old projects from local manifest
* Make pkgname not found a non-fatal error
* Delete misc debug messages

	modified:   cros_workon

Review URL: http://codereview.chromium.org/3115001
2010-08-09 18:03:01 -07:00
Andrew de los Reyes
b20bc30d4c generate_update_payload script: script to generate full/delta update payloads
This script wraps the old memento udpate generator and the new delta
updater. It will also generate new-style full updates soon, which are
full updates that use the delta-update format, when that code is ready.

BUG=5248
TEST=ran local script to do full/delta update

Review URL: http://codereview.chromium.org/2873082
2010-08-09 15:55:11 -07:00
Chris Masone
626ced822c Fake authserver SSL certs now valid for 21 days, instead of 2
BUG=5130
TEST=create a test image, boot it on a device, and run "sudo nsscertutil -d "sql:/etc/fake_root_ca/nssdb" -L -n FakeCert | less".  Look at the section of the output marked "Validity:" and make sure the Not Before and Not After sections indicate dates that are 3 weeks apart

Change-Id: I67cf7e71027147f83c1bc916557bc06ef66fa0e0

Review URL: http://codereview.chromium.org/3075025
2010-08-09 14:41:17 -07:00
Olof Johansson
6d49138087 fix print of total elapsed time
BUG=none
TEST=run build_image, happen to finish on a time with less than 10 seconds in it, watch the missing 0-padding

Review URL: http://codereview.chromium.org/3050047
2010-08-09 16:05:50 -05:00
David McMahon
4c5d388cb5 Created branch 0.8.64.B. Update CHROMEOS_VERSION_BRANCH=65
Change-Id: Ideee46febd9f00abc5b404372920aafbebe82994
2010-08-09 13:55:16 -07:00
Zdenek Behan
19294323c6 cros_workon: refactor local manifest creation, kill duplicate entries (repo doesn't like them)
modified:   cros_workon

Review URL: http://codereview.chromium.org/3076046
2010-08-09 13:51:25 -07:00
robotboy
508d08fdfb Add check for spaces in board and variant names.
Review URL: http://codereview.chromium.org/3084028
2010-08-09 13:29:30 -07:00
Nick Sanders
bfbb74f667 allow firmware fetch
Review URL: http://codereview.chromium.org/3013066
2010-08-09 12:14:56 -07:00
Olof Johansson
7e9226f08a parallel_emerge: catch 404 errors when getting packages
BUG=none
TEST=run build_packages on --board=tegra2_dev-board-opengl right now, since binhost hasn't been populated yet.

Review URL: http://codereview.chromium.org/3035058
2010-08-09 11:11:13 -07:00
Paul Stewart
072ea6f30e Remove .svn files from the client directory to save space
Copying the .ssh directories within client takes up O(2n) space in
the stateful partition

BUG=none
TEST=reran mod_image_for_test.sh

Review URL: http://codereview.chromium.org/2832079
2010-08-07 17:38:35 -07:00
David James
733fc865db Add --show-output option to parallel_emerge which prints output from jobs.
Also update parallel_emerge to print output in general if you hit
CTRL-C or if a job is running for more than an hour. Also cleanup exit
handling so that emerge exits a bit more cleanly, and so that we don't
hang if emerge throws an Exception.

BUG=none
TEST=Ran ./parallel_emerge --show-output -uDNve chromeos

Review URL: http://codereview.chromium.org/3010056
2010-08-06 17:18:57 -07:00
Zdenek Behan
638976a796 cros_workon: when finding the ebuild path, look for the 9999 ebuild
modified:   cros_workon

Review URL: http://codereview.chromium.org/3015063
2010-08-06 15:13:03 -07:00
Zdenek Behan
d119ee8337 cros_mark_all_as_stable: blacklist autotest,autotest-tests
Review URL: http://codereview.chromium.org/2878086
2010-08-06 14:31:32 -07:00
Zdenek Behan
a203b46c48 cros_mark_all_as_stable: introduce blacklist, set the initial blacklist source as ./
* This allows to block a list of ebuilds from being uprevved by the PFB
* With little modification, there could be a GUI which allows people to manage
a blacklist on the server, with stating the reason
(ex.: autotest-tests - $me, creating the ebuild, unstable for now)

	modified:   cros_mark_all_as_stable

TEST=
1) create a blacklist:
chromeos-base/autotest
chromeos-base/autotest-tests
2) run ./cros_mark_all_as_stable --board=x86-generic
...
INFO   : chromeos-base/autotest blacklisted, skipping
INFO   : chromeos-base/autotest-tests blacklisted, skipping
...

Review URL: http://codereview.chromium.org/3076038
2010-08-06 14:18:32 -07:00
Zdenek Behan
8817081418 autotest_run: kill the destructive stuff that's pwning the autotest installation
* Also changes the way how "new workflow" is detected in run_remote_tests.sh

	modified:   autotest_run.sh
	modified:   run_remote_tests.sh

Review URL: http://codereview.chromium.org/3048051
2010-08-06 11:26:23 -07:00
Todd Broch
2c9e3cf673 disable chrontel server for factory test (will start via deps/factory/startx.sh) directly
BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3087012
2010-08-06 10:52:03 -07:00
Mandeep Singh Baines
91a5215c0b cros_mark_as_stable: use git push instead of git-cl push
Using git-cl push requires setting up Rietveld authentication
cookies on the bots. This is non-trivial. So instead just use
git. This removes a point of failure.

BUG=5258
TEST=Verified by successfully pushing.

Change-Id: Ic3cd68f2d2a9cc59bbe69270896172ee4a418226

Review URL: http://codereview.chromium.org/3015061
2010-08-06 10:14:03 -07:00
Tan Gao
0d5f948934 clean up install_gpt args to use number of sectors
Change-Id: I7d17db3cb522a52ec2dac688f4bf83fb5ae6a2d1

related CL: http://codereview.chromium.org/3031049/show

TEST=(1)Manually built an image using build_image script, which exercised "build_gpt.sh"; (2) manually built a Qemu VM image using "image_to_vm.sh" and verified the VM is bootable (up to login screen); (3) manually built a dev recovery image using "mod_image_for_dev_recovery.sh" and verified image functions properly for dev recovery purpose

Review URL: http://codereview.chromium.org/3050039
2010-08-06 08:28:20 -07:00
Tan Gao
5e7a52f6b2 remove unnecessary call to make_image_bootable for dev recovery
Change-Id: I43f88cbe4df74e254299a95c5e1b62a300230385

Undo part of commit by drewry
http://chromiumos-git/?p=crosutils.git;a=commit;h=7ab698d713bcad066f0ee0469fbbcaa274411d08

mod_image_for_dev_recovery.sh modifies a dev install shim image (already
bootable) by altering content of its stateful partition. The result image does
NOT need to be made bootable again.

TEST=manually built a dev recovery image (based on a factory install shim) and
verified recovery functionality on agz device with cros fw

Review URL: http://codereview.chromium.org/3074037
2010-08-05 17:25:54 -07:00
Will Drewry
6793ba78ca build_image,cros_make_image_bootable: fix missing arm argument
Adds arm_extra_bootargs to boot.desc and to cros_make_image_bootable.

TEST=tegra2 dev-board build_packages, build_image --fast worked
BUG=broken tree

Change-Id: Ifdfeda66f1eb5e5b1e618706eeba269f31fa9913

Review URL: http://codereview.chromium.org/3069031
2010-08-05 16:17:46 -05:00
Will Drewry
7ab698d713 build_image, mod_image_for_*: break out make_image_bootable
Breaks make_image_bootable out of build_image into a separate
script.  In addition, it make a helper .sh in the OUTPUT_DIR
to let make_image_bootable be re-run on an image with the same
arguments that were passed in via build_image.

This change also removes the use of the boot/ directory in
OUTPUT_DIR.

TEST=build_image verified; image_to_usb --test_image; booted l13
           build_image; image_to_vm; qemu booted
           build_image verified; image_to_usb; booted l13
BUG=chromium-os:5081

Review URL: http://codereview.chromium.org/3066037

Change-Id: I627d678089aa71c353347f387ad5b14063fd4e7b
2010-08-05 13:57:52 -05:00
Mandeep Singh Baines
6d523e1a56 cros_mark_as_stable: modify push to use tracking branch
BUG=5258
TEST=Successfully pushed.

Change-Id: I985da7577e88f4a734f8281cae4aafce8dda5933

Review URL: http://codereview.chromium.org/3046051
2010-08-05 11:39:03 -07:00
J. Richard Barnette
138904ef93 Fix gsdcurl to correctly URL-quote a password passed via GSDCURL_PASSWORD
BUG=none
TEST=use this script with a (correct) password that includes punctuation such as one of these: $&+,/:;=?@

Review URL: http://codereview.chromium.org/3058046
2010-08-05 11:03:37 -07:00
Mandeep Singh Baines
642382095d cros_mark_as_stable: make it work better in repo
Instead of using master, use the tracking branch.

BUG=5258
TEST=Verified that cleanup now works with repo.

Change-Id: I6e415d9068d54b602238b89c77ba4dbe2f9ff4c6

Review URL: http://codereview.chromium.org/3076035
2010-08-05 11:01:36 -07:00
Mandeep Singh Baines
92e674967d Add gflags.py
This is a temporary hack to allow cros_mark_as_stable to work outside
the chroot. Eventually, we'll re-write the code to use optparse.

BUG=5412
TEST=Verified the cros_mark_as_stable now works outside the chroot.

Change-Id: Ife1f7aeadb70ba004d3928a9c71d6e95c042833d

Review URL: http://codereview.chromium.org/3037046
2010-08-05 10:37:17 -07:00
Mandeep Singh Baines
b4b6a260f2 cros_mark_all_as_stable: add tracking branch support
The tracking branch is different between repo and gclient.

BUG=5258
TEST=Verifed the tracking branching option is correctly propagated.

Change-Id: I9e5b8cb68d335c47e47499b4964dcaa83ac26f76

Review URL: http://codereview.chromium.org/3037045
2010-08-05 10:36:52 -07:00
Tom Wai-Hong Tam
2272ae5ce2 Handle Qual DBs based on default board name.
All Qual DBs may be existed in the same directory of hardware_Components (overlaid internal git). So, if QUALDB is not specified, first check the existence of DBs matched the board name. Then remove other DBs not belonging to the board.

TEST=build_packages, build_image, image_to_usb

Review URL: http://codereview.chromium.org/3032036
2010-08-05 14:19:45 +08:00
Olof Johansson
58f25cca72 Create a latest link to point at newest image
build_image creates it after a successful build, and get_latest_image
can use it if it exists. Fall back to old behavior for now when there
are directories without a link.

BUG=none
TEST=Try building an image, check link. Rebuild, check new link.

Review URL: http://codereview.chromium.org/3014051
2010-08-04 21:18:49 -07:00
David James
77e8092a9c Update parallel_emerge to use no-env-update feature which skips env_update.
Currently, our build occasionally fails with errors about about symlinks
already existing. This usually only slows down the build, because we have
retries, but it would be good to fix the problem.

This patch updates parallel_emerge to use the no-env-update feature for cross-
compiles. This feature skips the env_update step, which isn't thread-safe, and
isn't necessary for when we're cross-compiling and don't actually need to run
the binaries. Instead we run the env_update at the end, avoiding a thread-safety
issue.

TEST=Ran full build --nousepkg with env_update occuring at end.
BUG=chromium-os:5382

Review URL: http://codereview.chromium.org/3034051
2010-08-04 17:26:28 -07:00
David James
56e08b2424 Fix --onlydeps flag.
When --onlydeps is specified, we don't want to merge packages that were
specified on the command-line. Previously, it threw an exception in this
case because it couldn't find the command-line packages in the list of
installed packages.

TEST=Run ./parallel_emerge --onlydeps autotest, and make sure it
     doesn't crash.
     Run ./parallel_emerge --board=x86-generic  -po chromeos power_manager and make sure it does emerge power_manager, and doesn't crash.
BUG=none

Review URL: http://codereview.chromium.org/2868094
2010-08-04 17:21:12 -07:00