The one symlink should be update instead of new links being created.
BUG=12233
TEST=Ran run_remote_test.sh many time and verified that the link is updated.
Change-Id: I63f325e03439e5c922e9fe2300444193146182f9
Review URL: http://codereview.chromium.org/6576051
BUG=chromium-os:6840
TEST=Build and install Chrome OS image, no issues observed
Change-Id: I24ea3a96490a81c8926852eff6d2451e57e196f7
Review URL: http://codereview.chromium.org/6546045
If no board is specified for run remote tests,
learn board from device under test instead of using
default board.
BUG=none
TEST= ./run_remote_tests.sh without --board. Verify detects board and
deploys appropriate version for that board.
./run_remote_test.sh with --board x86-mario. Verify that it deploys
that specific board, regardless of target.
Change-Id: I6e71f0f1bf4b2bcfcd3430b29adc16531c6a8c81
Signed-off-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Chris Sosa <sosa@chromium.org>
Review URL: http://codereview.chromium.org/6580017
Developers may want to run their own factory test UI after finishing the
Google official one, so the "factory" test should be stoppable.
BUG=chrome-os-partner:2456
TEST=build a factory image, install and start factory testing UI,
then switch to VT2, login and type: "initctl stop factory"
the screen should switch to a virtual terminal (VT2) without
hanging / reboot.
Change-Id: I6a9d1c951d48d448f5c83c5f645ea531e8fd1499
Review URL: http://codereview.chromium.org/6567004
For now arm kernel partitions are not signed. This CL is a transitionsl.
That is, the added flag should be removed after arm verified boot is stable.
To properly create an arm kernel partition, we also need another CL for
vbutil_kernel utility that turns off x86-only modifications on kernel
image. See CL:6538015.
BUG=chromium-os:3790,chromium-os:12352
TEST=see below
Build images for x86 and arm successfully, and notice that load_kernel_test
passes for x86 and signed arm image.
$ build_image --board=tegra2_seaboard --crosbug12352_arm_kernel_signing
$ build_image --board=tegra2_seaboard --nocrosbug12352_arm_kernel_signing
$ build_image --board=x86-generic
Review URL: http://codereview.chromium.org/6538014
Change-Id: I1be381bae2fc367a0603ac2ec67ee70fc9a257e4
extra noise in the final exception output.
This change stops catching and rethrowing the same exception, and generally
makes the RunCommand slightly more readable (if longer).
Some unit tests are added, but they only test RunCommand, and not all options
to RunCommand.
BUG=chromium-os:11717
TEST=Manual, and new lib/cros_build_lib_unittest
Review URL: http://codereview.chromium.org/6576016
Change-Id: Ibe9b13ff302621e93196008f86914cb65a232d61
The xorg-server ebuild creates /usr/share/portage on the rootfs partition. This
breaks build_image which wants to point the same directory at the stateful
partition.
To work around this we just link to make.globals directly. This workaround fixes
gmerge but doesn't address the problem that there might be more files inside
/usr/share/portage. A better fix should be addressed as part of
crosbug.com/11502
BUG=chromium-os:12441
TEST=Run build_image and verify /usr/share/portage/config/make.globals points to
/usr/local/share/portage/config/make.globals and that the latter also
exists.
Review URL: http://codereview.chromium.org/6583001
Change-Id: I52fd9d34bf29573fbf6ca013ba49d1c8608e066d
Using %U+1 will ensure that we avoid device enumeration issues during recovery mode
boots.
TEST=build_image+dev recovery kernel and boot to it on new cros fw / fixed enumeration problem
used build with mp recovery kernel on cr-48 -> installed then booted fine
used dev recovery kernel on a legacy machine; installed fine, booted fine
tested with cr-48, mp recovery kernel, and noenable_rootfs_verification to ensure /dev/sd%D%P still worked as normal.
Change-Id: I5b1277a47536738a78c18988fd912cc05ebddd4b
BUG=chromium-os:5470
Review URL: http://codereview.chromium.org/6549034
Having this symlink is extremely useful if your running the same
test over and over again.
BUG=n0ne
TEST=Verified that the symlink is there.
Change-Id: I625a48ce4348082db05951ffd67929687ad461cc
Review URL: http://codereview.chromium.org/6543021
Note: sudo before ifconfig is for running on distros which do not
have /sbin or /usr/sbin in common user's paths, like gentoo.
Change-Id: I85bd379ad059d6ecaa8c11f3167fae27987479dd
BUG=5246
TEST=run cros_au_test_harness and see it not fail
Review URL: http://codereview.chromium.org/6541008
This addresses the case where we don't have chromiumos_image.bin but don't
actually need it since we've previously generated a test image.
Change-Id: Ie7be0165e0f68bbd9d34156b55e17d971cb86fa9
BUG=chromium-os:12268
TEST=Ran it with --noinplace and missing dev image.
Review URL: http://codereview.chromium.org/6538031
Because this scripts changes directory, it's possible for relative
paths to be incorrect when read by the actual dev server. This fixes
the issue by prepending the current working directory to relative path
args.
BUG=chromium-os:12122
TEST=tested relative paths w/ dev server
Change-Id: I7a85e4af5df291ec78afb0f2c1580855c38a258e
Review URL: http://codereview.chromium.org/6525011
This temporary hack is intended to provide to developers a smooth transition to
the new crypted password file location.
BUG=chromium-os:11664
TEST=build_image
Change-Id: I34383f6e08ee8db53e407b30df604c403c72b5eb
Review URL: http://codereview.chromium.org/6539019
Enhancement 1: Fail if we run outside the chroot, because otherwise
you have to wait 10 minutes to find out your results won't be gathered.
Enhancement 2: Print the location of the log output file, for the
benefits of looky-loos who want to see what's going on.
Change-Id: I388b1855c5b6bb20b0efffbf0babd1f60caf7bcb
BUG=None
TEST=run the script per instructions, and see the new output
TEST=run the script outside the chroot, and see it fail immediately
Review URL: http://codereview.chromium.org/6519039
This is necessary so that the baselayout ebuild can be
changed to set /etc/passwd and /etc/shadow appropriately.
A previous attempt to do this through an environment
variable in make.conf.user failed because pkg_postinst
from binary packages run in their prebuilt environment
(and, thus, are not picking the user specific variables).
BUG=chromium-os:11664
TEST=ran set_shared_user_password.sh multiple times, observed
/etc/shared_user_passwd.txt and shared_user_passwd.txt getting updated.
Change-Id: I23b77c7417db0fd18b251f7cca62027813b182a8
Review URL: http://codereview.chromium.org/6534003
Change-Id: I776b3b92c81f6e00b179766fd16a322af4c0379c
BUG=chromium-os:12212
TEST=Ran against test logs for failed build.
Review URL: http://codereview.chromium.org/6534006
As titled, similarly to http://codereview.chromium.org/6508003/, crashes are now detected in Autotest runs and will result in an error being thrown when detected.
The error thrown during crash detection will cause smoke failures and close the tree.
Change-Id: I403833c99c6c37f971bdbe962655ead10a1014c5
BUG=chromium-os:12100
TEST=Ran bvt, smoke with good and bad builds through run_remote_tests.
Review URL: http://codereview.chromium.org/6526031
BUG=chromium-os:11944
TEST=the correct test for this is a complete rebuild; I have this running, but it's going to take a little while. I have tested this on the specific cases of ssh_auth_sock and .subversion
Change-Id: I61723356c58bfb7c2090e950208b8a6ab8fa2fc9
Review URL: http://codereview.chromium.org/6519022
Also refactors some cut-and-paste code
Fix: makes mountpoint for subversion directory
BUG=chromium-os:11944 chromium-os:12058
TEST=enter_chroot.sh with and without another enter_chroot running. Note that there are 0 or 1 mounts of the /tmp/ssh-.... directory. Check that /proc,/sys,/dev,$SSH_AUTH_SOCK,/dev/pts,/home/${USER}/trunk,/home/${USER}/.subversion are all mounted. Test that subversion mountpoint is created
Change-Id: I9dada6f7f98d263345af29a5734c1c70709f6a1e
Review URL: http://codereview.chromium.org/6498001
Review URL: http://codereview.chromium.org/6525020
The factory tests should not use default results folder, otherwise a developer
running autotests by command line would corrupt the whole factory test
framework.
Since tools/autotest cannot support additional parameters and our state (to
continue) is clear, the command is also changed to directly invoke bin/autotest.
BUG=chrome-os-partner:2378
TEST=manually patched into a factory test device and verified factory
UI works at new boot and a reboot.
Change-Id: I9f6ef31114bdda740319072c6f9ac624f6850b95
Review URL: http://codereview.chromium.org/6529046
Change-Id: Ia7883c196c688236051a4637561c9a01be5358cb
BUG=TreeCloser
TEST=Ran with simple prefix for x86-generic and no keys
Review URL: http://codereview.chromium.org/6480085
In addition some refactoring to make this cleaner and easier.
Change-Id: I1607700d065c71aff2b2833b10acbd3ebace68ce
BUG=chromium-os:8212
TEST=Ran with Simple ... running now with full
Review URL: http://codereview.chromium.org/6482017
BUG=chromium-os:4230
TEST=grep for references to old parallel_emerge location
Change-Id: I3238e719e01df57648d3d91c0dfd7c37f7a934ee
Review URL: http://codereview.chromium.org/6246058
Also refactors some cut-and-paste code
BUG=11944
TEST=enter_chroot.sh with and without another enter_chroot running. Note that there are 0 or 1 mounts of the /tmp/ssh-.... directory. Check that /proc,/sys,/dev,$SSH_AUTH_SOCK,/dev/pts,/home/${USER}/trunk,/home/${USER}/.subversion are all mounted
Change-Id: I9dada6f7f98d263345af29a5734c1c70709f6a1e
Review URL: http://codereview.chromium.org/6498001
Change-Id: I6593336a52b7298bd358f3e55531b2e6a9e6dff1
BUG=chromium-os:11883
TEST=Tried deleting the symlink and deleting the line from bashrc and things got updated; ran again w/ no problems.
Review URL: http://codereview.chromium.org/6480005
BUG=n0ne
TEST=./build_image and see it fail and ask me a question, instead of death
Change-Id: I27f7ac71ce74ff711e8b152ee202121d518045cd
Review URL: http://codereview.chromium.org/6417001
The original intent of this code was to prevent mounting
of the OEM partition. However, chromeos_startup mounts
/mnt/stateful_partition/home to /home and this file gets
hidden. Given that we might mount the OEM partition always
soon, removing this code.
BUG=chromium-os:11661
TEST=build_packages, build_image, ran suite_Smoke
Change-Id: I7ef4dd5c78484664cbdeb4ffaff26e2fcf8d2507
Review URL: http://codereview.chromium.org/6458007
I was getting the error about passing along an empty string argument, and this will fix that.
Change-Id: Iffd05fe570f3a6092bbeee05abf8a1884decd644
BUG=N0ne
TEST=remote testing in progress (no VM testing)
Review URL: http://codereview.chromium.org/6465014
into mod_image_for_test.sh rather than slightly different versions
of the same in image_to_usb.sh and image_to_vm.sh
Added a function to get a test image into common.sh
Added --inplace option to mod_image_for_test, which is the default,
and preserves the original behaviour. But using --noinplace it will
now do the copy for you.
Found that chromiumos_image.bin appears throughout the scripts, so added it and the test variant to common.sh
BUG=chromiumos-10126
TEST=run mod_image_for_test.sh with and without --noinplace
run image_to_usb.sh and image_to_vm.sh with both options
test on Seaboard that correct image is provided
Really we should have automated testing for these scripts
Change-Id: I5cfa91792c7fded35e7f4ca8f8f27c6b270817fb
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4fc5227
Review URL: http://codereview.chromium.org/5271010
Change-Id: I1118a840e8ecc0ae0620003ea79ee0fd4174a96b
BUG=chromium-os:11811
TEST=Boot the system, and run 'xset'. Also, run the BVT suite
TEST=Test mod_image_for_test.sh --factory_install to see that there are no error messages
Review URL: http://codereview.chromium.org/6451009
As documented by the developer workflow, this script need to be
called from outside the chroot. This adds a temporary reference to
the new location of chromeos-common.sh, unbreaking the factory
workflow, and giving us time to come up with a better solution.
TEST=run inside the chroot and outside the chroot
BUG=chromium-os:11769
Change-Id: Icb90211111629ed037bc40682a94200d949050e0
Review URL: http://codereview.chromium.org/6462007
TEST=chromite works in new location
BUG=chromium-os:11507
Change-Id: I8e5dee287dd0120f1cd01966953b79cf53a14790
Review URL: http://codereview.chromium.org/6371018
This hack is necessary for old chroots to ensure that we source a good
common.sh when the one inside the chroot is out of date. We'll be able
to get rid of this after everybody has updated their chroot to have a working
version of common.sh and/or we have deprecated running scripts from the
source directory.
Also fix logic for when common.sh is missing to exit properly.
BUG=chromium-os:11598
TEST=Verify that build_image still works when the old common.sh is present in
the chroot.
Change-Id: I2e8c2fd5ad06446e669ad665ee2e70f4364958fe
Review URL: http://codereview.chromium.org/6286084
