Clobbering the builder uncovered a bug that was lurking.
Change-Id: Ieb487d2112a7048438943aa96fba23e9c8412a13
BUG=chromium-os:8693
TEST=Running now
Review URL: http://codereview.chromium.org/6050004
This CL also fixes the outstanding issue where to won't report progress in
image_to_live on updates.
Change-Id: I1efaf17f0fd5ebb367ae0872377b4d5d0bf5dbf6
BUG=chromium-os:8680,chromium-os:8901
TEST=Ran it with --debug on the x86 pfq locally.
Review URL: http://codereview.chromium.org/6135002
This deals with the condition where on a clobber we don't actually
re-config to use ssh:// until the second run (because git config is
called before we first sync the code).
Change-Id: Icf1a46aced633b570db9d280b10ae6866af04709
BUG=chromium-os:10545
TEST=Unit tests
Review URL: http://codereview.chromium.org/6027006
Since the package.keywords change, it's already built as part of build_packages.
With this change we don't have to needlessly build chrome twice as part of the
pfq.
Change-Id: I8dae745496a5d6f6213663b034ffe8d279d4efd3
BUG=chromium-os:8693
TEST=Ran unittests
Review URL: http://codereview.chromium.org/5973003
We also print to /dev/stderr directly to avoid flushing issues which have been occassionally given us broken manifests printed out
Change-Id: I97819bbc31142432aa5ef926f99f2c4f90fd50ef
BUG=chromium-os:9714
TEST=Ran cbuildbot through sync
Review URL: http://codereview.chromium.org/5888003
Change-Id: I2760e33e1473ce04f7adeda39d0db5725eaa81ae
BUG=chromium-os:7072
TEST=Replaced ./build_packages with bash and ran command; valided env var set right.
Review URL: http://codereview.chromium.org/5930002
Change-Id: I32c17e7353b420d7a895acffab4579c9b861095c
BUG=chromium-os:8693
TEST=Ran it with chrome_rev=tot, latest_release and stable_release
Review URL: http://codereview.chromium.org/5854001
This specifically gets the pfq one step closer to being completely ready to rev. We add --noprebuilts for the chrome pfq as its not ready to host prebuilts and instead we push unstable ebuilds. Anush noticed an Anush today where we are revving even when we don't change, and I've addressed this also in this CL.
Specifically:
1) Sort in cbuildbot long options by long format
2) Add --noprebuilts so that the Chrome PFQ can use this for now.
3) Fixed a unittest that had broken in a previous CL for cros_mark_chrome_as_stable.
4) Add ability for chrome to only rev if something really has changed:
-- This means, if the new ebuild either:
-- doesn't have the exact same chrome_version
-- or diff -Bu (actual diff) between last ebuild and new ebuild isn't the same (i.e. detecting a 9999 change or different CROS_SVN_COMMIT)
Change-Id: I9b289c2168d6868299573f5d7c7a676380ee497e
BUG=chromium-os:8693
TEST=Ran unittests (cbuildbot, cros_mark_*) and ran cbuildbot with new chrome pfq items.
Review URL: http://codereview.chromium.org/5783001
Change-Id: I1ac3ed12df00424ba5ba2d1c61fd6fe9716e13b9
BUG=chromium-os:9714
TEST=Ran new unittests as well as ran cbuildbot on local b/cbuild
Review URL: http://codereview.chromium.org/5689003
This allows us to avoid deleting the board and still ensure our packages are
in sync with the full buildbot. This allows us to detect conflicts between
old and new packages.
BUG=chromium-os:10127
TEST=Run cbuildbot.py with emptytree feature forced to on and verify that
build_packages rebuilds all packages. Also run unit tests.
Change-Id: I83e186937e28eef44285724697895a4583910b58
Review URL: http://codereview.chromium.org/5652007
Chrome PFQ right now is uploading prebuilts which wasn't meant to happen :(
Change-Id: I502a0621a6c9f655e5a3f890dd79e00652925902
BUG=chromium-os:8693
TEST=Ran cbuildbot with --debug
Review URL: http://codereview.chromium.org/5595004
We also fix some of the configs for existing configurations.
Change-Id: I34baa9664ff9e91268c8bac976ab2ab0aee51bfb
BUG=chromium-os:9714
TEST=Running now with cbuildbot x86-generic-pre-flight-queue.
Review URL: http://codereview.chromium.org/5531002
Preflight prebuilts reference the last full build, so they should always be complete as long as the last full build is still there.
Also add host prebuilts to the preflight prebuilts.
BUG=chromium-os:5311
TEST=Run unit tests for cbuildbot and prebuilt.py. Test runs of cbuildbot.py with --dryrun.
Review URL: http://codereview.chromium.org/5344002
Change-Id: Id95f94c02cc2f6cbd70a029d4f8b94617b7cc071
This change updates cbuildbot.py to upload prebuilts and reference them via PREFLIGHT_BINHOST.
Also ensure make.conf ends in a newline, as it looks nicer.
BUG=chromium-os:5311
TEST=Test that prebuilt.py updates PREFLIGHT_BINHOST in right make.conf
file. Test that cbuildbot.py runs prebuilt.py with right
arguments. Run unit tests for cbuildbot and prebuilt.py. Test runs of cbuildbot.py with --dryrun. Test upload of Packages file to local web server and check that emerge works with them.
Change-Id: Iad03c6c469e05b9ee1cceff69cbe2bdd51225e25
Review URL: http://codereview.chromium.org/4969003
This also removes the rw_checkout var as it's not longer changes the affect of whether we use the ssh url or not.
Note that this replaces the other CL from last night because the other CL didn't work. The other CL still pulled in the same manifest that has http: url's for each git repo. I reverted that change last night after I noticed this.
Change-Id: I3d4ad2be6887ac2cf4ed2009bad9cae6dfdf5bbf
BUG=chromium-os:9509
TEST=Ran with cbuildbot --clobber and incremental
Review URL: http://codereview.chromium.org/5278010
Other things:
Removing commit|clean|push command from cros_mark_chrome because it's unnecessary ... I'm just gonna use the same stabilizing branch as the other stable marker, so I can use the same clean / push from the other script. This makes this change fit in much more nicely to cbuildbot.
Other changes:
Add ability for cros_mark_chrome_as_stable to communicate to calling script through stdout.
Make STABLE_BRANCH in cros_mark_as_stable public for above reason.
Removed push_options from cros_mark and accompanying change to cbuildbot as it isn't used anymore.
Made it easier to debug with cbuildbot (I ran cbuildbot A LOT of times to test this change so I felt the pain)...this includes:
- only build when syncing
- allow one to explicitly disable tests
- use dryrun is options.debug is set
Change-Id: I413a2e81a99cdde2e4d9139561cd518245b9b346
BUG=chromium-os:8693
TEST=Ran cbuildbot with --notest --debug --nosync x86-pre-flight and
saw it go through correctly and dryrun push. Ran cbuildbot with same and --chrome_rev=tot. Ran with syncing and running tests too.
Review URL: http://codereview.chromium.org/5154008
Change-Id: I680e28bcafbfeb4f19e2404e2b28761e26111f7f
BUG=chromium-os:9509
TEST=Ran cbuildbot on my local builder checkout with both clobber and without.
It sync'd and built.
Review URL: http://codereview.chromium.org/5312002
Change-Id: I6744aac09fb075f91f710f16343fab45b8dc8af9
BUG=chromium-os:7283
TEST=Ran it with cbuildbot through the unit tests phase and looked
at the file and saw it get parsed correctly.
Review URL: http://codereview.chromium.org/5124006
Preflight clean needs to wait until after the checkout happens before
it asserts that all of our overlays exist.
BUG=chromium-os:9197
TEST=Ran cbuildbot.py with missing chromiumos-overlay dir
Change-Id: If66574f01d1e85741e971919a9fa2da34f85872d
Review URL: http://codereview.chromium.org/5069001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=795bd30
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
What's new?
- cros_mark_as_stable now exits with errors if directories are specified
that don't exist.
- cbuildbot.py always explicitly specifies overlay directories so
cros_mark_as_stable can rely on them existing.
- Package names and paths are now separated with colons instead of
spaces, so as to allow for us using the same syntax with
enter_chroot.sh as we use without the same script. (enter_chroot.sh
mucks with command-lines that contain spaces or quotes.)
- All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.
BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable.
Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7
Review URL: http://codereview.chromium.org/4442001
When you pass '--foo="bar baz"' to a script, the argument is literally
passed as "bar baz", with the quotes. So we need to not add unnecessary
quotes in there.
When enter_chroot.sh parses arguments, it actually removes the quotes
for you, and splits up arguments. As a result, it may actually
be necessary to (1) use the above broken syntax when you call scripts
using enter_chroot.sh; but (2) don't use that syntax when calling
scripts without enter_chroot.sh. That's a broken situation, so I've
added a TODO for that. I've also added more warnings to
cros_mark_as_stable.py so that it's easier to debug when it doesn't
work.
BUG=chromium-os:8633
TEST=Ran unit tests. Planning to watch TOT buildbot post-commit to make sure behavior is right.
Change-Id: Ia1a0e60153fec60cb7ed4db2da128ffd9ae81e23
Review URL: http://codereview.chromium.org/4385002
BUG=chromium-os:8493
TEST=Ran unit tests. Verified that cros_mark_as_stable.py supports
running on just the private or public overlay.
Change-Id: I5e2e8fc5e63b3c93bb688a5ce87233315c0c2d1c
Review URL: http://codereview.chromium.org/4250001
Currently cros/master is used for the tracking branch in the preflight
rinse step. This is wrong if --tracking_branch is specified
differently in the command-line options to cbuildbot.py.
BUG=none
TEST=Ran unit tests
Change-Id: Id4fb989863ae11f57889faf6a8d8b043b81da58e
Review URL: http://codereview.chromium.org/4104005
Change-Id: Ic6d4a79a7ab58b8043805a6b826f251faa9f3a6c
BUG=
TEST=Running now (adding unit tests as well)
Review URL: http://codereview.chromium.org/4062003
Change-Id: If7db175f828fccdd4caa342a0370e842503f16dc
BUG=8015
TEST=Ran it with cbuildbot with/without --clobber with/without old state.
Review URL: http://codereview.chromium.org/4007005
What's new?
- cros_mark_all_as_stable is now in Python and has unit tests.
- We now detect and report coding errors that can cause incorrect behavior.
E.g., if 9999 ebuild or stable ebuild can't be found, we report a hard
failure so that developers will know about the problem.
- We now check that git hashes we report actually match up with the
right repository.
- Unified diff of changes are now printed to stdout, so that developers
can see a list of the changes and debug any problems.
- cros_mark_all_as_stable now takes 2.5 seconds to run.
BUG=chromium-os:7795
TEST=Manually examined diff output from run of cros_mark_all_as_stable
on full repository.
Change-Id: I762597c9b94e5f8e8171b83c966ad54e21a65c1b
Review URL: http://codereview.chromium.org/3798003
Change-Id: Idda6c7287cdb1863eb4abe8c56da2e763e9fe777
BUG=7926
TEST=Ran with --debug and verified I didn't push a change.
Review URL: http://codereview.chromium.org/3880002
src.chromium.org is no longer supported for git operations.
BUG=chromium-os:7830
TEST=none
Change-Id: Ia7cd9ff76625441f16d20d2f9a8e0f752dca0586
Review URL: http://codereview.chromium.org/3782010
This reverts commit 365d4b0cc8.
Fix preflight breakage, this seems like the most possible cause. Will recommit if not.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3767012
Change-Id: I93fe463fec77c445e7ff0ec86db25d5ef2997ad7
