This is necessary for two reasons:
1) It's nice to get an error message when mount/unmount fails
2) set -e mode doesn't have any effect when you're in a subshell
Note that these mount/unmount failures do happen regularly in development,
so folks who depended on mount/umount failing silently will no longer be
able to rely on this and will have to kill the mounts manually.
Also fix subtle bugs in regexes for matching mount paths. (E.g. where the
regex for $HOME/chroot also matches $HOME/chroot2).
TEST=Tested mount/unmount with concurrently open shells.
Tested mount/unmount when mount is being used by a process but the
lock file does not reflect this.
BUG=none
Review URL: http://codereview.chromium.org/1211001
Make this script's output better formatted. Better describe how
to disambiguate control files when multiple match. Get rid of
the output_file concept since it's not needed. Don't output
a results directory if there's an ambiguity.
Review URL: http://codereview.chromium.org/1090005
It worked when all mod for test script works inside chroot. But not anymore since "df /" now report the host disk space, not the rootfs.
Review URL: http://codereview.chromium.org/1130005
Merge branch 'master' of ssh://chromiumos-git//chromeos
Merge branch 'master' of ssh://chromiumos-git//chromeos
Pointing each board to its own binhost cache.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/795002
Get rid of chroot inside this script, and not mounting mod_for_test_scripts into rootfs any more.
The reason caused the failure here is once you chroot into the mounted rootfs directory, all binaries were searched inside the rootfs. But all binaries inside the arm rootfs was for arm hardware, so not executable on the host linux machine(intel).
Review URL: http://codereview.chromium.org/845007
This change may be controversial -- it will basically make the x86-generic
full buildbot fail if tests fail to build.
There are a few options:
1. do this and see how it goes;
2. don't do this and rely on the test failing to run;
3. do this but also change buildbot to pass --nobuildcheck to build_autotest
Review URL: http://codereview.chromium.org/848005
When grabbing buildbot image and test artifacts, properly install the test artifacts as if they were built by the user (with the user as owner).
Review URL: http://codereview.chromium.org/703001
2. I dont fully understand why we need sudo inside this script. So I am removing it. Since I could not enter sudo password inside crontab. Please let me know if I missed anything and I could revert.
Review URL: http://codereview.chromium.org/666002
This saves almost 1 minute (out of 6) on my build host for the current full
build_autotest.sh. The savings will be more significant once the Chrome tests
(200MB+) also get into autotest.
Alternatively, we could still build the binary package and use it as part of
archive_build.sh (i.e., just copy it there instead of creating a new one).
But most people don't run archive_build so it may be better to not create
the binary package as part of build_autotest.sh.
Review URL: http://codereview.chromium.org/661473
