Commit Graph

25366 Commits

Author SHA1 Message Date
Mandeep Singh Baines
4ea330f007 build_image: honor USE flags from environment
BUG=n0ne
TEST=Ran the following command to test:

USE="-compat_wireless" ./build_image

Change-Id: I4b3fd12c1f62e1b2551045a5831a63d848fe2a3f

Review URL: http://codereview.chromium.org/5139003
2010-11-17 18:11:58 -08:00
Chris Sosa
684d5dbccf Add retries to pfq push.
Change-Id: Ie4632acf22bedb0c94de0cb3fe67b549fc2d0871

BUG=chromium-os:9323
TEST=Ran it and inserted exception for push_try < 3 and
mocked out push.

Review URL: http://codereview.chromium.org/5142003
2010-11-17 17:48:26 -08:00
Nick Sanders
a436eb8ef6 Add per board customization, clean up private autotests.
BUG=1583
TEST=actually builds

Change-Id: I6510f30faf3f3c2e88b4ea9c63985c09086e1a5d

Review URL: http://codereview.chromium.org/4482001
(cherry picked from commit afba119639afe0fb8206e58ead091f2efd114192)

Allow branch customization for factory

BUG=1583
TEST=removes superfluous files

Change-Id: I576fc0dd811f9c1ed6299a539e0e8a014b37bdc8

Review URL: http://codereview.chromium.org/4376001
(cherry picked from commit 08fdc9da26456c286254c250366bdfc738f8ed38)

No pagecycler for factory image

BUG=1583
TEST="build, no pagecycler in factory."

Change-Id: I43d23de5d518634697e17a32bcd94a43aad46aba

Review URL: http://codereview.chromium.org/4342002
(cherry picked from commit f3e98785f3ed3f4e87e4287ee3ec45e2fc737c89)

Review URL: http://codereview.chromium.org/5091002
2010-11-17 16:50:02 -08:00
David McMahon
765d7c2180 Created branch 0.9.118.B. Update CHROMEOS_VERSION_BRANCH=119
Change-Id: Ia2a698501ad1532f6a3936bdb9d97a639431afcc
2010-11-17 16:39:55 -08:00
Paul Stewart
f7597abb17 Use new stateful image builder
Also change download filenames

BUG=chromium-os:9308
TEST=Run script

Review URL: http://codereview.chromium.org/5149002

Change-Id: Id9ed150184559ab31274dc3b4f58bf9fe0a0f76c
2010-11-17 16:22:28 -08:00
Raja Aluri
8f2a9950b9 passing CHROMEOS_RELEASE_APPID to the PASSTHRU list into chroot
Change-Id: Ib5296eb4d3eea6d2430cde04d855ccbefd507bf4

BUG=
TEST=

Review URL: http://codereview.chromium.org/5132002
2010-11-17 15:03:00 -08:00
Gaurav Shah
dc4a6446e9 Set success=1 for the recovery kernel
This will prevent the firmware from updating the tries flag on a USB recovery image.

Change-Id: I47bf276eab5b40ae54b732d0e082e4c9f58bfed3

BUG=chromium-os:6550
TEST=build_package, build_image, cgpt show recovery_image.bin (successful flag should be set to 1)

Review URL: http://codereview.chromium.org/4979007
2010-11-17 14:11:43 -08:00
David McMahon
b08d47ca16 Created branch 0.9.116.B. Update CHROMEOS_VERSION_BRANCH=117
Change-Id: Ia92bacb78ae6f54afea52e02cc93b548ee0a4cfb
2010-11-16 21:41:52 -08:00
Raja Aluri
e891eea06f passing CHROMEOS_RELEASE_APPID to the PASSTHRU list into chroot
Change-Id: I906f1959769ac9d7a2abc04827cad8f5201984de

BUG=chromeos:9168
TEST=Made sure that setting and unsetting this value and enter_chroot is honoring the pass thru setting.

Review URL: http://codereview.chromium.org/5008006
2010-11-16 20:12:56 -08:00
Nick Sanders
867fde26b7 Allow RO rootfs and writeable stateful.
BUG=9423
TEST=mount an image --safe, rootfs OK

Change-Id: I4bc48e742e2438a1d2cae17c752743e02bd124fd

Review URL: http://codereview.chromium.org/4974006
2010-11-16 20:05:06 -08:00
David James
d4993a7311 Don't use output argument for CalledProcessError (Python 2.7 only)
Also add _Print statement so that stdout is printed.

BUG=chromium-os:9257
TEST=Run cros_mark_as_stable.py clean / commit

Change-Id: I9a01d6369d4b14ca0be812b8b1509c8375b1d575

Review URL: http://codereview.chromium.org/5063004
2010-11-16 15:47:25 -08:00
Scott Zawalski
085b5d8fba Merge branch 'master' of ssh://gitrw.chromium.org:9222/crosutils 2010-11-16 10:24:49 -08:00
David James
8ce0100b03 Retry in parallel_emerge for 5xx error codes.
When the server returns a 5xx error code, we should retry. Such errors are
often due to flakiness, so retries resolve the issue.

BUG=chromium-os:9217
TEST=Tested parallel_emerge with fake URL to verify it retries.

Change-Id: Ie5cf003562b5261005be9929624769394b4802a1

Review URL: http://codereview.chromium.org/5056003
2010-11-16 10:20:08 -08:00
Scott Zawalski
b593c39e9d Add a RevGitWithRetry method to retry repo sync and git push
Modify repo sync to just sync the repo we are in,
this is what preflight does and is a proven acceptable approach over
the complete 'repo sync' approach.

BUG=8987
TEST=Ran retry command over dummy directories to be sure it retries
as expected.

Review URL: http://codereview.chromium.org/5082002
2010-11-16 10:00:07 -08:00
Scott Zawalski
4e85f966a4 Check value in except 2010-11-16 09:48:09 -08:00
Scott Zawalski
01c62e5da6 Add in sleep between retries 5 seconds * retry 2010-11-16 09:27:17 -08:00
Scott Zawalski
3309df01c8 Merge branch 'master' of ssh://gitrw.chromium.org:9222/crosutils 2010-11-16 09:14:22 -08:00
Scott Zawalski
ec41e52159 Remove superfluous space 2010-11-16 09:14:10 -08:00
Scott Zawalski
93954efeda Add a RevGitWithRetry method to retry repo sync and git push
Modify repo sync to just sync the repo we are in, this is what preflight
does and is a proven acceptable approach over the complete 'repo sync' approach.

BUG=8987
TEST=Ran retry command over dummy directories to be sure it retries
as expected.
2010-11-16 09:12:01 -08:00
Raja Aluri
2d9f97232f Created branch 0.9.114.B. Update CHROMEOS_VERSION_BRANCH=115
Change-Id: Ic4f7e18815a65fcceb60d4584150abea6164aa30
2010-11-15 22:45:05 -08:00
David James
77f281a75e Move sanity checks for missing directories until after checkout happens.
Preflight clean needs to wait until after the checkout happens before
it asserts that all of our overlays exist.

BUG=chromium-os:9197
TEST=Ran cbuildbot.py with missing chromiumos-overlay dir

Change-Id: If66574f01d1e85741e971919a9fa2da34f85872d

Review URL: http://codereview.chromium.org/5069001
2010-11-15 20:39:00 -08:00
David James
d87170bb7b Fix infinite loop when FindRepoDir argument is a relative path.
This bug doesn't affect production but affects the unit tests.

BUG=chromium-os:9201
TEST=Confirmed this fixes an infinite loop in the unit tests, and that
    cbuildbot.py still works.

Change-Id: I1a56b92d8229110c84cebbe877e55fb99f053212

Review URL: http://codereview.chromium.org/5025002
2010-11-15 18:57:19 -08:00
David James
f7502a6e03 Special-case preflight clean to allow for missing directories.
If there's no directory, I guess things are really, really clean.

BUG=chromium-os:9197
TEST=Ran cros_mark_as_stable.py clean with missing overlay directories.

Change-Id: I3f4811fe01bca56e850f823a973476884292e278

Review URL: http://codereview.chromium.org/4988004
2010-11-15 18:09:10 -08:00
Chris Sosa
4e75efa930 Add option to check version of Chrome on target.
Change-Id: I34e9d64656e04d4f5c477914512219d9b8563b78

BUG=chromium-os:9137
TEST=Ran with both wrong and right versions against a Google Chrome and
Chromium build

Review URL: http://codereview.chromium.org/4942001
2010-11-15 15:12:06 -08:00
Paul Stewart
b94e40293d Add port flag to remote_rsync_from
Ass ${FLAGS_ssh_port} to ssh arguments for rsync

BUG=chromium-os:9187
TEST=Run rsync-related script with port argument

Change-Id: Iefabef230cfff03dcd66ac0c24798bb4b13ce40d

Review URL: http://codereview.chromium.org/4998004
2010-11-15 14:11:49 -08:00
David James
b49c6df754 Add more error checking to preflight queue.
What's new?
  - cros_mark_as_stable now exits with errors if directories are specified
    that don't exist.
  - cbuildbot.py always explicitly specifies overlay directories so
    cros_mark_as_stable can rely on them existing.
  - Package names and paths are now separated with colons instead of
    spaces, so as to allow for us using the same syntax with
    enter_chroot.sh as we use without the same script. (enter_chroot.sh
    mucks with command-lines that contain spaces or quotes.)
  - cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
  - All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.

BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.

Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=795bd30

Review URL: http://codereview.chromium.org/4442001
2010-11-15 13:06:42 -08:00
Kris Rambish
43c22803a1 Make removing the last ] more full-proof
Make removal of last ] more full-proof

Change-Id: I002e5ed513066a214fd6353f66e05bf5458f6ad4

BUG=7115
TEST= No file, with --subfolder
  No file, without --subfolder
  Empty file
  File with one config already in it, with --subfolder
  File with one config and garbage at the end, with --subfolder
  File with one config and newlines at the end, with --subfolder
  File with one config, without subfolder

Review URL: http://codereview.chromium.org/4688004
2010-11-15 11:26:22 -08:00
Scott Zawalski
f057702603 Merge branch 'master' of ssh://gitrw.chromium.org:9222/crosutils 2010-11-15 09:44:13 -08:00
David McMahon
37f4222632 Stop using CHROME_BUILD altogether - companion change coming in crostools.
BUG=
TEST=

Review URL: http://codereview.chromium.org/4917001
2010-11-12 16:17:59 -08:00
Don Garrett
132ff4320d cros_generate_upload_payload --patch_kernel should mount from the source
image read only to avoid unintended changes.

Change-Id: Id3a83786f2c1240a4401978c8cacffc0dcb9d66f

BUG=9073
TEST=Ran script with --patch_kernel, verified source image unmodified.
Ran ./image_to_live.sh to verify valid update was generated.

Review URL: http://codereview.chromium.org/4892002
2010-11-12 15:29:30 -08:00
Chris Sosa
5a886ff53d Don't allow hardlinks in tarball.
These errors on extraction if you don't have the original targets
of the links on the image (i.e. if the stateful_partition gets wiped).

Change-Id: Id5d3f770830de6165613d506733c04edefccd3fb

BUG=chromium-os:9103
TEST=Ran update, wiped partition, ran stateful_update and ran bvt's.

Review URL: http://codereview.chromium.org/4882006
2010-11-12 15:20:27 -08:00
David James
02b3e4f3d5 Revert "Add more error checking to preflight queue."
This reverts commit 795bd30f06.

BUG=
TEST=

Review URL: http://codereview.chromium.org/4904003

Change-Id: I9148026ecd0df75c253cfcf0c67af3d26771dd21
2010-11-12 14:47:57 -08:00
David James
795bd30f06 Add more error checking to preflight queue.
What's new?
  - cros_mark_as_stable now exits with errors if directories are specified
    that don't exist.
  - cbuildbot.py always explicitly specifies overlay directories so
    cros_mark_as_stable can rely on them existing.
  - Package names and paths are now separated with colons instead of
    spaces, so as to allow for us using the same syntax with
    enter_chroot.sh as we use without the same script. (enter_chroot.sh
    mucks with command-lines that contain spaces or quotes.)
  - cbuildbot.py now ensures its build path is a absolute path. This ensures we don't kill the wrong processes, if, for instance, the buildpath is '../..'
  - All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.

BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable. Ran cbuildbot.py test run.

Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7

Review URL: http://codereview.chromium.org/4442001
2010-11-12 14:33:14 -08:00
Hung-Te Lin
bcc60b625d crosutils: move image_common.sh to lib/cros_image_common.sh
The team is moving utility/library scripts into 'lib' folder.
image_common.sh should follow this policy.

Also refined the parameter check of mk_memento_images.sh

BUG=chromium-os:5208
TEST=./make_factory_package.sh --factory PATH_TO_FACTORY --release PATH_TO_RELEASE;
     # factory bundle created successfully
     ./mk_memento_images.sh PATH_TO_PART2 PATH_TO_PART3
     # update.gz created successfully
     ./mk_memento_images.sh PATH_TO_IMGE 2 3
     # update.gz created successfully

Change-Id: I3afecf05da2832986723f28b595045d0540ea9e9

Review URL: http://codereview.chromium.org/4825004
2010-11-13 05:36:20 +08:00
Chris Sosa
c60e567799 Convert rootfs and stateful mountpts to absolute paths.
Change-Id: Ib9b6b9ba7787fba337e71e4968a5c152b5a21e14

BUG=chromiumos:8885
TEST=Ran with default options and setting --rootfs_mountpt and stateful_mountpt
to dirs in my current workig directory ... saw cleanup correctly on unmount

Review URL: http://codereview.chromium.org/4853001
2010-11-12 10:54:25 -08:00
Hung-Te Lin
51484a96e9 crosutils: refine memento image / factory package creation
This CL improves creation of memento / factory image payload by:
 - verbose progress report
 - allowing to compress by pigz, the parallel version of gzip
 - prevents unpacking entire image if partition tools (cgpt/parted)
   is available.

BUG=chromium-os:6536,chromium-os:5208
TEST=Verified executing "time ./make_factory_package.sh ..." for ToT factory bundle:
 - before this CL (memento gzip param is not -9): 3m53.126s
 - after this CL, without pigz, with cgpt: 2m34.897s
 - after this CL, with pigz+cgpt, memento_gz=-9: 0m45.603s
 - after this CL, with pigz, without cgpt/parted, memento_gz=-9: 1m49.748s
 Also verified such bundle can be installed on a real netbook device.

Change-Id: Ie182844ea5482d6d321b9549fa584377edf7dfe3

Review URL: http://codereview.chromium.org/4824003
2010-11-13 02:43:14 +08:00
Raja Aluri
4ca4b147e5 Created branch 0.9.112.B. Update CHROMEOS_VERSION_BRANCH=113
Change-Id: Ia23fb80872a902750d113a6bbe65595ffbd6d720
2010-11-11 18:26:41 -08:00
Raja Aluri
d44bcf9a45 Adding a script to generate au-geneate.zip file
Change-Id: Ifc47ed28dc3efc0e7ebd018f6703b36913ffd39c

BUG=8716
TEST=Ran the script inside the chroot to makesure it is generating the package.

Review URL: http://codereview.chromium.org/4425004
2010-11-11 17:46:53 -08:00
David James
4beb5cb58f Revert "Add more error checking to preflight queue."
This reverts commit b4258c8bd4.

BUG=br0ken build
TBR=rspangler
TEST=

Review URL: http://codereview.chromium.org/4697007

Change-Id: I839ffd08d33fc5943696cfe31f2978fe32ce5fec
2010-11-11 10:51:07 -08:00
David James
f9b84d61a1 Define buildroot properly.
Followup to "Add more error checking to preflight queue."
BUG=Br0ken build
TBR=kliegs@chromium.org
TEST=Ran unit tests

Review URL: http://codereview.chromium.org/4742004

Change-Id: I63e52265ae404f0193cb1f9ab35f3f1ec266d2c1
2010-11-11 10:45:12 -08:00
David James
b4258c8bd4 Add more error checking to preflight queue.
What's new?
  - cros_mark_as_stable now exits with errors if directories are specified
    that don't exist.
  - cbuildbot.py always explicitly specifies overlay directories so
    cros_mark_as_stable can rely on them existing.
  - Package names and paths are now separated with colons instead of
    spaces, so as to allow for us using the same syntax with
    enter_chroot.sh as we use without the same script. (enter_chroot.sh
    mucks with command-lines that contain spaces or quotes.)
  - All buildbots now explicitly specify what overlays they want to rev. Public buildbots only rev public ebuilds and private buildbots now only rev private ebuilds.

BUG=chromium-os:8647
TEST=Ran unit tests. Manually marked packages as stable.

Change-Id: I1df6d428973d91329c4f5159e2886889a3ebb7c7

Review URL: http://codereview.chromium.org/4442001
2010-11-11 10:37:04 -08:00
Chris Sosa
9a40915f00 Add new stateful upload payload generator to crosutils.
Change-Id: I53a24d6188711a248a1dc7c869aa9258b10970d2

BUG=chromium-os:8885
TEST=Ran by itself with latest image and current directory as my
output dir as well as with new dev server changes.

Review URL: http://codereview.chromium.org/4688006
2010-11-10 17:31:51 -08:00
Ken Mixter
5bedbc9ad7 crosutils: Require cros_show_stacks to run inside chroot
Change-Id: I28e01fb8ddb542eddf3750def7d49cd40822d6d9

BUG=9026
TEST=Try outside chroot

Review URL: http://codereview.chromium.org/4782003
2010-11-10 16:42:43 -08:00
Chris Masone
f8513d84fe [crosutils] Propagate use_emerged flag up from run_remote_tests
BUG=8544
TEST=build chrome with build_tests, cros_workon start autotest, and then run desktopui_BrowserTest with cros_run_parallel_vm_tests

Change-Id: I19e181238fd75450d41f6debb3a8f7d0c17d15dc

Review URL: http://codereview.chromium.org/4669007
2010-11-09 14:23:29 -08:00
Chris Masone
d11ce17167 [crosutils] Mask out /usr/local/autotest-pkgs on install
BUG=8544
TEST=build image with --factory_install, ensure that image does not have data in /usr/local/autotest-pkgs

Change-Id: I5ed17d794392ec654bc122fa15f7ab8a7abbba2d

Review URL: http://codereview.chromium.org/4756001
2010-11-09 14:22:08 -08:00
Chris Masone
7d04c7aacb [crosutils] bump default size of VM disk to allow for bigger stateful partition
BUG=8544
TEST=create an VM image with image_to_vm.sh; the stateful partition should be 2GB in size.

Change-Id: I6c0ee9e2cb513e42c25e4f0d1616835a41f378d7

Review URL: http://codereview.chromium.org/4737001
2010-11-09 08:24:13 -08:00
J. Richard Barnette
4800e04fe8 Try and get the internal buildbot smoke tests to pass
BUG=chromium-os:8910
TEST=None

Review URL: http://codereview.chromium.org/4683007

Change-Id: I3ff1ccdd038255d8c3594f853ced614ccafc2af3
2010-11-08 19:29:26 -08:00
Ken Mixter
08145697a5 crosutils: Add vnc view of tests running multiple tests for VM tests
Change-Id: I87c41e60797848192cee1f0c165215fcec8f5bd2

BUG=8850
TEST=Ran a few tests including suite_Smoke

Review URL: http://codereview.chromium.org/4647001
2010-11-08 18:10:08 -08:00
Doug Anderson
ec5d7f0d2d Code cleanup: comments, docstrings, and gpylint fixes.
Most of this is from this code review:
  http://codereview.chromium.org/4175007/diff/1/2

I also ran the code through gpylint and fixed some of the stuff,
like making quoting consistent.

Change-Id: Icb3896dbd4e975c7ea4687d58efd6372adfcc3c9

BUG=chromium-os:8205
TEST=Ran ./cros_changelog 0.7.48.0 and saw error; also ran ./cros_changelog 0.9.98.3

Review URL: http://codereview.chromium.org/4263001
2010-11-08 14:46:03 -08:00
Ken Mixter
47fd7b5c51 crosutils: Always pass an image to devserver so it can pregenerate
Change-Id: Ib366064df269bd0d4aee30e5b1628938bd8fedf9

BUG=8313
TEST=Running it once without passing an image

Review URL: http://codereview.chromium.org/4208003
2010-11-08 13:35:05 -08:00