From ea75b60a45deeddce98d9c860777af1042742d2a Mon Sep 17 00:00:00 2001 From: David James Date: Tue, 23 Oct 2012 09:44:33 -0700 Subject: [PATCH] Don't tell users that it's a bad idea to use gclient. Users sometimes want to run gclient inside the chroot, so we shouldn't tell users that using it is a bad idea. The original reason why this message was added is historical: Originally, users had a newer version of SVN inside the chroot compared to on their workstation, so if you ran SVN inside the chroot it would permanently upgrade your working copy such that the version of SVN outside the chroot did not work with it anymore. This isn't a problem anymore, so we can remove the message. BUG=none TEST=Run remote trybot runs of chromiumos-sdk Change-Id: I7b82a5c94e29d5928f4bb296ae2d99cef397d365 Reviewed-on: https://gerrit.chromium.org/gerrit/36346 Reviewed-by: Mike Frysinger Commit-Ready: David James Tested-by: David James --- sdk_lib/make_chroot.sh | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sdk_lib/make_chroot.sh b/sdk_lib/make_chroot.sh index 44933092ca..e48757be67 100755 --- a/sdk_lib/make_chroot.sh +++ b/sdk_lib/make_chroot.sh @@ -298,13 +298,6 @@ EOF echo ". ~/trunk/src/scripts/bash_completion" \ >> "$FLAGS_chroot/home/$USER/.bashrc" - # Warn if attempting to use source control commands inside the chroot. - for NOUSE in svn gcl gclient - do - echo "alias $NOUSE='echo In the chroot, it is a bad idea to run $NOUSE'" \ - >> "$FLAGS_chroot/home/$USER/.bash_profile" - done - if [[ "$USER" = "chrome-bot" ]]; then # Copy ssh keys, so chroot'd chrome-bot can scp files from chrome-web. cp -r ~/.ssh "$FLAGS_chroot/home/$USER/"