From e1010d8cb26f8cfe4c2e2ba9b486ac1ff0a32c06 Mon Sep 17 00:00:00 2001 From: "J. Richard Barnette" Date: Tue, 26 Oct 2010 11:21:47 -0700 Subject: [PATCH] Fix two very broken tests for null strings in archive_build.sh Change-Id: I7c5d251ab1ae020c3ae8a10ca017c34a02eff893 BUG=None TEST=./archive_build.sh --test_mod TEST=./archive_build.sh --test_mod --from=../build/images/x86-generic TEST=./archive_build.sh --board=x86-generic --gsutil_archive=/tmp --gsutil=echo TEST=./archive_build.sh --board=x86-generic --gsutil_archive=/tmp --gsutil=echo --gsd_gen_index=echo Review URL: http://codereview.chromium.org/4153001 --- archive_build.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/archive_build.sh b/archive_build.sh index 64a4ee4093..785273e14b 100755 --- a/archive_build.sh +++ b/archive_build.sh @@ -67,7 +67,7 @@ fi # Die on any errors. set -e -if [ -z $DEFAULT_USED ] +if [ -z "$DEFAULT_USED" ] then if [ $FLAGS_test_mod -eq $FLAGS_TRUE ] || \ [ $FLAGS_factory_install_mod -eq $FLAGS_TRUE ] || \ @@ -244,7 +244,7 @@ function gsutil_archive() { echo "Using gsutil to archive to ${OUT_PATH}..." ${FLAGS_gsutil} cp ${IN_PATH} ${FULL_OUT_PATH} ${FLAGS_gsutil} setacl ${FLAGS_acl} ${FULL_OUT_PATH} - if [ $FLAGS_gsd_gen_index != "" ] + if [ -n "$FLAGS_gsd_gen_index" ] then echo "Updating indexes..." ${FLAGS_gsd_gen_index} \