mirrors/flatcar-scripts
1
0
Fork 0
mirror of https://github.com/flatcar/scripts.git synced 2025-08-19 05:21:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

eclass: remove also other optimization flags with -Wl,-O*

Browse Source 
We need to filter not only `-Wl,-O1`, but also other flags like
`-Wl,-O2`, `-Wl,-Og`, `-Wl,-Os`, etc. Otherwise, SDK build would fail,
for example, as its default `$LDFLAGS` includes `-Wl,-O2`.

We need to manually strip only the optimization element of
comma-separated flags, e.g. from `-Wl,-O1,-s` to `-Wl,-s`.
To support multiple characters that can follow `-O`, e.g. `-Ofast`,
we should use regexp like `[[:alnum:]]*`.
This commit is contained in:
Dongsu Park 2020-11-16 12:40:24 +01:00
parent dc242f0fc9
commit dd15b2ee4d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sdk_container/src/third_party/coreos-overlay/eclass/coreos-go-utils.eclass vendored
View File

@ -87,7 +87,14 @@ go_export() {
# Remove certain flags from $LDFLAGS to fix validation errors in # Remove certain flags from $LDFLAGS to fix validation errors in
# Go >= 1.15.5 like: # Go >= 1.15.5 like:
# go build runtime/cgo: invalid flag in go:cgo_ldflag: -Wl,-O1 # go build runtime/cgo: invalid flag in go:cgo_ldflag: -Wl,-O1
filter-ldflags "-Wl,-O1" #
# Note, we need to manually strip only the optimization element of
# comma-separated flags, e.g. from `-Wl,-O1,-s` to `-Wl,-s`.
# To support multiple characters that can follow `-O`, e.g. `-Ofast`,
# we should use regexp like `[[:alnum:]]*`.
# Work-around for https://github.com/golang/go/pull/42631.
export LDFLAGS="$(echo "$LDFLAGS" | sed 's/,-O[[:alnum:]]*//g')"
filter-ldflags "-Wl"
export CC=$(tc-getCC) export CC=$(tc-getCC)
export CXX=$(tc-getCXX) export CXX=$(tc-getCXX)