From c750ac2c4d7b58a1f16805e4a90c5a81eec667ae Mon Sep 17 00:00:00 2001 From: Nick Sanders Date: Mon, 7 Mar 2011 10:06:31 -0800 Subject: [PATCH] crosutils/mod_for_factory_scripts: don't change VT on factory service stop In http://codereview.chromium.org/6567004 in order to help developers stopping factory UI, we've added an "chvt 2". However changing foreground terminal may hang when executing "shutdown -r" inside Wipe test. Removing the "chvt" call solved this issue. The only side effect is that developers executing "initctl stop factory" may end seeing a black scren - and they need to hit Ctrl-Alt-F2 to get the console back. BUG=chrome-os-partner:2631 TEST=build a factory image then verified following steps: (1) in VT2, do "initctl stop factory, then C-A-F2: screen changed to VT2. (2) Execute factory tests until Wipe: reboots immediately when X closed (3) Execute Reboot in HWID test: reboots immediately when 'reboot' is ACTIVE Change-Id: Ib6f44a6ad07db08862929179d0fe21cbbcc2b22a Review URL: http://codereview.chromium.org/6621041 --- mod_for_factory_scripts/200patchInitScript | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mod_for_factory_scripts/200patchInitScript b/mod_for_factory_scripts/200patchInitScript index 5c58b63929..3ad9213aa8 100755 --- a/mod_for_factory_scripts/200patchInitScript +++ b/mod_for_factory_scripts/200patchInitScript @@ -53,10 +53,6 @@ pre-stop script pkill python pkill X end script - -post-stop script - chvt 2 -end script EOF cat >"${ROOT_FS_DIR}/etc/init/factorylog.conf" <