mirrors/flatcar-scripts
1
0
Fork 0
mirror of https://github.com/flatcar/scripts.git synced 2026-05-04 19:56:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

run_sdk_container: Bail out on unknown flags

Browse Source 
The script would pass unknown flags further as a container
command. This normally is not desired, but in case it actually is, the
user can use the newly added `--` parameter to stop parameter handling
and pass the following parameters as the container command.

I was tripped by using -u instead of -U and I got a rather confusing
error message suggesting something going wrong inside the container.
This commit is contained in:
Krzesimir Nowak 2025-01-09 15:01:33 +01:00
parent 8357e5cabf
commit c526b41729
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
run_sdk_container
View File

@ -22,7 +22,7 @@ mounts=()
usage() {
echo " Usage:"
echo " $0 [-t] [-v <version>] [-V <SDK version>] [-a <amd64|arm64|all>] [-n <name> ] [-x <script>] [-C <custom-container>] [--rm] [-U] [-m <src>:<dest>] [<container-command>]"
echo " $0 [-t] [-v <version>] [-V <SDK version>] [-a <amd64|arm64|all>] [-n <name> ] [-x <script>] [-C <custom-container>] [--rm] [-U] [-m <src>:<dest>] [--] [<container-command>]"
echo " Start an SDK container of a given SDK release version."
echo " This will create the container if it does not exist, otherwise start the existing container."
echo " If the container is already running then it will exec into the container."
@ -49,6 +49,7 @@ usage() {
echo " -U Do not update the versionfile. Instead, use the version from the versionfile as-is."
echo " -m <src>:<dest> - Mount local file or directory inside the container."
echo " Can be specified multiple times."
echo " -- Stop parsing options at this point, pass the rest as the container command."
echo " -h Print this help."
echo
}
@ -72,6 +73,8 @@ while [[ $# -gt 0 ]] ; do
update_versionfile=
shift;;
-m) mounts+=( -v "$2" ); shift; shift;;
--) shift; break;;
-*) echo "Unknown flag ${1@Q}, use '-h' or '--help' for usage"; exit 1;;
*) break;;
esac
done