From c075f0401e07c3582250073216a2c0549b109064 Mon Sep 17 00:00:00 2001
From: Zdenek Behan <zbehan@chromium.org>
Date: Tue, 13 Jul 2010 13:31:44 -0700
Subject: [PATCH] cros_workon: corner case fixes

* Warn if user stops working on a package he wasn't working on
* Warn if user starts to work on a package he already is working on

Review URL: http://codereview.chromium.org/2978002
---
 cros_workon | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/cros_workon b/cros_workon
index ff4414fc9c..fb73f09abd 100755
--- a/cros_workon
+++ b/cros_workon
@@ -101,6 +101,8 @@ ebuild_to_live () {
     if ! grep -qx "${atom}" "${KEYWORDS_FILE}" ; then
       sudo bash -c "echo \"${atom}\" >> \"${KEYWORDS_FILE}\""
       sudo bash -c "echo \"~${atom}-9999\" >> \"${UNMASK_FILE}\""
+    else
+      warn "Already working on ${atom}"
     fi
   done
 }
@@ -110,15 +112,18 @@ ebuild_to_stable () {
   local atoms=$1
 
   for atom in ${atoms}; do
-    # remove the keyword
-    sudo bash -c "grep -v '^${atom}\$' \"${KEYWORDS_FILE}\" > \
-        \"${KEYWORDS_FILE}+\""
-    sudo mv "${KEYWORDS_FILE}+" "${KEYWORDS_FILE}"
-    # remove the unmask
-    sudo bash -c "grep -v '^~${atom}-9999\$' \"${UNMASK_FILE}\" > \
-        \"${UNMASK_FILE}+\""
-    sudo mv "${UNMASK_FILE}+" "${UNMASK_FILE}"
-
+    if grep -qx "${atom}" "${KEYWORDS_FILE}" ; then
+      # remove the keyword
+      sudo bash -c "grep -v '^${atom}\$' \"${KEYWORDS_FILE}\" > \
+          \"${KEYWORDS_FILE}+\""
+      sudo mv "${KEYWORDS_FILE}+" "${KEYWORDS_FILE}"
+      # remove the unmask
+      sudo bash -c "grep -v '^~${atom}-9999\$' \"${UNMASK_FILE}\" > \
+          \"${UNMASK_FILE}+\""
+      sudo mv "${UNMASK_FILE}+" "${UNMASK_FILE}"
+    else
+      warn "Not working on ${atom}"
+    fi
   done
 }